Patch Detail
Show a patch.
GET /api/1.1/patches/23101/?format=api
{ "id": 23101, "url": "https://patchwork.libcamera.org/api/1.1/patches/23101/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23101/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250402073133.15710-1-stanislaw.gruszka@linux.intel.com>", "date": "2025-04-02T07:31:33", "name": "[v3] ipa: simple: Initialize ccmEnabled to false", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "b8c9ee33298925f643c42fdbc1cfaa1510e9c688", "submitter": { "id": 211, "url": "https://patchwork.libcamera.org/api/1.1/people/211/?format=api", "name": "Stanislaw Gruszka", "email": "stanislaw.gruszka@linux.intel.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23101/mbox/", "series": [ { "id": 5104, "url": "https://patchwork.libcamera.org/api/1.1/series/5104/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5104", "date": "2025-04-02T07:31:33", "name": "[v3] ipa: simple: Initialize ccmEnabled to false", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5104/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23101/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23101/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D9E24C323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 2 Apr 2025 07:32:10 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CEF876897A;\n\tWed, 2 Apr 2025 09:32:09 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [198.175.65.17])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7FA6968979\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 2 Apr 2025 09:32:07 +0200 (CEST)", "from orviesa003.jf.intel.com ([10.64.159.143])\n\tby orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n\t02 Apr 2025 00:31:38 -0700", "from sgruszka-mobl.ger.corp.intel.com (HELO localhost)\n\t([10.246.8.237]) by ORVIESA003-auth.jf.intel.com with\n\tESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Apr 2025 00:31:35 -0700" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=intel.com header.i=@intel.com\n\theader.b=\"lgb3+U0E\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n\td=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n\tt=1743579128; x=1775115128;\n\th=from:to:cc:subject:date:message-id:mime-version:\n\tcontent-transfer-encoding;\n\tbh=eddFopoxjIrp9IByZCmAufpqoy9aH/Krce5CzNw/EBY=;\n\tb=lgb3+U0E5SPdzYKRDtKHcjf4pVonPofgNrva8oRVuZN0ECxhijlgsrMj\n\t2e/yEG9EYjgieppCOvyec1sy8dSDoXyJKnGaunWH/Vq77OrfczM5p/hX+\n\tek7jvUEmjglH4CfRvu442nAVtmNEUfIAdWdOY3fVpm52Ufnzy9h+1FcKP\n\tzUwg2ZX3hONV9hii0gDFDNdEgsLGBLg4fW/Pi5SaemRsp71VU823My1S4\n\t+TAGqFSgi+LRNBp39akcQLfFZFBbLAv4CSKDqPcSWoaFJxgKskAZy6lXg\n\twve6jn9r7p7W1vqgaFtTv24pVDCiUZ2gMPNXyuYecRy+M96DE2jCjqMxf A==;", "X-CSE-ConnectionGUID": [ "jGDRD+n6SGC+KOpRbL3Gaw==", "eW3TIL0iQ9ygvjFOFJuK0g==" ], "X-CSE-MsgGUID": [ "kpWkOmGpQJmcu0lfoAaWDA==", "bywYG8t9TIaim0qCc0ZFXA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6700,10204,11391\"; a=\"44938467\"", "E=Sophos;i=\"6.14,295,1736841600\"; d=\"scan'208\";a=\"44938467\"", "E=Sophos;i=\"6.14,295,1736841600\"; d=\"scan'208\";a=\"131481805\"" ], "X-ExtLoop1": "1", "From": "Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>, Hans de Goede <hdegoede@redhat.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tSakari Ailus <sakari.ailus@linux.intel.com>", "Subject": "[PATCH v3] ipa: simple: Initialize ccmEnabled to false", "Date": "Wed, 2 Apr 2025 09:31:33 +0200", "Message-Id": "<20250402073133.15710-1-stanislaw.gruszka@linux.intel.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "ccmEnabled variable is not initialized by default, which results in\nusage of CCM when the algorithm itself is not enabled and configured.\n\nThe bug manifests itself as seldom reproducible corrupted video stream.\nFix by initialize ccmEnabled member where it is declared.\n\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nFixes: ac3068655643 (\"libcamera: software_isp: Track whether CCM is enabled\")\nSigned-off-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>\n---\nv2 -> v3:\n - update changelog\nv1 -> v2:\n - initialize on declaration \n - fix spelling\n\n src/ipa/simple/ipa_context.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/simple/ipa_context.h b/src/ipa/simple/ipa_context.h\nindex 7dc2cd7ae828..51522720ab98 100644\n--- a/src/ipa/simple/ipa_context.h\n+++ b/src/ipa/simple/ipa_context.h\n@@ -91,7 +91,7 @@ struct IPAContext {\n \tIPAActiveState activeState;\n \tFCQueue<IPAFrameContext> frameContexts;\n \tControlInfoMap::Map ctrlMap;\n-\tbool ccmEnabled;\n+\tbool ccmEnabled = false;\n };\n \n } /* namespace ipa::soft */\n", "prefixes": [ "v3" ] }