Patch Detail
Show a patch.
GET /api/1.1/patches/23091/?format=api
{ "id": 23091, "url": "https://patchwork.libcamera.org/api/1.1/patches/23091/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23091/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250401123633.58887-5-stefan.klug@ideasonboard.com>", "date": "2025-04-01T12:36:12", "name": "[v2,4/5] test: ipa: libipa: histogram: Add tests for small inter quantile mean ranges", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "2de08011dc519d59440cf7f3e0ae46e8b993bfea", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23091/mbox/", "series": [ { "id": 5099, "url": "https://patchwork.libcamera.org/api/1.1/series/5099/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5099", "date": "2025-04-01T12:36:08", "name": "Fix histogram for some (corner) cases", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5099/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23091/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23091/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ED12EC3213\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 1 Apr 2025 12:36:51 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B1A3868992;\n\tTue, 1 Apr 2025 14:36:51 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E00526898F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 1 Apr 2025 14:36:50 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:14c7:4fcc:495b:719f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AF87D8DB;\n\tTue, 1 Apr 2025 14:34:58 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NVtYhmM6\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743510898;\n\tbh=ox6fwJY1Ya93M7EtZYsXdTbgTfh/Y5fhG4FI2/TW//E=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=NVtYhmM6f0l6CT1b/QQjglpZ11wNbnF+VPkU+udRfwhybL2P9coQEJ0B/1zoDS07k\n\tUtPxWJlo+RVzI0t/1SDGKFgRiG03wkq5wIcvEZSEnjo13ioNQ7CymD9UQurr4DblSD\n\tw6mQQue+OqGqhyzMR9q+FQtKT5T+0G+gjHrCLtug=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[PATCH v2 4/5] test: ipa: libipa: histogram: Add tests for small\n\tinter quantile mean ranges", "Date": "Tue, 1 Apr 2025 14:36:12 +0200", "Message-ID": "<20250401123633.58887-5-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20250401123633.58887-1-stefan.klug@ideasonboard.com>", "References": "<20250401123633.58887-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add tests for small inter quantile mean ranges. As these cases fail at\nthe moment, mark the test as should_fail.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n---\n\nChanges in v2:\n- Move test patch before fix\n- Add should_fail\n- Fix typo in comment\n---\n test/ipa/libipa/histogram.cpp | 4 ++++\n test/ipa/libipa/meson.build | 2 +-\n 2 files changed, 5 insertions(+), 1 deletion(-)", "diff": "diff --git a/test/ipa/libipa/histogram.cpp b/test/ipa/libipa/histogram.cpp\nindex 5ce84a61b7da..77ff31a6db0e 100644\n--- a/test/ipa/libipa/histogram.cpp\n+++ b/test/ipa/libipa/histogram.cpp\n@@ -55,6 +55,10 @@ protected:\n \t\t/* Test interquantile mean that starts and ends in the middle of a bin. */\n \t\tASSERT_EQ(hist.interQuantileMean(0.25, 0.75), 1.0);\n \n+\t\t/* Test small ranges at the borders of the histogram. */\n+\t\tASSERT_EQ(hist.interQuantileMean(0.0, 0.1), 0.1);\n+\t\tASSERT_EQ(hist.interQuantileMean(0.9, 1.0), 1.9);\n+\n \t\treturn TestPass;\n \t}\n };\ndiff --git a/test/ipa/libipa/meson.build b/test/ipa/libipa/meson.build\nindex 8c63ebd8e2f7..83c84bd8c227 100644\n--- a/test/ipa/libipa/meson.build\n+++ b/test/ipa/libipa/meson.build\n@@ -2,7 +2,7 @@\n \n libipa_test = [\n {'name': 'fixedpoint', 'sources': ['fixedpoint.cpp']},\n- {'name': 'histogram', 'sources': ['histogram.cpp']},\n+ {'name': 'histogram', 'sources': ['histogram.cpp'], 'should_fail': true},\n {'name': 'interpolator', 'sources': ['interpolator.cpp']},\n ]\n \n", "prefixes": [ "v2", "4/5" ] }