Patch Detail
Show a patch.
GET /api/1.1/patches/23085/?format=api
{ "id": 23085, "url": "https://patchwork.libcamera.org/api/1.1/patches/23085/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23085/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250331160301.534243-1-barnabas.pocze@ideasonboard.com>", "date": "2025-03-31T16:03:01", "name": "[v1] libcamera: base: bound_method: Simplify `invokePack()`", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "cfaae377b8815c6de3f5955a0096795018863f2a", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/1.1/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23085/mbox/", "series": [ { "id": 5097, "url": "https://patchwork.libcamera.org/api/1.1/series/5097/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5097", "date": "2025-03-31T16:03:01", "name": "[v1] libcamera: base: bound_method: Simplify `invokePack()`", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5097/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23085/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23085/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8E6F2C323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 31 Mar 2025 16:03:08 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 916F368981;\n\tMon, 31 Mar 2025 18:03:07 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D1AC868967\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 31 Mar 2025 18:03:05 +0200 (CEST)", "from pb-laptop.local (185.221.143.221.nat.pool.zt.hu\n\t[185.221.143.221])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2CD7F725\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 31 Mar 2025 18:01:14 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qEBC4qz9\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743436874;\n\tbh=qCR4xxZ9EEZMq8hcisMpPI3tIH0AeY/xwfM345wnlpw=;\n\th=From:To:Subject:Date:From;\n\tb=qEBC4qz9ozG5sqsHKyTYLkZyJPueaSAXngxE0cis8h0yuykOqOUMfMdTCC7p2L4WN\n\tAXDNJyytJnb+DN3uiRMq5XuP1/ZszLSa5CquQKurImW20n68tjXu7G6fkfZn9viAOg\n\tKj3FFZ18wwa388lB+ex+zFBvCNDa4mmziskxWa2c=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v1] libcamera: base: bound_method: Simplify `invokePack()`", "Date": "Mon, 31 Mar 2025 18:03:01 +0200", "Message-ID": "<20250331160301.534243-1-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.49.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Use `if constexpr` instead of SFINAE to handle return values of type `void`.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n include/libcamera/base/bound_method.h | 17 ++++++-----------\n 1 file changed, 6 insertions(+), 11 deletions(-)", "diff": "diff --git a/include/libcamera/base/bound_method.h b/include/libcamera/base/bound_method.h\nindex dd3488eeb..aad75c02a 100644\n--- a/include/libcamera/base/bound_method.h\n+++ b/include/libcamera/base/bound_method.h\n@@ -98,21 +98,16 @@ public:\n \tusing PackType = BoundMethodPack<R, Args...>;\n \n private:\n-\ttemplate<std::size_t... I, typename T = R>\n-\tstd::enable_if_t<!std::is_void<T>::value, void>\n+\ttemplate<std::size_t... I>\n+\tvoid\n \tinvokePack(BoundMethodPackBase *pack, std::index_sequence<I...>)\n \t{\n \t\tPackType *args = static_cast<PackType *>(pack);\n-\t\targs->ret_ = invoke(std::get<I>(args->args_)...);\n-\t}\n \n-\ttemplate<std::size_t... I, typename T = R>\n-\tstd::enable_if_t<std::is_void<T>::value, void>\n-\tinvokePack(BoundMethodPackBase *pack, std::index_sequence<I...>)\n-\t{\n-\t\t/* args is effectively unused when the sequence I is empty. */\n-\t\tPackType *args [[gnu::unused]] = static_cast<PackType *>(pack);\n-\t\tinvoke(std::get<I>(args->args_)...);\n+\t\tif constexpr (!std::is_void_v<R>)\n+\t\t\targs->ret_ = invoke(std::get<I>(args->args_)...);\n+\t\telse\n+\t\t\tinvoke(std::get<I>(args->args_)...);\n \t}\n \n public:\n", "prefixes": [ "v1" ] }