Patch Detail
Show a patch.
GET /api/1.1/patches/23079/?format=api
{ "id": 23079, "url": "https://patchwork.libcamera.org/api/1.1/patches/23079/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23079/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250331144352.736700-7-stefan.klug@ideasonboard.com>", "date": "2025-03-31T14:43:45", "name": "[6/9] pipeline: rkisp1: Add more info when parameter queue fails", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "97cc2a4c650a7c23548b3724d9edc98dc6faafe5", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23079/mbox/", "series": [ { "id": 5094, "url": "https://patchwork.libcamera.org/api/1.1/series/5094/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5094", "date": "2025-03-31T14:43:39", "name": "Wdr preparations", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5094/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23079/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23079/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 50BD6C3213\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 31 Mar 2025 14:44:16 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0973A68998;\n\tMon, 31 Mar 2025 16:44:16 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 264B66899B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 31 Mar 2025 16:44:13 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:823a:c275:e8b5:b937])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AAB59725;\n\tMon, 31 Mar 2025 16:42:21 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jeeXe3YW\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743432141;\n\tbh=lYuNkNCH6vyea7pEQmn5NUpNu54x/Je78ZJtcHRA8Ec=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=jeeXe3YWp8jivtkOxOfDBevlalCBrsFWkQ7yWCxYL0onDPB2ws3iVI96fCRR+QAze\n\t8Zhi0l8A2a63FPMvlKBqnP+CwbxcVTWjsQa2APA9FSQqUvy0JtPNcHKZLHi/D8ob3E\n\thPtRB7Utilx5W4fyNSIO6UiGfvZ5aN8CmNQfHSuw=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH 6/9] pipeline: rkisp1: Add more info when parameter queue\n\tfails", "Date": "Mon, 31 Mar 2025 16:43:45 +0200", "Message-ID": "<20250331144352.736700-7-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20250331144352.736700-1-stefan.klug@ideasonboard.com>", "References": "<20250331144352.736700-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When the rkisp1 driver of the running kernel supports less parameter\ntypes than the libcamera build and such a parameter is used, queuing of\nthe parameter buffer fails with -EINVAL. For the time being we have no\nway to query the kernel for supported parameter types at runtime. So at\nleast print a error message that points the user in that direction.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 10 +++++++++-\n 1 file changed, 9 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 52633fe3cb85..132ab40fdbf7 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -409,7 +409,15 @@ void RkISP1CameraData::paramsComputed(unsigned int frame, unsigned int bytesused\n \t\treturn;\n \n \tinfo->paramBuffer->_d()->metadata().planes()[0].bytesused = bytesused;\n-\tpipe->param_->queueBuffer(info->paramBuffer);\n+\n+\tint ret = pipe->param_->queueBuffer(info->paramBuffer);\n+\tif (ret < 0) {\n+\t\tLOG(RkISP1, Error) << \"Failed to queue parameter buffer. \"\n+\t\t\t\t << \"Maybe the kernel doesn't support the\"\n+\t\t\t\t << \" required parameter types.\";\n+\t\treturn;\n+\t}\n+\n \tpipe->stat_->queueBuffer(info->statBuffer);\n \n \tif (info->mainPathBuffer)\n", "prefixes": [ "6/9" ] }