Patch Detail
Show a patch.
GET /api/1.1/patches/23077/?format=api
{ "id": 23077, "url": "https://patchwork.libcamera.org/api/1.1/patches/23077/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23077/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250331144352.736700-5-stefan.klug@ideasonboard.com>", "date": "2025-03-31T14:43:43", "name": "[4/9] libipa: agc_mean_luminance: Add debug logging", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "01174f0b25c6f0702b3d18fd141801c1c8a99681", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23077/mbox/", "series": [ { "id": 5094, "url": "https://patchwork.libcamera.org/api/1.1/series/5094/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5094", "date": "2025-03-31T14:43:39", "name": "Wdr preparations", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5094/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23077/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23077/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4CBDFC3285\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 31 Mar 2025 14:44:10 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8A8D068994;\n\tMon, 31 Mar 2025 16:44:09 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8DF216898C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 31 Mar 2025 16:44:07 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:823a:c275:e8b5:b937])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1834D82A;\n\tMon, 31 Mar 2025 16:42:16 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BMaYDR4h\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743432136;\n\tbh=sliaAGDAHBBmZu0LD4vdtchTZW9x6MfOfWqIE/1Tpus=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=BMaYDR4hYBC1FodraD0j8UvtqLdrKkQyyIfkferwxknZ27wM+lHTcygei2m6UBArO\n\tLdmnUMu5KAwZfIn/luBgPR3MQAXBSh44pmBDqKyQFKOHgY8vSAiqKRgWSDv6bebjPZ\n\trfInHhfjr3KdcVkG8A2IuLtIxVVXDJ+AXoRs84+Q=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH 4/9] libipa: agc_mean_luminance: Add debug logging", "Date": "Mon, 31 Mar 2025 16:43:43 +0200", "Message-ID": "<20250331144352.736700-5-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20250331144352.736700-1-stefan.klug@ideasonboard.com>", "References": "<20250331144352.736700-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When debugging the AEGC it is important to know when the constraints\napply. As this is important information for anyone doing tuning file\noptimization, add it upstream.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n src/ipa/libipa/agc_mean_luminance.cpp | 8 ++++++--\n 1 file changed, 6 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/libipa/agc_mean_luminance.cpp b/src/ipa/libipa/agc_mean_luminance.cpp\nindex f617fde81101..9154f083a510 100644\n--- a/src/ipa/libipa/agc_mean_luminance.cpp\n+++ b/src/ipa/libipa/agc_mean_luminance.cpp\n@@ -468,12 +468,16 @@ double AgcMeanLuminance::constraintClampGain(uint32_t constraintModeIndex,\n \t\t\t\t hist.interQuantileMean(constraint.qLo, constraint.qHi);\n \n \t\tif (constraint.bound == AgcConstraint::Bound::Lower &&\n-\t\t newGain > gain)\n+\t\t newGain > gain) {\n \t\t\tgain = newGain;\n+\t\t\tLOG(AgcMeanLuminance, Debug) << \"Apply lower bound: \" << gain << \" to \" << newGain;\n+\t\t}\n \n \t\tif (constraint.bound == AgcConstraint::Bound::Upper &&\n-\t\t newGain < gain)\n+\t\t newGain < gain) {\n \t\t\tgain = newGain;\n+\t\t\tLOG(AgcMeanLuminance, Debug) << \"Apply upper bound: \" << gain << \" to \" << newGain;\n+\t\t}\n \t}\n \n \treturn gain;\n", "prefixes": [ "4/9" ] }