Patch Detail
Show a patch.
GET /api/1.1/patches/23051/?format=api
{ "id": 23051, "url": "https://patchwork.libcamera.org/api/1.1/patches/23051/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23051/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250326124856.75709-5-mzamazal@redhat.com>", "date": "2025-03-26T12:48:53", "name": "[v5,4/6] ipa: simple: Report black levels in metadata", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "cdde039703b9eacd49de5ec1d59cb507f3c98449", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/1.1/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23051/mbox/", "series": [ { "id": 5085, "url": "https://patchwork.libcamera.org/api/1.1/series/5085/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5085", "date": "2025-03-26T12:48:49", "name": "ipa: simple: Introduce metadata reporting", "version": 5, "mbox": "https://patchwork.libcamera.org/series/5085/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23051/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23051/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B3602C3213\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 26 Mar 2025 12:49:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3B9F768978;\n\tWed, 26 Mar 2025 13:49:17 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2D34668950\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 26 Mar 2025 13:49:13 +0100 (CET)", "from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-393-u-MePDNGMzu2NHCudEvz5Q-1;\n\tWed, 26 Mar 2025 08:49:10 -0400", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id D548E1800263; Wed, 26 Mar 2025 12:49:09 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.34.15])\n\tby mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 1B26E3001D0F; Wed, 26 Mar 2025 12:49:07 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"H6SS6N3X\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1742993352;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=r5h0yEOrHyUVK/p/2Lmy0vgyxjmWPIdOBVmgz9dQYx4=;\n\tb=H6SS6N3XNR0laAHx3+CZLLd7kpHu3WTnJK52GsDz6sr7aaWCTj9dorqDiUGqUiOmeygVgv\n\tM38JhU6Q4Zlyjq7Eu58vqx8w5AVlXhHmCf9nJ0DQQH0FlFNtUReq9IEYHnbjaTsOqQ6Rpm\n\tADkfknkKckUndRjdHg4qle96jmBrJsg=", "X-MC-Unique": "u-MePDNGMzu2NHCudEvz5Q-1", "X-Mimecast-MFC-AGG-ID": "u-MePDNGMzu2NHCudEvz5Q_1742993349", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Kieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tMilan Zamazal <mzamazal@redhat.com>", "Subject": "[PATCH v5 4/6] ipa: simple: Report black levels in metadata", "Date": "Wed, 26 Mar 2025 13:48:53 +0100", "Message-ID": "<20250326124856.75709-5-mzamazal@redhat.com>", "In-Reply-To": "<20250326124856.75709-1-mzamazal@redhat.com>", "References": "<20250326124856.75709-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "-xo6tCtNhDnhzurX3Eq7XF6JWtlByQvvPnofSFxG84U_1742993349", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nProvide the determined black level values in the metadata\nto add to the completed requests.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/simple/algorithms/blc.cpp | 11 ++++++++++-\n 1 file changed, 10 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/simple/algorithms/blc.cpp b/src/ipa/simple/algorithms/blc.cpp\nindex 1d7d370b..53c356c8 100644\n--- a/src/ipa/simple/algorithms/blc.cpp\n+++ b/src/ipa/simple/algorithms/blc.cpp\n@@ -11,6 +11,8 @@\n \n #include <libcamera/base/log.h>\n \n+#include \"control_ids.h\"\n+\n namespace libcamera {\n \n namespace ipa::soft::algorithms {\n@@ -49,8 +51,15 @@ void BlackLevel::process(IPAContext &context,\n \t\t\t [[maybe_unused]] const uint32_t frame,\n \t\t\t IPAFrameContext &frameContext,\n \t\t\t const SwIspStats *stats,\n-\t\t\t [[maybe_unused]] ControlList &metadata)\n+\t\t\t ControlList &metadata)\n {\n+\t/* Assign each of the R G G B channels as the same black level. */\n+\tconst int32_t blackLevel = context.activeState.blc.level * 256;\n+\tconst int32_t blackLevels[] = {\n+\t\tblackLevel, blackLevel, blackLevel, blackLevel\n+\t};\n+\tmetadata.set(controls::SensorBlackLevels, blackLevels);\n+\n \tif (context.configuration.black.level.has_value())\n \t\treturn;\n \n", "prefixes": [ "v5", "4/6" ] }