Patch Detail
Show a patch.
GET /api/1.1/patches/23014/?format=api
{ "id": 23014, "url": "https://patchwork.libcamera.org/api/1.1/patches/23014/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23014/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250325180821.1456154-2-barnabas.pocze@ideasonboard.com>", "date": "2025-03-25T18:08:13", "name": "[RFC,v3,1/9] libcamera: process: Disable copy/move", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "dec1bac03e17ef752c50001ef0e027fe29fe26f6", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/1.1/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23014/mbox/", "series": [ { "id": 5079, "url": "https://patchwork.libcamera.org/api/1.1/series/5079/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5079", "date": "2025-03-25T18:08:12", "name": "libcamera: process: Remove `ProcessManager` singleton", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5079/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23014/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23014/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3DB99C3285\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 25 Mar 2025 18:08:48 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6A40568951;\n\tTue, 25 Mar 2025 19:08:46 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CE3F8600EB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 25 Mar 2025 19:08:42 +0100 (CET)", "from pb-laptop.local (185.221.143.221.nat.pool.zt.hu\n\t[185.221.143.221])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6E71682E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 25 Mar 2025 19:06:55 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fN++1HPP\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742926015;\n\tbh=QzqIb/GAXETZPl/ruc6Jqo8QLVvsFIYIbyejuIVMaYQ=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=fN++1HPPfUHpH+tSIkgCFM3IJ2puhds1PK4oAnHQKOrxhGmCzqe34ZJshHBi0jF8+\n\tjvdwTK6dmYNbNWnTvY2LCTCXuIiYyEmNDZTdIYfECTKYcfikPPBvMMM/THyHmJoOBW\n\tOX4bwTECvls9XXXGu10uLKD1D8dOReC5RCHdAl5A=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[RFC PATCH v3 1/9] libcamera: process: Disable copy/move", "Date": "Tue, 25 Mar 2025 19:08:13 +0100", "Message-ID": "<20250325180821.1456154-2-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.49.0", "In-Reply-To": "<20250325180821.1456154-1-barnabas.pocze@ideasonboard.com>", "References": "<20250325180821.1456154-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "A `Process` object has address identity because a pointer\nto it is stored inside the `ProcessManager`. However, copy/move\nspecial methods are still generated by the compiler. So disable\nthem to avoid potential issues and confusion.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n include/libcamera/internal/process.h | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/include/libcamera/internal/process.h b/include/libcamera/internal/process.h\nindex b1d07a5a5..58e3e41ce 100644\n--- a/include/libcamera/internal/process.h\n+++ b/include/libcamera/internal/process.h\n@@ -42,6 +42,8 @@ public:\n \tSignal<enum ExitStatus, int> finished;\n \n private:\n+\tLIBCAMERA_DISABLE_COPY_AND_MOVE(Process)\n+\n \tvoid closeAllFdsExcept(const std::vector<int> &fds);\n \tint isolate();\n \tvoid died(int wstatus);\n", "prefixes": [ "RFC", "v3", "1/9" ] }