Patch Detail
Show a patch.
GET /api/1.1/patches/22998/?format=api
{ "id": 22998, "url": "https://patchwork.libcamera.org/api/1.1/patches/22998/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22998/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250320162624.121616-1-mzamazal@redhat.com>", "date": "2025-03-20T16:26:24", "name": "libcamera: software_isp: Assign colour spaces in configurations", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "4a7a09a9dd8785f61c02ffdd7e9db0c680662cd9", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/1.1/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22998/mbox/", "series": [ { "id": 5074, "url": "https://patchwork.libcamera.org/api/1.1/series/5074/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5074", "date": "2025-03-20T16:26:24", "name": "libcamera: software_isp: Assign colour spaces in configurations", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5074/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22998/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22998/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 59E6BC3301\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 20 Mar 2025 16:26:35 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9F9FD68950;\n\tThu, 20 Mar 2025 17:26:34 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9C7A8617F5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 20 Mar 2025 17:26:33 +0100 (CET)", "from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-156-BpFgKEyhOQutb6j5efG9YQ-1;\n\tThu, 20 Mar 2025 12:26:31 -0400", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.111])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id A2E6B18EBE88; Thu, 20 Mar 2025 16:26:29 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.32.102])\n\tby mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 4CBDE1800268; Thu, 20 Mar 2025 16:26:27 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"b2PeFW1h\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1742487992;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding;\n\tbh=gwSQdjqtGsaCNHNGxyNFn9Hapep9X9HyaHxlD6dLulI=;\n\tb=b2PeFW1hBCI+L7qqXVyxsdAOEFCSNSzVlUaj/jDJn6GhztY4kOyB9DXUYB2OtSFAilP1A5\n\t59ljHfz8yTXJLsScj4FowR6+aRTfVb+Oiq2A8bXGR4inotHi8xUJSBnNdjLSr0Ei8Ryoqb\n\ttu26yNWFA8MeV+no1hfeRWjHdkxoH2c=", "X-MC-Unique": "BpFgKEyhOQutb6j5efG9YQ-1", "X-Mimecast-MFC-AGG-ID": "BpFgKEyhOQutb6j5efG9YQ_1742487989", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH] libcamera: software_isp: Assign colour spaces in\n\tconfigurations", "Date": "Thu, 20 Mar 2025 17:26:24 +0100", "Message-ID": "<20250320162624.121616-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "R31KWewRMmi1xQWME315EDdmct7mXAZ8sdbMGjLA5dk_1742487989", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "StreamConfiguration's should have colorSpace set. This is not the case\nin the simple pipeline. Let's set it there, basically mimicking what\nrpi and rkisp1 pipelines do (having a common helper may be a\nconsideration).\n\nThis also fixes a crash in `cam' due to accessing an unset colorSpace.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/libcamera/pipeline/simple/simple.cpp | 16 +++++++++++++++-\n 1 file changed, 15 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 6e039bf3..62db96ca 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -25,6 +25,7 @@\n #include <libcamera/base/log.h>\n \n #include <libcamera/camera.h>\n+#include <libcamera/color_space.h>\n #include <libcamera/control_ids.h>\n #include <libcamera/request.h>\n #include <libcamera/stream.h>\n@@ -1196,11 +1197,24 @@ SimplePipelineHandler::generateConfiguration(Camera *camera, Span<const StreamRo\n \t *\n \t * \\todo Implement a better way to pick the default format\n \t */\n-\tfor ([[maybe_unused]] StreamRole role : roles) {\n+\tfor (StreamRole role : roles) {\n \t\tStreamConfiguration cfg{ StreamFormats{ formats } };\n \t\tcfg.pixelFormat = formats.begin()->first;\n \t\tcfg.size = formats.begin()->second[0].max;\n \n+\t\tswitch (role) {\n+\t\tcase StreamRole::Raw:\n+\t\t\tcfg.colorSpace = ColorSpace::Raw;\n+\t\t\tbreak;\n+\t\tcase StreamRole::StillCapture:\n+\t\tcase StreamRole::Viewfinder:\n+\t\t\tcfg.colorSpace = ColorSpace::Sycc;\n+\t\t\tbreak;\n+\t\tcase StreamRole::VideoRecording:\n+\t\t\tcfg.colorSpace = ColorSpace::Rec709;\n+\t\t\tbreak;\n+\t\t}\n+\n \t\tconfig->addConfiguration(cfg);\n \t}\n \n", "prefixes": [] }