Patch Detail
Show a patch.
GET /api/1.1/patches/22995/?format=api
{ "id": 22995, "url": "https://patchwork.libcamera.org/api/1.1/patches/22995/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22995/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250319161152.63625-18-stefan.klug@ideasonboard.com>", "date": "2025-03-19T16:11:22", "name": "[v2,17/17] ipa: rkisp1: awb: Avoid division by zero", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "ce34306809ab0fa6a84215924007d5ffcb30cc15", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22995/mbox/", "series": [ { "id": 5071, "url": "https://patchwork.libcamera.org/api/1.1/series/5071/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5071", "date": "2025-03-19T16:11:05", "name": "Some rkisp1 awb improvements", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5071/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22995/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22995/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8FE72C32FE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 19 Mar 2025 16:12:49 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4D2A968967;\n\tWed, 19 Mar 2025 17:12:49 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6BAEC68967\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 19 Mar 2025 17:12:47 +0100 (CET)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:760:e5ca:4814:99c7])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 840408FA;\n\tWed, 19 Mar 2025 17:11:04 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JQ+bZB6q\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742400664;\n\tbh=NKZRysVlMDp+4JBntlGKrY42fUrM7otHIIeC2HGtXyc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=JQ+bZB6qAlIX9lsMjjg36YoJpDnny6MTF7SAiaJE0VHS+XwE/QVaM2nxvnGJIPrxu\n\tYu51q6runL0pQXQvOwUVNcEgVO7CR05CWGNccKuOAq3UyJAediHlUt5VhOoVqZm0Qi\n\t+QqlN9UJmJPXqe75o2QI1RCn+7PUaxRBYYJgStVQ=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v2 17/17] ipa: rkisp1: awb: Avoid division by zero", "Date": "Wed, 19 Mar 2025 17:11:22 +0100", "Message-ID": "<20250319161152.63625-18-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20250319161152.63625-1-stefan.klug@ideasonboard.com>", "References": "<20250319161152.63625-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "As the gains can also be specified manually, the regulation can run into\nnumeric instabilities by dividing by near zero. Mitigate that by\napplying a small minium value.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n---\n\nChanges in v2:\n- Collected tag\n---\n src/ipa/rkisp1/algorithms/awb.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\nindex e8b04d03748d..eb4545439ae3 100644\n--- a/src/ipa/rkisp1/algorithms/awb.cpp\n+++ b/src/ipa/rkisp1/algorithms/awb.cpp\n@@ -421,9 +421,9 @@ RGB<double> Awb::calculateRgbMeans(const IPAFrameContext &frameContext, const rk\n \t/*\n \t * The ISP computes the AWB means after applying the colour gains,\n \t * divide by the gains that were used to get the raw means from the\n-\t * sensor.\n+\t * sensor. Apply a minimum value to avoid divisions by near-zero.\n \t */\n-\trgbMeans /= frameContext.awb.gains;\n+\trgbMeans /= frameContext.awb.gains.max(0.01);\n \n \treturn rgbMeans;\n }\n", "prefixes": [ "v2", "17/17" ] }