Patch Detail
Show a patch.
GET /api/1.1/patches/2298/?format=api
{ "id": 2298, "url": "https://patchwork.libcamera.org/api/1.1/patches/2298/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2298/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20191108205409.18845-3-laurent.pinchart@ideasonboard.com>", "date": "2019-11-08T20:53:47", "name": "[libcamera-devel,v2,02/24] test: controls: Add ControlInfoMap test", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "3c36a66393b0f1051a40901f40125251207e7226", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2298/mbox/", "series": [ { "id": 568, "url": "https://patchwork.libcamera.org/api/1.1/series/568/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=568", "date": "2019-11-08T20:53:45", "name": "Control serialization and IPA C API", "version": 2, "mbox": "https://patchwork.libcamera.org/series/568/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2298/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2298/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 35BAC6150A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 8 Nov 2019 21:54:23 +0100 (CET)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C8C792D1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 8 Nov 2019 21:54:22 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1573246462;\n\tbh=aVv4tmUKK5hzM121JHAcTAX/nWTzokiWDabNINf7hpY=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=ZlWXPOsc4VsgUaxcKt5EfRghz3fsuqdSKq84Z6QgdnvzL8xdZXCAD7ae9kMWbaY22\n\tro80uooDXH67rTHUhSB55KLv/VDTCUjcwVoaZG5szyCZNPzJlC3XTUsLZuNtN04+c2\n\tFFK9Xfb7YpnOdLwH7GQxXmfpSLIeTRx3nMAqaqm4=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 8 Nov 2019 22:53:47 +0200", "Message-Id": "<20191108205409.18845-3-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.23.0", "In-Reply-To": "<20191108205409.18845-1-laurent.pinchart@ideasonboard.com>", "References": "<20191108205409.18845-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 02/24] test: controls: Add\n\tControlInfoMap test", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 08 Nov 2019 20:54:23 -0000" }, "content": "Add a test to exercise the ControlInfoMap API. This currently tests\nat(), count(), find() and end().\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n test/controls/control_info.cpp | 77 ++++++++++++++++++++++++++++++++++\n test/controls/meson.build | 1 +\n 2 files changed, 78 insertions(+)\n create mode 100644 test/controls/control_info.cpp", "diff": "diff --git a/test/controls/control_info.cpp b/test/controls/control_info.cpp\nnew file mode 100644\nindex 000000000000..c2678ea3e593\n--- /dev/null\n+++ b/test/controls/control_info.cpp\n@@ -0,0 +1,77 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2019, Google Inc.\n+ *\n+ * control_info.cpp - ControlInfoMap tests\n+ */\n+\n+#include <iostream>\n+\n+#include <libcamera/camera.h>\n+#include <libcamera/camera_manager.h>\n+#include <libcamera/control_ids.h>\n+#include <libcamera/controls.h>\n+\n+#include \"camera_controls.h\"\n+\n+#include \"camera_test.h\"\n+#include \"test.h\"\n+\n+using namespace std;\n+using namespace libcamera;\n+\n+class ControlInfoMapTest : public CameraTest, public Test\n+{\n+public:\n+\tControlInfoMapTest()\n+\t\t: CameraTest(\"VIMC Sensor B\")\n+\t{\n+\t}\n+\n+protected:\n+\tint run()\n+\t{\n+\t\tconst ControlInfoMap &info = camera_->controls();\n+\n+\t\t/* Test looking up a valid control by ControlId. */\n+\t\tif (info.count(&controls::Brightness) != 1) {\n+\t\t\tcout << \"count() on valid control failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (info.find(&controls::Brightness) == info.end()) {\n+\t\t\tcout << \"find() on valid control failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tinfo.at(&controls::Brightness);\n+\n+\t\t/* Test looking up a valid control by numerical ID. */\n+\t\tif (info.count(controls::Brightness.id()) != 1) {\n+\t\t\tcout << \"count() on valid ID failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (info.find(controls::Brightness.id()) == info.end()) {\n+\t\t\tcout << \"find() on valid ID failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tinfo.at(controls::Brightness.id());\n+\n+\t\t/* Test looking up an invalid control by numerical ID. */\n+\t\tif (info.count(12345) != 0) {\n+\t\t\tcout << \"count() on invalid ID failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\tif (info.find(12345) != info.end()) {\n+\t\t\tcout << \"find() on invalid ID failed\" << endl;\n+\t\t\treturn TestFail;\n+\t\t}\n+\n+\t\treturn TestPass;\n+\t}\n+};\n+\n+TEST_REGISTER(ControlInfoMapTest)\ndiff --git a/test/controls/meson.build b/test/controls/meson.build\nindex 9f0f005a2759..f0850df28c8a 100644\n--- a/test/controls/meson.build\n+++ b/test/controls/meson.build\n@@ -1,4 +1,5 @@\n control_tests = [\n+ [ 'control_info', 'control_info.cpp' ],\n [ 'control_list', 'control_list.cpp' ],\n [ 'control_range', 'control_range.cpp' ],\n [ 'control_value', 'control_value.cpp' ],\n", "prefixes": [ "libcamera-devel", "v2", "02/24" ] }