Patch Detail
Show a patch.
GET /api/1.1/patches/22971/?format=api
{ "id": 22971, "url": "https://patchwork.libcamera.org/api/1.1/patches/22971/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22971/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250317181141.214118-1-barnabas.pocze@ideasonboard.com>", "date": "2025-03-17T18:11:41", "name": "[v1] apps: cam: Highlight default enumerator", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f245c25876063acc337362cfc24040f03eaf1586", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/1.1/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22971/mbox/", "series": [ { "id": 5066, "url": "https://patchwork.libcamera.org/api/1.1/series/5066/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5066", "date": "2025-03-17T18:11:41", "name": "[v1] apps: cam: Highlight default enumerator", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5066/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22971/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22971/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 17D07C32F5\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 17 Mar 2025 18:11:46 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D69F06894D;\n\tMon, 17 Mar 2025 19:11:45 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9325D68928\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 17 Mar 2025 19:11:44 +0100 (CET)", "from pb-laptop.local (185.221.143.221.nat.pool.zt.hu\n\t[185.221.143.221])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0F0A9D77\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 17 Mar 2025 19:10:03 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WhTIzT/v\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1742235003;\n\tbh=KkRZ6MY9keo+fGJuAC/kdemJ341+pkcsrJKr0N0Sfq0=;\n\th=From:To:Subject:Date:From;\n\tb=WhTIzT/veq6nWVbXjAhHRYM38dBUL11N39gL7Rv4wae9C9Idvc/Kwf2uqog/cH0yu\n\tktCvenBPA88mTQ07O//2qG3wgubpG2p58Fcxf/kYBaMlzZokjxwaeSfzDEg8CWYxg1\n\txCpMmBKSTpHFM8XHi7ry5jPxUhAPfBEI16k8VjHY=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v1] apps: cam: Highlight default enumerator", "Date": "Mon, 17 Mar 2025 19:11:41 +0100", "Message-ID": "<20250317181141.214118-1-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.49.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Print \"[default]\" after the default enumerator when listing controls.\n\nExample:\n\n $ cam -c 1 --list-controls\n [...]\n Control: [inout] libcamera::ExposureTimeMode:\n - ExposureTimeModeAuto (0) [default]\n - ExposureTimeModeManual (1)\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/apps/cam/camera_session.cpp | 11 ++++++++++-\n 1 file changed, 10 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/apps/cam/camera_session.cpp b/src/apps/cam/camera_session.cpp\nindex 9e9348277..8a555339c 100644\n--- a/src/apps/cam/camera_session.cpp\n+++ b/src/apps/cam/camera_session.cpp\n@@ -8,6 +8,7 @@\n #include <iomanip>\n #include <iostream>\n #include <limits.h>\n+#include <optional>\n #include <sstream>\n \n #include <libcamera/control_ids.h>\n@@ -173,6 +174,11 @@ void CameraSession::listControls() const\n \t\t\tstd::cout << \"Control: \" << io.str()\n \t\t\t\t << id->vendor() << \"::\" << id->name() << \":\"\n \t\t\t\t << std::endl;\n+\n+\t\t\tstd::optional<int32_t> def;\n+\t\t\tif (!info.def().isNone())\n+\t\t\t\tdef = info.def().get<int32_t>();\n+\n \t\t\tfor (const auto &value : info.values()) {\n \t\t\t\tint32_t val = value.get<int32_t>();\n \t\t\t\tconst auto &it = id->enumerators().find(val);\n@@ -182,7 +188,10 @@ void CameraSession::listControls() const\n \t\t\t\t\tstd::cout << \"UNKNOWN\";\n \t\t\t\telse\n \t\t\t\t\tstd::cout << it->second;\n-\t\t\t\tstd::cout << \" (\" << val << \")\" << std::endl;\n+\n+\t\t\t\tstd::cout << \" (\" << val << \")\"\n+\t\t\t\t\t << (val == def ? \" [default]\" : \"\")\n+\t\t\t\t\t << std::endl;\n \t\t\t}\n \t\t}\n \n", "prefixes": [ "v1" ] }