Patch Detail
Show a patch.
GET /api/1.1/patches/22968/?format=api
{ "id": 22968, "url": "https://patchwork.libcamera.org/api/1.1/patches/22968/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22968/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250317112658.15084-1-mzamazal@redhat.com>", "date": "2025-03-17T11:26:58", "name": "libcamera: software_isp: Reset stored exposure in black level", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "4d749c37acf2d816570167f0552917a238b3ebb9", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/1.1/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22968/mbox/", "series": [ { "id": 5063, "url": "https://patchwork.libcamera.org/api/1.1/series/5063/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5063", "date": "2025-03-17T11:26:58", "name": "libcamera: software_isp: Reset stored exposure in black level", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5063/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22968/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22968/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 586AEC32F5\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 17 Mar 2025 11:27:09 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 11D6368947;\n\tMon, 17 Mar 2025 12:27:08 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 16F84617F8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 17 Mar 2025 12:27:06 +0100 (CET)", "from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-138-8F6wEeeAPoulBNJssAjiMw-1;\n\tMon, 17 Mar 2025 07:27:04 -0400", "from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.15])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 2FE26180AF59; Mon, 17 Mar 2025 11:27:03 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.32.88])\n\tby mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id BD29E1956095; Mon, 17 Mar 2025 11:27:01 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"bEt9po+S\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1742210825;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding;\n\tbh=MXn+hW63M4UHNrMqg4WXkr+15ZXSB4UaGwFE6PwlUUY=;\n\tb=bEt9po+SEwnkbyBeKZx84GnEMlPJCVoJD1ZK/jyAE8iGdOE0RCyz0IEe/IAFEox3o+sWag\n\tfLUnt7zbvsQASKQC2Bj/Ec78Y3s7iXa0K3MBeCroTWf3xMPQzvJkfu+5l33W0op3W8Sl8A\n\tCZFe8J2Iiq6EV/JYnbGdKhO2GLBQQI4=", "X-MC-Unique": "8F6wEeeAPoulBNJssAjiMw-1", "X-Mimecast-MFC-AGG-ID": "8F6wEeeAPoulBNJssAjiMw_1742210823", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tRobert Mader <robert.mader@collabora.com>", "Subject": "[PATCH] libcamera: software_isp: Reset stored exposure in black\n\tlevel", "Date": "Mon, 17 Mar 2025 12:26:58 +0100", "Message-ID": "<20250317112658.15084-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.15", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "k0rd7gg2A5YKNHVQholfkM-nYJJehS5RpyQfYq_oTO8_1742210823", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Automatic black level setting in software ISP updates the determined\nblack level value when exposure or gain change. It stores the last\nexposure and gain values to detect the change.\n\nBlackLevel::configure() resets the stored black level value but not the\nexposure and gain values. This can prevent updating the black value and\ncause bad image output e.g. after suspending and resuming a camera, if\nexposure and gain remain unchanged.\n\nLet's reset the stored exposure and gain values in\nBlackLevel::configure() to fix the problem.\n\nBug: https://bugs.libcamera.org/show_bug.cgi?id=259\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/ipa/simple/algorithms/blc.cpp | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/simple/algorithms/blc.cpp b/src/ipa/simple/algorithms/blc.cpp\nindex 1d7d370b..14cf31bf 100644\n--- a/src/ipa/simple/algorithms/blc.cpp\n+++ b/src/ipa/simple/algorithms/blc.cpp\n@@ -1,6 +1,6 @@\n /* SPDX-License-Identifier: LGPL-2.1-or-later */\n /*\n- * Copyright (C) 2024, Red Hat Inc.\n+ * Copyright (C) 2024-2025, Red Hat Inc.\n *\n * Black level handling\n */\n@@ -38,6 +38,9 @@ int BlackLevel::init([[maybe_unused]] IPAContext &context,\n int BlackLevel::configure(IPAContext &context,\n \t\t\t [[maybe_unused]] const IPAConfigInfo &configInfo)\n {\n+\texposure_ = 0;\n+\tgain_ = 0;\n+\n \tif (definedLevel_.has_value())\n \t\tcontext.configuration.black.level = definedLevel_;\n \tcontext.activeState.blc.level =\n", "prefixes": [] }