Patch Detail
Show a patch.
GET /api/1.1/patches/22934/?format=api
{ "id": 22934, "url": "https://patchwork.libcamera.org/api/1.1/patches/22934/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22934/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250305192617.18361-5-mzamazal@redhat.com>", "date": "2025-03-05T19:26:11", "name": "[v3,4/8] libcamera: simple: Identify requested stream roles", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "a8520e63c8a8adabeeecedec9e1ee6f4d13f0998", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/1.1/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22934/mbox/", "series": [ { "id": 5047, "url": "https://patchwork.libcamera.org/api/1.1/series/5047/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5047", "date": "2025-03-05T19:26:07", "name": "Enable raw streams with software ISP", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5047/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22934/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22934/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 26474C0F1B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 5 Mar 2025 19:26:45 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0BEEE6884F;\n\tWed, 5 Mar 2025 20:26:44 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B5E26687F0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 5 Mar 2025 20:26:40 +0100 (CET)", "from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-581-5HJDmbHLNPy1BWB0Bo1x_w-1;\n\tWed, 05 Mar 2025 14:26:36 -0500", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.111])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 55F521956053; Wed, 5 Mar 2025 19:26:35 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.32.87])\n\tby mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id D5752180049D; Wed, 5 Mar 2025 19:26:33 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"EfiGMSO8\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1741202799;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=Rrm9felxLn7sVT95Ltk4Vfnef0t/fVQ0OcXe6eQ8wAM=;\n\tb=EfiGMSO8/KINIlvVos5d7JQFwtM4fcy4SxcM7dEVvrtUAeusXGGLzeCibKY/djp1W+9Rh8\n\tWkbMXDpAYQfrNuuBBhvmDW2tIV56yLD6UoNPcrNK2sEQSjHJBlCF9ItoHgavGb+nZ38TUW\n\tKDWmKJeLCsh/WNRAIJmVy3TYfsreTPY=", "X-MC-Unique": "5HJDmbHLNPy1BWB0Bo1x_w-1", "X-Mimecast-MFC-AGG-ID": "5HJDmbHLNPy1BWB0Bo1x_w_1741202795", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[PATCH v3 4/8] libcamera: simple: Identify requested stream roles", "Date": "Wed, 5 Mar 2025 20:26:11 +0100", "Message-ID": "<20250305192617.18361-5-mzamazal@redhat.com>", "In-Reply-To": "<20250305192617.18361-1-mzamazal@redhat.com>", "References": "<20250305192617.18361-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "IZlbxNTElwki3l1kcm6qolY1gHqDjNjH1hl5pAtycIM_1741202795", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Currently, raw streams don't work in the simple pipeline and the\nrequested stream roles are ignored. In order to support raw streams, we\nnow track in SimpleCameraData whether raw and/or processed streams are\nrequested. We also check that at most one raw stream is requested,\nthere is no reason to have more.\n\nThat information will be used in the followup patches.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/libcamera/pipeline/simple/simple.cpp | 16 ++++++++++++++++\n 1 file changed, 16 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex c805639c..0c6e0f44 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -298,6 +298,8 @@ public:\n \t};\n \tstd::queue<RequestOutputs> conversionQueue_;\n \tbool useConversion_;\n+\tbool processedRequested_;\n+\tbool rawRequested_;\n \n \tstd::unique_ptr<Converter> converter_;\n \tstd::unique_ptr<SoftwareIsp> swIsp_;\n@@ -1175,6 +1177,20 @@ SimplePipelineHandler::generateConfiguration(Camera *camera, Span<const StreamRo\n \tif (roles.empty())\n \t\treturn config;\n \n+\tdata->processedRequested_ = false;\n+\tdata->rawRequested_ = false;\n+\tfor (auto &role : roles)\n+\t\tif (role == StreamRole::Raw) {\n+\t\t\tif (data->rawRequested_) {\n+\t\t\t\tLOG(SimplePipeline, Error)\n+\t\t\t\t\t<< \"Can't capture multiple raw streams\";\n+\t\t\t\treturn nullptr;\n+\t\t\t}\n+\t\t\tdata->rawRequested_ = true;\n+\t\t} else {\n+\t\t\tdata->processedRequested_ = true;\n+\t\t}\n+\n \t/* Create the formats map. */\n \tstd::map<PixelFormat, std::vector<SizeRange>> formats;\n \n", "prefixes": [ "v3", "4/8" ] }