Patch Detail
Show a patch.
GET /api/1.1/patches/22932/?format=api
{ "id": 22932, "url": "https://patchwork.libcamera.org/api/1.1/patches/22932/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22932/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250305192617.18361-2-mzamazal@redhat.com>", "date": "2025-03-05T19:26:08", "name": "[v3,1/8] libcamera: simple: Set the number of software ISP streams to 2", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "c31356c0b36bdf0e7b2070d7ea0206697b70710a", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/1.1/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22932/mbox/", "series": [ { "id": 5047, "url": "https://patchwork.libcamera.org/api/1.1/series/5047/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5047", "date": "2025-03-05T19:26:07", "name": "Enable raw streams with software ISP", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5047/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22932/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22932/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3BFA0C0F1B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 5 Mar 2025 19:26:39 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E78F568823;\n\tWed, 5 Mar 2025 20:26:38 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B6311687DD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 5 Mar 2025 20:26:37 +0100 (CET)", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-661-PSl-49W7OeyS_ovUNbJUlQ-1;\n\tWed, 05 Mar 2025 14:26:30 -0500", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.111])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 554331800DB3; Wed, 5 Mar 2025 19:26:29 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.32.87])\n\tby mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id BE861180049D; Wed, 5 Mar 2025 19:26:27 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"SowhJ3p3\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1741202796;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=BkpqGcdaYYpxTu+vGuccbFgeqK+eZ4P+mUghp1l1Br0=;\n\tb=SowhJ3p3fRQWXr9tG2D3yAUH/7P2kn67g5oiw/9DxqUiSMZTz06W6JUQ4ei0zN1xdUpoqZ\n\t/IHGber9/JJG0hig2zUShKLK2Gg2tnZWgHLOaB4ly/erv7GXVwLqdF1Le1u45HdW+e8uaf\n\t8nEjCULW4+P9Mlk04Htx5d+2HYSkBhM=", "X-MC-Unique": "PSl-49W7OeyS_ovUNbJUlQ-1", "X-Mimecast-MFC-AGG-ID": "PSl-49W7OeyS_ovUNbJUlQ_1741202789", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[PATCH v3 1/8] libcamera: simple: Set the number of software ISP\n\tstreams to 2", "Date": "Wed, 5 Mar 2025 20:26:08 +0100", "Message-ID": "<20250305192617.18361-2-mzamazal@redhat.com>", "In-Reply-To": "<20250305192617.18361-1-mzamazal@redhat.com>", "References": "<20250305192617.18361-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "Upb0gTixabdyYyZGGr9bmDCKEDzxuJtMkBnpXZD6Fpc_1741202789", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When software ISP is enabled, we want to be able to provide a raw stream\nin addition to the processed stream. For this purpose, we need two\nstreams. If only the processed stream is requested, it doesn't harm to\nallocate two.\n\nThis is a hack for the lack of a better easy option. The number of\nstreams is determined as a camera property in the pipeline matching.\nThe actual number of streams needed (one or two) is determined only when\nexamining roles in SimplePipelineHandler::generateConfiguration.\n\nIn theory, software ISP could produce multiple processed streams but\nthis is out of scope of this patch series. Hence two streams are\nsufficient at the moment.\n\nWhen software ISP is not enabled, the camera won't be able to produce\nmultiple streams (assuming there's no hardware converter) and only\nsingle stream should be allocated as before. The simple pipeline\nhandler assumes there's a linear pipeline from the camera sensor to a\nvideo capture device, and only supports a single stream. Branches in\nthe hardware pipeline that would allow capturing multiple streams from\nthe same camera sensor are not supported. We have no plan to change\nthat, as a device that can produce multiple streams will likely be\nbetter supported by a dedicated pipeline handler.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/libcamera/pipeline/simple/simple.cpp | 11 ++++++++++-\n 1 file changed, 10 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 6e039bf3..ab3a68ff 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -1559,7 +1559,16 @@ bool SimplePipelineHandler::match(DeviceEnumerator *enumerator)\n \t\t}\n \t}\n \n-\tswIspEnabled_ = info->swIspEnabled;\n+\tif (info->swIspEnabled) {\n+\t\t/*\n+\t\t * When the software ISP is enabled, the simple pipeline handler\n+\t\t * exposes the raw stream, giving a total of two streams. This\n+\t\t * is mutally exclusive with the presence of a converter.\n+\t\t */\n+\t\tASSERT(!converter_);\n+\t\tnumStreams = 2;\n+\t\tswIspEnabled_ = true;\n+\t}\n \n \t/* Locate the sensors. */\n \tstd::vector<MediaEntity *> sensors = locateSensors(media);\n", "prefixes": [ "v3", "1/8" ] }