Patch Detail
Show a patch.
GET /api/1.1/patches/2293/?format=api
{ "id": 2293, "url": "https://patchwork.libcamera.org/api/1.1/patches/2293/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2293/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20191104170805.20647-2-laurent.pinchart@ideasonboard.com>", "date": "2019-11-04T17:08:05", "name": "[libcamera-devel,2/2] libcamera: Remove space between empty curly brackets", "commit_ref": "918bfb3c3dbaecb2df10fb24da9c68737f4948c1", "pull_url": null, "state": "accepted", "archived": false, "hash": "58815c6fb801933ccc0192aa4ec3e258412521a6", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2293/mbox/", "series": [ { "id": 565, "url": "https://patchwork.libcamera.org/api/1.1/series/565/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=565", "date": "2019-11-04T17:08:04", "name": "[libcamera-devel,1/2] libcamera: Remove unneeded semicolons", "version": 1, "mbox": "https://patchwork.libcamera.org/series/565/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2293/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2293/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 110B861374\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 4 Nov 2019 18:08:21 +0100 (CET)", "from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8DF69A3B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 4 Nov 2019 18:08:20 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1572887300;\n\tbh=09r4WI+WSC0HcD5xFhuJOckJjzQDUlKKXCweu/b1e2U=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=WZB3QfEoQN9hkunkvDDbz4z10DWyRPnHQCzHtJ+INkFdyt2kC0jIKSI6Si+GTwhR/\n\tQSpzlCry6x3yUqu4gTdpoS+5CFqz9gBuLGHZA30ldUwllPO6mLyTuNGzk7XhJRZYqR\n\tGLUd53RjFYwp02RBOW4eL+BA4oGP6CB9O65uf42A=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 4 Nov 2019 19:08:05 +0200", "Message-Id": "<20191104170805.20647-2-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.23.0", "In-Reply-To": "<20191104170805.20647-1-laurent.pinchart@ideasonboard.com>", "References": "<20191104170805.20647-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 2/2] libcamera: Remove space between empty\n\tcurly brackets", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 04 Nov 2019 17:08:21 -0000" }, "content": "Remove spaces between empty curly brackets (replacing { } with {}) to\ncomply with the coding style. Fix one other coding style violation on\nthe lines touched by those fixes.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/include/media_object.h | 10 ++++++----\n src/libcamera/media_device.cpp | 4 ++--\n src/libcamera/message.cpp | 2 +-\n test/libtest/test.h | 2 +-\n test/media_device/media_device_print_test.cpp | 8 ++++----\n 5 files changed, 14 insertions(+), 12 deletions(-)", "diff": "diff --git a/src/libcamera/include/media_object.h b/src/libcamera/include/media_object.h\nindex 2a3ffc06c876..748eafdc880b 100644\n--- a/src/libcamera/include/media_object.h\n+++ b/src/libcamera/include/media_object.h\n@@ -27,9 +27,11 @@ public:\n protected:\n \tfriend class MediaDevice;\n \n-\tMediaObject(MediaDevice *dev, unsigned int id) :\n-\t\tdev_(dev), id_(id) { }\n-\tvirtual ~MediaObject() { }\n+\tMediaObject(MediaDevice *dev, unsigned int id)\n+\t\t: dev_(dev), id_(id)\n+\t{\n+\t}\n+\tvirtual ~MediaObject() {}\n \n \tMediaDevice *dev_;\n \tunsigned int id_;\n@@ -49,7 +51,7 @@ private:\n \tMediaLink(const struct media_v2_link *link,\n \t\t MediaPad *source, MediaPad *sink);\n \tMediaLink(const MediaLink &) = delete;\n-\t~MediaLink() { }\n+\t~MediaLink() {}\n \n \tMediaPad *source_;\n \tMediaPad *sink_;\ndiff --git a/src/libcamera/media_device.cpp b/src/libcamera/media_device.cpp\nindex 0d6630fbd1f4..e1ae34f88455 100644\n--- a/src/libcamera/media_device.cpp\n+++ b/src/libcamera/media_device.cpp\n@@ -199,7 +199,7 @@ void MediaDevice::unlock()\n */\n int MediaDevice::populate()\n {\n-\tstruct media_v2_topology topology = { };\n+\tstruct media_v2_topology topology = {};\n \tstruct media_v2_entity *ents = nullptr;\n \tstruct media_v2_interface *interfaces = nullptr;\n \tstruct media_v2_link *links = nullptr;\n@@ -767,7 +767,7 @@ void MediaDevice::fixupEntityFlags(struct media_v2_entity *entity)\n */\n int MediaDevice::setupLink(const MediaLink *link, unsigned int flags)\n {\n-\tstruct media_link_desc linkDesc = { };\n+\tstruct media_link_desc linkDesc = {};\n \tMediaPad *source = link->source();\n \tMediaPad *sink = link->sink();\n \ndiff --git a/src/libcamera/message.cpp b/src/libcamera/message.cpp\nindex c547895362f3..c35bb33dfeda 100644\n--- a/src/libcamera/message.cpp\n+++ b/src/libcamera/message.cpp\n@@ -93,7 +93,7 @@ Message::~Message()\n * class MyCustomMessage : public Message\n * {\n * public:\n- *\tMyCustomMessage() : Message(type()) { }\n+ *\tMyCustomMessage() : Message(type()) {}\n *\n *\tstatic Message::Type type()\n *\t{\ndiff --git a/test/libtest/test.h b/test/libtest/test.h\nindex ec08bf97c03d..26d4b94bc12d 100644\n--- a/test/libtest/test.h\n+++ b/test/libtest/test.h\n@@ -26,7 +26,7 @@ public:\n protected:\n \tvirtual int init() { return 0; }\n \tvirtual int run() = 0;\n-\tvirtual void cleanup() { }\n+\tvirtual void cleanup() {}\n };\n \n #define TEST_REGISTER(klass)\t\t\t\t\t\t\\\ndiff --git a/test/media_device/media_device_print_test.cpp b/test/media_device/media_device_print_test.cpp\nindex 8dd8a151266d..5018906c75e7 100644\n--- a/test/media_device/media_device_print_test.cpp\n+++ b/test/media_device/media_device_print_test.cpp\n@@ -26,13 +26,13 @@ using namespace std;\n class MediaDevicePrintTest : public Test\n {\n public:\n-\tMediaDevicePrintTest() { }\n-\t~MediaDevicePrintTest() { }\n+\tMediaDevicePrintTest() {}\n+\t~MediaDevicePrintTest() {}\n \n protected:\n \tint init() { return 0; }\n \tint run();\n-\tvoid cleanup() { }\n+\tvoid cleanup() {}\n \n private:\n \tint testMediaDevice(string deviceNode);\n@@ -137,7 +137,7 @@ int MediaDevicePrintTest::run()\n \t */\n \tfor (i = 0; i < MAX_MEDIA_DEV; i++) {\n \t\tstring mediadev = deviceNode + to_string(i);\n-\t\tstruct stat pstat = { };\n+\t\tstruct stat pstat = {};\n \n \t\tif (stat(mediadev.c_str(), &pstat))\n \t\t\tcontinue;\n", "prefixes": [ "libcamera-devel", "2/2" ] }