Patch Detail
Show a patch.
GET /api/1.1/patches/22915/?format=api
{ "id": 22915, "url": "https://patchwork.libcamera.org/api/1.1/patches/22915/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22915/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250303193339.785634-1-barnabas.pocze@ideasonboard.com>", "date": "2025-03-03T19:33:39", "name": "[v1] apps: qcam: Simplify `PixelFormat` search", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "93bd606bb05ada7d9f44b2449a7353c54e2faf77", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/1.1/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22915/mbox/", "series": [ { "id": 5040, "url": "https://patchwork.libcamera.org/api/1.1/series/5040/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5040", "date": "2025-03-03T19:33:39", "name": "[v1] apps: qcam: Simplify `PixelFormat` search", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5040/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22915/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22915/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DB83CBD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 3 Mar 2025 19:33:44 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 93E3668855;\n\tMon, 3 Mar 2025 20:33:44 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0ACF168822\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 3 Mar 2025 20:33:43 +0100 (CET)", "from pb-laptop.local (185.221.143.4.nat.pool.zt.hu [185.221.143.4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7983E346\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 3 Mar 2025 20:32:11 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"snZ9H/dx\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1741030331;\n\tbh=pLNAL2sHnnMs1orpl0gqC82erUf5YepjRKN5m7nj5HY=;\n\th=From:To:Subject:Date:From;\n\tb=snZ9H/dx/rnlEm58TlbfpcLhS/tbbEEIhkKNuFwI8HGnA/PBTn307wD4ylVQn2SiD\n\tiLmuxUnbQLxQa3Jbh64wvn2Sk/YuL0HgggmBlfsRuLXboNToZzBkYK8RLvFq0kFRli\n\tIcQhcU/dnrO9dmT4EDlxcozrEU7r9CM8/guyE0+0=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v1] apps: qcam: Simplify `PixelFormat` search", "Date": "Mon, 3 Mar 2025 20:33:39 +0100", "Message-ID": "<20250303193339.785634-1-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.48.1", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Since `PixelFormat` has `operator==()`, `std::find()` can be used\ndirectly, so do that to simplify.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/apps/qcam/main_window.cpp | 5 +----\n 1 file changed, 1 insertion(+), 4 deletions(-)", "diff": "diff --git a/src/apps/qcam/main_window.cpp b/src/apps/qcam/main_window.cpp\nindex 3880a846e..d2ccbd231 100644\n--- a/src/apps/qcam/main_window.cpp\n+++ b/src/apps/qcam/main_window.cpp\n@@ -386,10 +386,7 @@ int MainWindow::startCapture()\n \t/* Use a format supported by the viewfinder if available. */\n \tstd::vector<PixelFormat> formats = vfConfig.formats().pixelformats();\n \tfor (const PixelFormat &format : viewfinder_->nativeFormats()) {\n-\t\tauto match = std::find_if(formats.begin(), formats.end(),\n-\t\t\t\t\t [&](const PixelFormat &f) {\n-\t\t\t\t\t\t return f == format;\n-\t\t\t\t\t });\n+\t\tauto match = std::find(formats.begin(), formats.end(), format);\n \t\tif (match != formats.end()) {\n \t\t\tvfConfig.pixelFormat = format;\n \t\t\tbreak;\n", "prefixes": [ "v1" ] }