Patch Detail
Show a patch.
GET /api/1.1/patches/22899/?format=api
{ "id": 22899, "url": "https://patchwork.libcamera.org/api/1.1/patches/22899/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22899/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250228125600.3241397-4-stefan.klug@ideasonboard.com>", "date": "2025-02-28T12:55:55", "name": "[3/3] ipa: rksip1: Remove setControls(0) to reduce startup oscillations", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "fd937421dbc19b3cd538531efb802b9b1a80a29a", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22899/mbox/", "series": [ { "id": 5029, "url": "https://patchwork.libcamera.org/api/1.1/series/5029/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5029", "date": "2025-02-28T12:55:52", "name": "rkisp1: Reduce oscillations on startup", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5029/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22899/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22899/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7C473C3259\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 28 Feb 2025 12:56:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B7E9E687CB;\n\tFri, 28 Feb 2025 13:56:16 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 18C1868773\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 28 Feb 2025 13:56:14 +0100 (CET)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:a7e:b81b:5754:579])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D0F49929;\n\tFri, 28 Feb 2025 13:54:44 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Ae7Nzjvi\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1740747284;\n\tbh=LgU4acq5yqLQ2wUtNlDIIWoSCllRxXnZNKngJXlBOb0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Ae7NzjviZFJJbUcarNWN1L6j2ZwJQXtK4R/S0N2OHstr+edIhqsMW2obAZ1iK2yrh\n\tlvF5oaTUJ9HwLLtFDthJ6QEQ5cLx12hsenreH2llAmXjNNkN3eM5qypclZVhNxrSme\n\tNYYE/7T4Vpk4Y0ArFgcyCIf4Z3M+irp7fEG7Vm8E=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH 3/3] ipa: rksip1: Remove setControls(0) to reduce startup\n\toscillations", "Date": "Fri, 28 Feb 2025 13:55:55 +0100", "Message-ID": "<20250228125600.3241397-4-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20250228125600.3241397-1-stefan.klug@ideasonboard.com>", "References": "<20250228125600.3241397-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The call to setControls(0) is counter productive. At start() time, no\nrequests were queued and no stats were received. So setControls(0)\naccesses a zeroed frame context and in turn sends 0 as gain, exposure\nand vblank to the pipeline handler and DelayedControls. This leads to\nstrong oscillations on every start of the camera.\n\nA proper fix for handling the startup controls still needs to be done\nand was already started in [1] and [2].\n\nFrom a DelayedControls point of view the call to setControls(0) is also\nunnecessary as DelayedControls treat frame 0 as already being queued in\nafter initialization.\n\nSo it is save to just remove it and the removal fixes the zero\neffectiveExposureValue discussed in the previous patch for rkisp1.\n\n[1]: https://patchwork.libcamera.org/patch/21708/\n[2]: https://patchwork.libcamera.org/patch/22445/\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n src/ipa/rkisp1/rkisp1.cpp | 2 --\n 1 file changed, 2 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 5f1583e8219b..b09dd6efdf08 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -211,8 +211,6 @@ int IPARkISP1::init(const IPASettings &settings, unsigned int hwRevision,\n \n int IPARkISP1::start()\n {\n-\tsetControls(0);\n-\n \treturn 0;\n }\n \n", "prefixes": [ "3/3" ] }