Patch Detail
Show a patch.
GET /api/1.1/patches/22880/?format=api
{ "id": 22880, "url": "https://patchwork.libcamera.org/api/1.1/patches/22880/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22880/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250226005547.30237-1-laurent.pinchart@ideasonboard.com>", "date": "2025-02-26T00:55:47", "name": "libcamera: camera: Log info message to report camera creation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "d3be9a80b745d91705aae049c6bd6b2321ef542d", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22880/mbox/", "series": [ { "id": 5024, "url": "https://patchwork.libcamera.org/api/1.1/series/5024/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5024", "date": "2025-02-26T00:55:47", "name": "libcamera: camera: Log info message to report camera creation", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5024/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22880/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22880/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 62B88BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 26 Feb 2025 00:56:08 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2C8ED68742;\n\tWed, 26 Feb 2025 01:56:08 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7003C6873D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 26 Feb 2025 01:56:06 +0100 (CET)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E7178502\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 26 Feb 2025 01:54:38 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"b5V7Lu66\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1740531279;\n\tbh=93UENvXEyRue1fMzbKh0vjmn/GSQ8F7SPrh3LW8lIYY=;\n\th=From:To:Subject:Date:From;\n\tb=b5V7Lu66aBePTHVpZmVXz7wFlQqqz6Fe8IkhsPY8MhIBoyWR4bOGfKDQz8tFRQH4a\n\tTIdldlxLJcF1Mfv5Yp6bhq11sBkGcKVDZVAUzchazi0NF2SBqXr0m04eG2xcYrqTEG\n\txaJWOXl+xztP41amdAivQGAV9Yb7NKFXbtEIVKjk=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH] libcamera: camera: Log info message to report camera\n\tcreation", "Date": "Wed, 26 Feb 2025 02:55:47 +0200", "Message-ID": "<20250226005547.30237-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.45.3", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Camera creation is one of the most important events generated by\nlibcamera, but we are completely silent about it. The lack of a log\nmessage makes it more difficult to identify problems and provide\nsupport. Fix it by adding an Info message that reports the camera id and\nits pipeline handler when the camera is created.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/camera.cpp | 4 ++++\n 1 file changed, 4 insertions(+)\n\n\nbase-commit: 33ce463a46c44f874fdbc3e484bee730e7b251a3\n--\nRegards,\n\nLaurent Pinchart", "diff": "diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex 56c5851993c9..35097bfdafa2 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -862,6 +862,10 @@ std::shared_ptr<Camera> Camera::create(std::unique_ptr<Private> d,\n \t\t}\n \t};\n\n+\tLOG(Camera, Info)\n+\t\t<< \"Creating camera '\" << id << \"' for pipeline handler \"\n+\t\t<< d->pipe_->name();\n+\n \tCamera *camera = new Camera(std::move(d), id, streams);\n\n \treturn std::shared_ptr<Camera>(camera, Deleter());\n", "prefixes": [] }