Patch Detail
Show a patch.
GET /api/1.1/patches/22879/?format=api
{ "id": 22879, "url": "https://patchwork.libcamera.org/api/1.1/patches/22879/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22879/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250226005541.30200-1-laurent.pinchart@ideasonboard.com>", "date": "2025-02-26T00:55:41", "name": "libcamera: base: signal: Drop pre-C++17 support", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "1d49a4fc32c18a3c4ac58e334365ce660596eebd", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22879/mbox/", "series": [ { "id": 5023, "url": "https://patchwork.libcamera.org/api/1.1/series/5023/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5023", "date": "2025-02-26T00:55:41", "name": "libcamera: base: signal: Drop pre-C++17 support", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5023/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22879/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22879/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EDB48BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 26 Feb 2025 00:56:03 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C1CBF6873F;\n\tWed, 26 Feb 2025 01:56:02 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BC9C868735\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 26 Feb 2025 01:56:00 +0100 (CET)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 18E41502\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 26 Feb 2025 01:54:33 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GtzTt9Iq\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1740531273;\n\tbh=bdhjXQ38vCT/FACh0Vq7iqkqzRSNR8fIkt0yVgs5RPw=;\n\th=From:To:Subject:Date:From;\n\tb=GtzTt9IqniraDVp67QESc/7Kya78yc3cGvTixNB59T8a5D2B0JbmShvEe9lAAsoDZ\n\tCAjzIv1yScahYB4EsibyvxkvbrC8CrFZJSH9eGqlT3CFsIH435iKeKzICG0uS/SNOj\n\tybCif4tCvRetNn3ibABGLbXoP1HgDmYBqePsfsRg=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH] libcamera: base: signal: Drop pre-C++17 support", "Date": "Wed, 26 Feb 2025 02:55:41 +0200", "Message-ID": "<20250226005541.30200-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.45.3", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The libcamera public API requires C++17, ddddrop support for older\nstandards.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/base/signal.h | 14 ++++----------\n 1 file changed, 4 insertions(+), 10 deletions(-)\n\n\nbase-commit: 33ce463a46c44f874fdbc3e484bee730e7b251a3\n--\nRegards,\n\nLaurent Pinchart", "diff": "diff --git a/include/libcamera/base/signal.h b/include/libcamera/base/signal.h\nindex bbff1495ac75..ed1d81ea5c98 100644\n--- a/include/libcamera/base/signal.h\n+++ b/include/libcamera/base/signal.h\n@@ -63,11 +63,8 @@ public:\n\n #ifndef __DOXYGEN__\n \ttemplate<typename T, typename Func,\n-\t\t std::enable_if_t<std::is_base_of<Object, T>::value\n-#if __cplusplus >= 201703L\n-\t\t\t\t && std::is_invocable_v<Func, Args...>\n-#endif\n-\t\t\t\t > * = nullptr>\n+\t\t std::enable_if_t<std::is_base_of<Object, T>::value &&\n+\t\t\t\t std::is_invocable_v<Func, Args...>> * = nullptr>\n \tvoid connect(T *obj, Func func, ConnectionType type = ConnectionTypeAuto)\n \t{\n \t\tObject *object = static_cast<Object *>(obj);\n@@ -75,11 +72,8 @@ public:\n \t}\n\n \ttemplate<typename T, typename Func,\n-\t\t std::enable_if_t<!std::is_base_of<Object, T>::value\n-#if __cplusplus >= 201703L\n-\t\t\t\t && std::is_invocable_v<Func, Args...>\n-#endif\n-\t\t\t\t > * = nullptr>\n+\t\t std::enable_if_t<!std::is_base_of<Object, T>::value &&\n+\t\t\t\t std::is_invocable_v<Func, Args...>> * = nullptr>\n #else\n \ttemplate<typename T, typename Func>\n #endif\n", "prefixes": [] }