Patch Detail
Show a patch.
GET /api/1.1/patches/22876/?format=api
{ "id": 22876, "url": "https://patchwork.libcamera.org/api/1.1/patches/22876/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22876/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250225173531.2595922-7-pobrn@protonmail.com>", "date": "2025-02-25T17:36:10", "name": "[v4,6/8] libcamera: base: log: Pass dynamic prefix through", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "bd64684eecf46480ba634e6551b72439efe8f319", "submitter": { "id": 133, "url": "https://patchwork.libcamera.org/api/1.1/people/133/?format=api", "name": "Pőcze Barnabás", "email": "pobrn@protonmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22876/mbox/", "series": [ { "id": 5022, "url": "https://patchwork.libcamera.org/api/1.1/series/5022/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5022", "date": "2025-02-25T17:35:34", "name": "libcamera: base: log: Misc. changes", "version": 4, "mbox": "https://patchwork.libcamera.org/series/5022/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22876/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22876/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 03AAFBDB1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 25 Feb 2025 17:36:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ABFC868737;\n\tTue, 25 Feb 2025 18:36:16 +0100 (CET)", "from mail-40134.protonmail.ch (mail-40134.protonmail.ch\n\t[185.70.40.134])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C66A468733\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 25 Feb 2025 18:36:15 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"Q3ibdWN+\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1740504975; x=1740764175;\n\tbh=/noqSu4fVaWgCxSoaRAATgwSqN50IgRkfAlKy4jj8y0=;\n\th=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;\n\tb=Q3ibdWN+X1mtu6tlwKrUWdwhfFgkmSFXVdKcPZuvbKSkSFVHEyyMuxRH2NKuUokxz\n\t4N3j5hELYKpiw7nun770wX8eRCM7GhWetZhk5VtseQmBFZqjWHRubKJ7tIq+uKUeWD\n\tPjt//4OUBPg6uQzjwvF3ShsIRxXqVKc9+uAqr2nyt8FXB5+K8CA5yU9ikeDFizSEfa\n\tefnL4PbM3GDuSHthIAjenVLn0ZA+kQZDwA6ugz+As6iHS1gm6Nw0fqWnEgt7Apn8kX\n\te2Z/QKy4AhKutoNg1ryXC1Gw7Z3714R2p08bjWV83bpNrAQRAox10G0nK5p00TwTIB\n\tVpF3cx5TFVoOA==", "Date": "Tue, 25 Feb 2025 17:36:10 +0000", "To": "libcamera-devel@lists.libcamera.org", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>", "Cc": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[PATCH v4 6/8] libcamera: base: log: Pass dynamic prefix through", "Message-ID": "<20250225173531.2595922-7-pobrn@protonmail.com>", "In-Reply-To": "<20250225173531.2595922-1-pobrn@protonmail.com>", "References": "<20250225173531.2595922-1-pobrn@protonmail.com>", "Feedback-ID": "20568564:user:proton", "X-Pm-Message-ID": "7a640fd162f6ea3af5dea77205916449c6e5dabf", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=utf-8", "Content-Transfer-Encoding": "quoted-printable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Use move construction to essentially pass through the string\nreturned by `Loggable::logPrefix()` to avoid an unnecessary copy.\n\nSigned-off-by: Barnabás Pőcze <pobrn@protonmail.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/base/log.h | 2 +-\n src/libcamera/base/log.cpp | 4 ++--\n 2 files changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/include/libcamera/base/log.h b/include/libcamera/base/log.h\nindex acef24203..1fb92603f 100644\n--- a/include/libcamera/base/log.h\n+++ b/include/libcamera/base/log.h\n@@ -64,7 +64,7 @@ class LogMessage\n public:\n \tLogMessage(const char *fileName, unsigned int line,\n \t\t const LogCategory &category, LogSeverity severity,\n-\t\t const std::string &prefix = std::string());\n+\t\t std::string prefix = {});\n \t~LogMessage();\n \n \tstd::ostream &stream() { return msgStream_; }\ndiff --git a/src/libcamera/base/log.cpp b/src/libcamera/base/log.cpp\nindex c0e0be60f..6687deb93 100644\n--- a/src/libcamera/base/log.cpp\n+++ b/src/libcamera/base/log.cpp\n@@ -858,11 +858,11 @@ const LogCategory &LogCategory::defaultCategory()\n */\n LogMessage::LogMessage(const char *fileName, unsigned int line,\n \t\t const LogCategory &category, LogSeverity severity,\n-\t\t const std::string &prefix)\n+\t\t std::string prefix)\n \t: category_(category), severity_(severity),\n \t timestamp_(utils::clock::now()),\n \t fileInfo_((std::ostringstream() << utils::basename(fileName) << \":\" << line).str()),\n-\t prefix_(prefix)\n+\t prefix_(std::move(prefix))\n {\n }\n \n", "prefixes": [ "v4", "6/8" ] }