Patch Detail
Show a patch.
GET /api/1.1/patches/22868/?format=api
{ "id": 22868, "url": "https://patchwork.libcamera.org/api/1.1/patches/22868/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22868/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250225164116.414301-5-stanislaw.gruszka@linux.intel.com>", "date": "2025-02-25T16:41:15", "name": "[v5,4/5] pipeline: simple: Do not apply controls twice", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "55fec00fbe6c6b18ca619331cfa29a0971635c92", "submitter": { "id": 211, "url": "https://patchwork.libcamera.org/api/1.1/people/211/?format=api", "name": "Stanislaw Gruszka", "email": "stanislaw.gruszka@linux.intel.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22868/mbox/", "series": [ { "id": 5021, "url": "https://patchwork.libcamera.org/api/1.1/series/5021/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5021", "date": "2025-02-25T16:41:11", "name": "libcamera: start frame events changes", "version": 5, "mbox": "https://patchwork.libcamera.org/series/5021/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22868/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22868/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DE032BDB1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 25 Feb 2025 16:41:51 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8A61268732;\n\tTue, 25 Feb 2025 17:41:51 +0100 (CET)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.11])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AFD5E6871F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 25 Feb 2025 17:41:49 +0100 (CET)", "from orviesa006.jf.intel.com ([10.64.159.146])\n\tby fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n\t25 Feb 2025 08:41:49 -0800", "from sgruszka-mobl.ger.corp.intel.com (HELO localhost)\n\t([10.245.115.185]) by orviesa006-auth.jf.intel.com with\n\tESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Feb 2025 08:41:47 -0800" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=intel.com header.i=@intel.com\n\theader.b=\"UlqsvkGj\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n\td=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n\tt=1740501710; x=1772037710;\n\th=from:to:cc:subject:date:message-id:in-reply-to:\n\treferences:mime-version:content-transfer-encoding;\n\tbh=Y5wdfFYDBMNLyP2m5ayrPxIgyqj/crVleZ3xSB+6TJs=;\n\tb=UlqsvkGjLNlpplORm7TLTTFz0Vz+YHvIP9jJMAa3Lr4c5LRdmALhHRHJ\n\tuuz+sMT0nO2E0FFjYN75y/T05lWwaC2h0juFTIAVPt1vjXcZALbdnhBTh\n\tjRJJitUWO6sdIQ1jOCAga1GvwZHuzcuyonPwpVkms2wTuF9AeYcgithyl\n\tZ2mE1c1zrXEtz1w0drtrVsugk8QwmG71RR8ORABVfh0SRwNjxUVsUsFNH\n\tNyCVijt1yGKhgOc832X35s42zCoaI21OPX/RLTNPtt6+WE5sixLpXk/P7\n\to9b3tTGEbXxvE8c9cExk7dPLkyS15OCYT7cQjdehG1UaW7c4oBH9Q/P3y g==;", "X-CSE-ConnectionGUID": [ "5GfbR0Z2RKevaNtI0aGAxQ==", "XKvuQk59THOMGtVeZR2Wsg==" ], "X-CSE-MsgGUID": [ "+V8ganN5R/e8OGbMyrUkzg==", "JxRgiii0Rtm116MdVUFwHg==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6700,10204,11356\"; a=\"51948295\"", "E=Sophos;i=\"6.13,314,1732608000\"; d=\"scan'208\";a=\"51948295\"", "E=Sophos;i=\"6.13,314,1732608000\"; d=\"scan'208\";a=\"116426802\"" ], "X-ExtLoop1": "1", "From": "Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tNaushir Patuck <naush@raspberrypi.com>,\n\tSakari Ailus <sakari.ailus@linux.intel.com>,\n\tHans de Goede <hdegoede@redhat.com>", "Subject": "[PATCH v5 4/5] pipeline: simple: Do not apply controls twice", "Date": "Tue, 25 Feb 2025 17:41:15 +0100", "Message-Id": "<20250225164116.414301-5-stanislaw.gruszka@linux.intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20250225164116.414301-1-stanislaw.gruszka@linux.intel.com>", "References": "<20250225164116.414301-1-stanislaw.gruszka@linux.intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Apply controls directly only when there is no start frame emitter\ndevice.\n\nCo-developed-by: Hans de Goede <hdegoede@redhat.com>\nSigned-off-by: Hans de Goede <hdegoede@redhat.com>\nSigned-off-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>\n---\n src/libcamera/pipeline/simple/simple.cpp | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 774c7824..b92b738b 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -911,8 +911,11 @@ void SimpleCameraData::ispStatsReady(uint32_t frame, uint32_t bufferId)\n void SimpleCameraData::setSensorControls(const ControlList &sensorControls)\n {\n \tdelayedCtrls_->push(sensorControls);\n-\tControlList ctrls(sensorControls);\n-\tsensor_->setControls(&ctrls);\n+\t/* Directly apply controls now if there is no frameStart signal */\n+\tif (!frameStartEmitter_) {\n+\t\tControlList ctrls(sensorControls);\n+\t\tsensor_->setControls(&ctrls);\n+\t}\n }\n \n /* Retrieve all source pads connected to a sink pad through active routes. */\n", "prefixes": [ "v5", "4/5" ] }