Patch Detail
Show a patch.
GET /api/1.1/patches/22847/?format=api
{ "id": 22847, "url": "https://patchwork.libcamera.org/api/1.1/patches/22847/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22847/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250224185235.43381-2-mzamazal@redhat.com>", "date": "2025-02-24T18:52:31", "name": "[v2,1/5] libcamera: software_isp: Emit ispStatsReady only if IPA is running", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "19f30594282adcd071eceaef37d7a57aad04acce", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/1.1/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22847/mbox/", "series": [ { "id": 5016, "url": "https://patchwork.libcamera.org/api/1.1/series/5016/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5016", "date": "2025-02-24T18:52:30", "name": "Fix occasional software ISP assertion error on stop", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5016/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22847/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22847/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 82AF3C32A9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 24 Feb 2025 18:52:55 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 34B76686FC;\n\tMon, 24 Feb 2025 19:52:55 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 44BA661856\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 24 Feb 2025 19:52:53 +0100 (CET)", "from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-295-P73Wc9AEMVCKlbW1shLBVA-1;\n\tMon, 24 Feb 2025 13:52:48 -0500", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.111])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 78A9319373D8; Mon, 24 Feb 2025 18:52:47 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.45.225.60])\n\tby mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 55C3F1800352; Mon, 24 Feb 2025 18:52:44 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"L3oxz9G1\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1740423172;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=gd2ZKQ0qvhaFzc6uD//mdh4fqOebG9ryBtI040IS3cQ=;\n\tb=L3oxz9G1+Gyie7dXY8LYSbAo5hpzlkD5UpNS2x0yOTnDkkuP59KNsZcdoQc6Qs1ZpKRxmE\n\tPCbKSaLRzmTlznCl3enSGOQhSRu5r/pBXtjXKYRzepIRbCe6Kbbqm9cjwDpbDiPOEK2tT8\n\tdWw1z6sjjYAyxXVSAHAgcUYVwOlgk2I=", "X-MC-Unique": "P73Wc9AEMVCKlbW1shLBVA-1", "X-Mimecast-MFC-AGG-ID": "P73Wc9AEMVCKlbW1shLBVA_1740423167", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tStanislaw Gruszka <stanislaw.gruszka@linux.intel.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v2 1/5] libcamera: software_isp: Emit ispStatsReady only if\n\tIPA is running", "Date": "Mon, 24 Feb 2025 19:52:31 +0100", "Message-ID": "<20250224185235.43381-2-mzamazal@redhat.com>", "In-Reply-To": "<20250224185235.43381-1-mzamazal@redhat.com>", "References": "<20250224185235.43381-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "6VU6Z2ttH9PpmrxM1Zcbufb7hc1TBWSlyuovMM3McS8_1740423167", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Software ISP runs debayering in a separate thread and debayering may\nemit statsReady when software ISP (including the IPA) is being stopped.\nThe signal waits in a queue and gets invoked later, resulting in an\nassertion error when attempting to invoke a method on the stopped IPA:\n\n FATAL default soft_ipa_proxy.cpp:456 assertion\n \"state_ == ProxyRunning\" failed in processStatsThread()\n\nLet's prevent this problem by forwarding the ISP stats signal from\nsoftware ISP only when the IPA is running. To track this,\nSoftwareISP::running_ variable is introduced.\n\nMaking processing of the other signals in SoftwareISP more robust is\naddressed in the followup patches.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n include/libcamera/internal/software_isp/software_isp.h | 1 +\n src/libcamera/software_isp/software_isp.cpp | 5 ++++-\n 2 files changed, 5 insertions(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/internal/software_isp/software_isp.h b/include/libcamera/internal/software_isp/software_isp.h\nindex 440a296d..af0dcc24 100644\n--- a/include/libcamera/internal/software_isp/software_isp.h\n+++ b/include/libcamera/internal/software_isp/software_isp.h\n@@ -100,6 +100,7 @@ private:\n \tDmaBufAllocator dmaHeap_;\n \n \tstd::unique_ptr<ipa::soft::IPAProxySoft> ipa_;\n+\tbool running_;\n };\n \n } /* namespace libcamera */\ndiff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex 44baf200..1a39f4d8 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -315,6 +315,7 @@ int SoftwareIsp::start()\n \tint ret = ipa_->start();\n \tif (ret)\n \t\treturn ret;\n+\trunning_ = true;\n \n \tispWorkerThread_.start();\n \treturn 0;\n@@ -328,6 +329,7 @@ void SoftwareIsp::stop()\n \tispWorkerThread_.exit();\n \tispWorkerThread_.wait();\n \n+\trunning_ = false;\n \tipa_->stop();\n }\n \n@@ -356,7 +358,8 @@ void SoftwareIsp::setSensorCtrls(const ControlList &sensorControls)\n \n void SoftwareIsp::statsReady(uint32_t frame, uint32_t bufferId)\n {\n-\tispStatsReady.emit(frame, bufferId);\n+\tif (running_)\n+\t\tispStatsReady.emit(frame, bufferId);\n }\n \n void SoftwareIsp::inputReady(FrameBuffer *input)\n", "prefixes": [ "v2", "1/5" ] }