Patch Detail
Show a patch.
GET /api/1.1/patches/22836/?format=api
{ "id": 22836, "url": "https://patchwork.libcamera.org/api/1.1/patches/22836/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22836/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250223230403.1226-15-laurent.pinchart@ideasonboard.com>", "date": "2025-02-23T23:04:02", "name": "[14/15] ipa: rkisp1: awb: Capitalize AWB", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "625d0c454734cce8fc4e254b92369f7662b39821", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22836/mbox/", "series": [ { "id": 5012, "url": "https://patchwork.libcamera.org/api/1.1/series/5012/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5012", "date": "2025-02-23T23:03:48", "name": "libipa: awb: Drive-by fixes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5012/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22836/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22836/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 755EEBDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 23 Feb 2025 23:05:00 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A7980686CD;\n\tMon, 24 Feb 2025 00:04:59 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 65113686BE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 24 Feb 2025 00:04:40 +0100 (CET)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 55CAB82A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 24 Feb 2025 00:03:14 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Jy66D+cY\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1740351794;\n\tbh=w96LbgfPxeVCYpFQYzDz83EDvoCPFeBvX6xGYLrHHzo=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=Jy66D+cYKN6A/6MPu8vExyodRBO0JT/h623DCc6uitqP85NYCKbDdH+PHK6pBq7AY\n\tWJdIi8aiGfVHpfSLzSf8Ej8UlLIg1WnwSpMOUBgtt+72zsZxwKiO6gRbrj+5mWvsSe\n\tc69XDYHRsrM2Og7R5ciNRobSwjiR3NesjEUVNgMM=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH 14/15] ipa: rkisp1: awb: Capitalize AWB", "Date": "Mon, 24 Feb 2025 01:04:02 +0200", "Message-ID": "<20250223230403.1226-15-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.45.3", "In-Reply-To": "<20250223230403.1226-1-laurent.pinchart@ideasonboard.com>", "References": "<20250223230403.1226-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "AWB is an abbreviation, capitalize it in comments and log messages for\nconsistency.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/rkisp1/algorithms/awb.cpp | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\nindex 7f333ef86518..3c2864fd181c 100644\n--- a/src/ipa/rkisp1/algorithms/awb.cpp\n+++ b/src/ipa/rkisp1/algorithms/awb.cpp\n@@ -92,7 +92,7 @@ int Awb::init(IPAContext &context, const YamlObject &tuningData)\n \t\t\t\t\t\t\t kDefaultColourTemperature);\n \n \tif (!tuningData.contains(\"algorithm\"))\n-\t\tLOG(RkISP1Awb, Info) << \"No awb algorithm specified.\"\n+\t\tLOG(RkISP1Awb, Info) << \"No AWB algorithm specified.\"\n \t\t\t\t << \" Default to grey world\";\n \n \tauto mode = tuningData[\"algorithm\"].get<std::string>(\"grey\");\n@@ -101,14 +101,14 @@ int Awb::init(IPAContext &context, const YamlObject &tuningData)\n \t} else if (mode == \"bayes\") {\n \t\tawbAlgo_ = std::make_unique<AwbBayes>();\n \t} else {\n-\t\tLOG(RkISP1Awb, Error) << \"Unknown awb algorithm: \" << mode;\n+\t\tLOG(RkISP1Awb, Error) << \"Unknown AWB algorithm: \" << mode;\n \t\treturn -EINVAL;\n \t}\n-\tLOG(RkISP1Awb, Debug) << \"Using awb algorithm: \" << mode;\n+\tLOG(RkISP1Awb, Debug) << \"Using AWB algorithm: \" << mode;\n \n \tint ret = awbAlgo_->init(tuningData);\n \tif (ret) {\n-\t\tLOG(RkISP1Awb, Error) << \"Failed to init awb algorithm\";\n+\t\tLOG(RkISP1Awb, Error) << \"Failed to init AWB algorithm\";\n \t\treturn ret;\n \t}\n \n", "prefixes": [ "14/15" ] }