Patch Detail
Show a patch.
GET /api/1.1/patches/22834/?format=api
{ "id": 22834, "url": "https://patchwork.libcamera.org/api/1.1/patches/22834/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22834/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250223230403.1226-13-laurent.pinchart@ideasonboard.com>", "date": "2025-02-23T23:04:00", "name": "[12/15] libipa: awb_grey: Minor comment fixes", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "36d9c4d8329dbb958bc303b50a5210f78f0909b8", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22834/mbox/", "series": [ { "id": 5012, "url": "https://patchwork.libcamera.org/api/1.1/series/5012/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5012", "date": "2025-02-23T23:03:48", "name": "libipa: awb: Drive-by fixes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5012/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22834/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22834/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1CD82BDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 23 Feb 2025 23:04:55 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 98614686E6;\n\tMon, 24 Feb 2025 00:04:54 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AB10B686D8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 24 Feb 2025 00:04:37 +0100 (CET)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 98F36353\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 24 Feb 2025 00:03:11 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YVKYSJdP\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1740351791;\n\tbh=0lUwjKUJURJnM9Bp1HfhoCWA9Gq4AYqXqbRVXSNf6es=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=YVKYSJdPEYble8stGyXg09fHE92N/9NhFl4WguMStNqlcN4zhGh5qOIf0ker8RtrV\n\tRfgpP4DggwC7ni9UI8ycSOFm1E2zbhUzp3DPKhr5vR2JO1SS6AzvoTBG0TzLkaXhKD\n\thL1/RId9g41lFIUWO89BJtG1CHbGrvw8xmK2qMOA=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH 12/15] libipa: awb_grey: Minor comment fixes", "Date": "Mon, 24 Feb 2025 01:04:00 +0200", "Message-ID": "<20250223230403.1226-13-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.45.3", "In-Reply-To": "<20250223230403.1226-1-laurent.pinchart@ideasonboard.com>", "References": "<20250223230403.1226-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Fix the top-level file description to mention the file contains an AWB\ngrey world implementation, not a base class, and fix a grammar mistake\nin a documentation block.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/libipa/awb_grey.cpp | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/src/ipa/libipa/awb_grey.cpp b/src/ipa/libipa/awb_grey.cpp\nindex 0e6c5220c393..d3d2132b8869 100644\n--- a/src/ipa/libipa/awb_grey.cpp\n+++ b/src/ipa/libipa/awb_grey.cpp\n@@ -2,7 +2,7 @@\n /*\n * Copyright (C) 2024 Ideas on Board Oy\n *\n- * Base class for grey world AWB algorithm\n+ * Implementation of grey world AWB algorithm\n */\n \n #include \"awb_grey.h\"\n@@ -61,10 +61,10 @@ int AwbGrey::init(const YamlObject &tuningData)\n * \\param[in] stats The statistics to use for the calculation\n * \\param[in] lux The lux value of the scene\n *\n- * Estimates the colour temperature based on the colours::estimateCCT function.\n- * The gains are calculated purely based on the RGB means provided by the \\a\n- * stats. The colour temperature is not taken into account when calculating the\n- * gains.\n+ * The colour temperature is estimated based on the colours::estimateCCT()\n+ * function. The gains are calculated purely based on the RGB means provided by\n+ * the \\a stats. The colour temperature is not taken into account when\n+ * calculating the gains.\n *\n * The \\a lux parameter is not used in this algorithm.\n *\n", "prefixes": [ "12/15" ] }