Patch Detail
Show a patch.
GET /api/1.1/patches/22833/?format=api
{ "id": 22833, "url": "https://patchwork.libcamera.org/api/1.1/patches/22833/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22833/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250223230403.1226-12-laurent.pinchart@ideasonboard.com>", "date": "2025-02-23T23:03:59", "name": "[11/15] libipa: awb: Tidy up includes", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "b6e6b26240e43d25d9b8573b1cca7a2413626b10", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22833/mbox/", "series": [ { "id": 5012, "url": "https://patchwork.libcamera.org/api/1.1/series/5012/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5012", "date": "2025-02-23T23:03:48", "name": "libipa: awb: Drive-by fixes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5012/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22833/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22833/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5334DBDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 23 Feb 2025 23:04:53 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 64E1E686E9;\n\tMon, 24 Feb 2025 00:04:52 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 17306686BF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 24 Feb 2025 00:04:36 +0100 (CET)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9FD4B82A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 24 Feb 2025 00:03:09 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DhAV742C\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1740351789;\n\tbh=PJ7PgLnSwhJ/mcjU9rz2QW8Xk2uPYc3pnCvwvMzA4dM=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=DhAV742CiGpAADgjZjzl0TXf/9xkt3M4SKEZoZaRXTnXWzooaQslYINRJQs8C8V1Y\n\t8Gd1gjjBiW50shqr6iQ7QtmKr7dahZEbfvpHYgbx8Pz3BTkdYuvvDEqC7vDnv/Vr2s\n\tkYmB4FZa1w3t+1uFq4jbC3WR2/7QUx81XWlPZzFU=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH 11/15] libipa: awb: Tidy up includes", "Date": "Mon, 24 Feb 2025 01:03:59 +0200", "Message-ID": "<20250223230403.1226-12-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.45.3", "In-Reply-To": "<20250223230403.1226-1-laurent.pinchart@ideasonboard.com>", "References": "<20250223230403.1226-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Drop unneeded headers and add missing ones.\n\nThe yaml_parser.h header is dropped from awb_grey.h as the classes it\nprovides are only used in virtual functions defined by the base class,\nso any required definitions are guaranteed to be available already.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/libipa/awb_bayes.cpp | 5 +++++\n src/ipa/libipa/awb_bayes.h | 8 --------\n src/ipa/libipa/awb_grey.cpp | 2 +-\n src/ipa/libipa/awb_grey.h | 3 ++-\n 4 files changed, 8 insertions(+), 10 deletions(-)", "diff": "diff --git a/src/ipa/libipa/awb_bayes.cpp b/src/ipa/libipa/awb_bayes.cpp\nindex 97bd256526a4..d2869610a25b 100644\n--- a/src/ipa/libipa/awb_bayes.cpp\n+++ b/src/ipa/libipa/awb_bayes.cpp\n@@ -8,7 +8,12 @@\n \n #include \"awb_bayes.h\"\n \n+#include <algorithm>\n #include <cmath>\n+#include <limits>\n+#include <map>\n+#include <ostream>\n+#include <vector>\n \n #include <libcamera/base/log.h>\n #include <libcamera/control_ids.h>\ndiff --git a/src/ipa/libipa/awb_bayes.h b/src/ipa/libipa/awb_bayes.h\nindex b74201b542fb..a5790e69eed7 100644\n--- a/src/ipa/libipa/awb_bayes.h\n+++ b/src/ipa/libipa/awb_bayes.h\n@@ -7,14 +7,6 @@\n \n #pragma once\n \n-#include <map>\n-#include <memory>\n-#include <tuple>\n-#include <vector>\n-\n-#include <libcamera/base/utils.h>\n-\n-#include <libcamera/control_ids.h>\n #include <libcamera/controls.h>\n \n #include \"libcamera/internal/vector.h\"\ndiff --git a/src/ipa/libipa/awb_grey.cpp b/src/ipa/libipa/awb_grey.cpp\nindex 17b8598400e7..0e6c5220c393 100644\n--- a/src/ipa/libipa/awb_grey.cpp\n+++ b/src/ipa/libipa/awb_grey.cpp\n@@ -7,7 +7,7 @@\n \n #include \"awb_grey.h\"\n \n-#include <cmath>\n+#include <algorithm>\n \n #include <libcamera/base/log.h>\n #include <libcamera/control_ids.h>\ndiff --git a/src/ipa/libipa/awb_grey.h b/src/ipa/libipa/awb_grey.h\nindex e3c34201dbc9..7ec7bfa5da9a 100644\n--- a/src/ipa/libipa/awb_grey.h\n+++ b/src/ipa/libipa/awb_grey.h\n@@ -7,8 +7,9 @@\n \n #pragma once\n \n+#include <optional>\n+\n #include \"libcamera/internal/vector.h\"\n-#include \"libcamera/internal/yaml_parser.h\"\n \n #include \"awb.h\"\n #include \"interpolator.h\"\n", "prefixes": [ "11/15" ] }