Patch Detail
Show a patch.
GET /api/1.1/patches/22824/?format=api
{ "id": 22824, "url": "https://patchwork.libcamera.org/api/1.1/patches/22824/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22824/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250223230403.1226-3-laurent.pinchart@ideasonboard.com>", "date": "2025-02-23T23:03:50", "name": "[02/15] libipa: awb: Capitalize AWB", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "c4617a2b2b22678d73276bfb85502f0720d901d7", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22824/mbox/", "series": [ { "id": 5012, "url": "https://patchwork.libcamera.org/api/1.1/series/5012/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5012", "date": "2025-02-23T23:03:48", "name": "libipa: awb: Drive-by fixes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5012/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22824/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22824/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 42401BDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 23 Feb 2025 23:04:33 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4881B686BE;\n\tMon, 24 Feb 2025 00:04:27 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0B6FB686B9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 24 Feb 2025 00:04:23 +0100 (CET)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 04E53353\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 24 Feb 2025 00:02:56 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YN4eedfg\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1740351777;\n\tbh=aqU/o2GHgx0rCNkHlr5JhSLOVq5GsF7QQFoFpkbvJKU=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=YN4eedfgXohLQxV9LzQyEnPE+rdcEKJvAZPEWEZ7bEwwhnz3aSpVIHaNRADPmx94I\n\tqMsqcL9Rh2jA9JVHFtuSaH6gz3ef9FRl39w4RGcMrf/heddmHhoGDJVSXjw7kbAjqS\n\tAPTHP+5b4gAzvQ4rnqbCf2CsxzPsvx+VGksjOBGA=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH 02/15] libipa: awb: Capitalize AWB", "Date": "Mon, 24 Feb 2025 01:03:50 +0200", "Message-ID": "<20250223230403.1226-3-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.45.3", "In-Reply-To": "<20250223230403.1226-1-laurent.pinchart@ideasonboard.com>", "References": "<20250223230403.1226-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "AWB is an abbreviation, capitalize it in comments and log messages for\nconsistency.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/libipa/awb.cpp | 14 +++++++-------\n src/ipa/libipa/awb_grey.cpp | 4 ++--\n 2 files changed, 9 insertions(+), 9 deletions(-)", "diff": "diff --git a/src/ipa/libipa/awb.cpp b/src/ipa/libipa/awb.cpp\nindex 2e78a4665509..dc672f129c4a 100644\n--- a/src/ipa/libipa/awb.cpp\n+++ b/src/ipa/libipa/awb.cpp\n@@ -24,7 +24,7 @@ namespace ipa {\n \n /**\n * \\class AwbResult\n- * \\brief The result of an awb calculation\n+ * \\brief The result of an AWB calculation\n *\n * This class holds the result of an auto white balance calculation.\n */\n@@ -57,7 +57,7 @@ namespace ipa {\n * applied. To keep the actual implementations computationally inexpensive,\n * the squared colour error shall be returned.\n *\n- * If the awb statistics provide multiple zones, the average of the individual\n+ * If the AWB statistics provide multiple zones, the average of the individual\n * squared errors shall be returned. Averaging/normalizing is necessary so that\n * the numeric dimensions are the same on all hardware platforms.\n *\n@@ -94,7 +94,7 @@ namespace ipa {\n \n /**\n * \\fn AwbAlgorithm::calculateAwb\n- * \\brief Calculate awb data from the given statistics\n+ * \\brief Calculate AWB data from the given statistics\n * \\param[in] stats The statistics to use for the calculation\n * \\param[in] lux The lux value of the scene\n *\n@@ -102,7 +102,7 @@ namespace ipa {\n * lux value of 0 means it is unknown or invalid and the algorithm shall ignore\n * it.\n *\n- * \\return The awb result\n+ * \\return The AWB result\n */\n \n /**\n@@ -178,14 +178,14 @@ int AwbAlgorithm::parseModeConfigs(const YamlObject &tuningData,\n \t\tif (controls::AwbModeNameValueMap.find(modeName) ==\n \t\t controls::AwbModeNameValueMap.end()) {\n \t\t\tLOG(Awb, Warning)\n-\t\t\t\t<< \"Skipping unknown awb mode '\"\n+\t\t\t\t<< \"Skipping unknown AWB mode '\"\n \t\t\t\t<< modeName << \"'\";\n \t\t\tcontinue;\n \t\t}\n \n \t\tif (!modeDict.isDictionary()) {\n \t\t\tLOG(Awb, Error)\n-\t\t\t\t<< \"Invalid awb mode '\" << modeName << \"'\";\n+\t\t\t\t<< \"Invalid AWB mode '\" << modeName << \"'\";\n \t\t\treturn -EINVAL;\n \t\t}\n \n@@ -235,7 +235,7 @@ int AwbAlgorithm::parseModeConfigs(const YamlObject &tuningData,\n * \\class AwbAlgorithm::ModeConfig\n * \\brief Holds the configuration of a single AWB mode\n *\n- * Awb modes limit the regulation of the AWB algorithm to a specific range of\n+ * AWB modes limit the regulation of the AWB algorithm to a specific range of\n * colour temperatures.\n */\n \ndiff --git a/src/ipa/libipa/awb_grey.cpp b/src/ipa/libipa/awb_grey.cpp\nindex 49448976ed26..06ffd45618d8 100644\n--- a/src/ipa/libipa/awb_grey.cpp\n+++ b/src/ipa/libipa/awb_grey.cpp\n@@ -57,7 +57,7 @@ int AwbGrey::init(const YamlObject &tuningData)\n }\n \n /**\n- * \\brief Calculate awb data from the given statistics\n+ * \\brief Calculate AWB data from the given statistics\n * \\param[in] stats The statistics to use for the calculation\n * \\param[in] lux The lux value of the scene\n *\n@@ -68,7 +68,7 @@ int AwbGrey::init(const YamlObject &tuningData)\n *\n * The \\a lux parameter is not used in this algorithm.\n *\n- * \\return The awb result\n+ * \\return The AWB result\n */\n AwbResult AwbGrey::calculateAwb(const AwbStats &stats, [[maybe_unused]] int lux)\n {\n", "prefixes": [ "02/15" ] }