Patch Detail
Show a patch.
GET /api/1.1/patches/22823/?format=api
{ "id": 22823, "url": "https://patchwork.libcamera.org/api/1.1/patches/22823/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22823/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250223230403.1226-2-laurent.pinchart@ideasonboard.com>", "date": "2025-02-23T23:03:49", "name": "[01/15] libipa: awb: Sort class member documentation according to header order", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "30561f4343116071b26f733c338e6d622c5447ba", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22823/mbox/", "series": [ { "id": 5012, "url": "https://patchwork.libcamera.org/api/1.1/series/5012/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5012", "date": "2025-02-23T23:03:48", "name": "libipa: awb: Drive-by fixes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5012/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22823/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22823/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9FF68BDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 23 Feb 2025 23:04:30 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E1E5B686B8;\n\tMon, 24 Feb 2025 00:04:25 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AB4E7686B0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 24 Feb 2025 00:04:21 +0100 (CET)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9640082A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 24 Feb 2025 00:02:55 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tRTPdqnB\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1740351775;\n\tbh=ETHThAktD8mvvHaz+Ln0zlq0SC/W9i0qqDuzTxEwX78=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=tRTPdqnB+hb/eSxDALSx8/aOXPedWgd0xhjONTc4tfCGZ4EVLNaVaAS1z2t0mjL5o\n\tkvEv/ehOh3RHi8RC3IdFQZz7ewL5cN9ugbWg7o6H4r5BBKsvadDb1emNgF4UJkG9SS\n\tffrz9AyR2vhIH8PkM9ke06JtcyhEAho54AYVcBtk=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH 01/15] libipa: awb: Sort class member documentation according\n\tto header order", "Date": "Mon, 24 Feb 2025 01:03:49 +0200", "Message-ID": "<20250223230403.1226-2-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.45.3", "In-Reply-To": "<20250223230403.1226-1-laurent.pinchart@ideasonboard.com>", "References": "<20250223230403.1226-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Sort the documentation of the class members in the same order as the\nmember declaration in the class definition, as is customary in\nlibcamera.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/libipa/awb.cpp | 58 +++++++++++++++++++++---------------------\n 1 file changed, 29 insertions(+), 29 deletions(-)", "diff": "diff --git a/src/ipa/libipa/awb.cpp b/src/ipa/libipa/awb.cpp\nindex 6157bd436183..2e78a4665509 100644\n--- a/src/ipa/libipa/awb.cpp\n+++ b/src/ipa/libipa/awb.cpp\n@@ -130,35 +130,6 @@ namespace ipa {\n * \\brief Handle the controls supplied in a request\n */\n \n-/**\n- * \\var AwbAlgorithm::controls_\n- * \\brief Controls info map for the controls provided by the algorithm\n- */\n-\n-/**\n- * \\var AwbAlgorithm::modes_\n- * \\brief Map of all configured modes\n- * \\sa AwbAlgorithm::parseModeConfigs\n- */\n-\n-/**\n- * \\class AwbAlgorithm::ModeConfig\n- * \\brief Holds the configuration of a single AWB mode\n- *\n- * Awb modes limit the regulation of the AWB algorithm to a specific range of\n- * colour temperatures.\n- */\n-\n-/**\n- * \\var AwbAlgorithm::ModeConfig::ctLo\n- * \\brief The lowest valid colour temperature of that mode\n- */\n-\n-/**\n- * \\var AwbAlgorithm::ModeConfig::ctHi\n- * \\brief The highest valid colour temperature of that mode\n- */\n-\n /**\n * \\brief Parse the mode configurations from the tuning data\n * \\param[in] tuningData the YamlObject representing the tuning data\n@@ -260,6 +231,35 @@ int AwbAlgorithm::parseModeConfigs(const YamlObject &tuningData,\n \treturn 0;\n }\n \n+/**\n+ * \\class AwbAlgorithm::ModeConfig\n+ * \\brief Holds the configuration of a single AWB mode\n+ *\n+ * Awb modes limit the regulation of the AWB algorithm to a specific range of\n+ * colour temperatures.\n+ */\n+\n+/**\n+ * \\var AwbAlgorithm::ModeConfig::ctLo\n+ * \\brief The lowest valid colour temperature of that mode\n+ */\n+\n+/**\n+ * \\var AwbAlgorithm::ModeConfig::ctHi\n+ * \\brief The highest valid colour temperature of that mode\n+ */\n+\n+/**\n+ * \\var AwbAlgorithm::controls_\n+ * \\brief Controls info map for the controls provided by the algorithm\n+ */\n+\n+/**\n+ * \\var AwbAlgorithm::modes_\n+ * \\brief Map of all configured modes\n+ * \\sa AwbAlgorithm::parseModeConfigs\n+ */\n+\n } /* namespace ipa */\n \n } /* namespace libcamera */\n", "prefixes": [ "01/15" ] }