Patch Detail
Show a patch.
GET /api/1.1/patches/22810/?format=api
{ "id": 22810, "url": "https://patchwork.libcamera.org/api/1.1/patches/22810/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22810/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250218091951.13017-2-stanislaw.gruszka@linux.intel.com>", "date": "2025-02-18T09:19:50", "name": "[v3,1/2] libcamera: v4l2_device: add frame start event helpers", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "38eed9005e1c1564456943a41c09ea3c311e8046", "submitter": { "id": 211, "url": "https://patchwork.libcamera.org/api/1.1/people/211/?format=api", "name": "Stanislaw Gruszka", "email": "stanislaw.gruszka@linux.intel.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22810/mbox/", "series": [ { "id": 5008, "url": "https://patchwork.libcamera.org/api/1.1/series/5008/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5008", "date": "2025-02-18T09:19:49", "name": "libcamera: start frame events changes", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5008/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22810/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22810/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1759FC3220\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 18 Feb 2025 09:20:07 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8E2626868D;\n\tTue, 18 Feb 2025 10:20:06 +0100 (CET)", "from mgamail.intel.com (mgamail.intel.com [192.198.163.15])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1ADC86032B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 18 Feb 2025 10:20:01 +0100 (CET)", "from fmviesa010.fm.intel.com ([10.60.135.150])\n\tby fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n\t18 Feb 2025 01:20:01 -0800", "from sgruszka-mobl.ger.corp.intel.com (HELO localhost)\n\t([10.246.8.237]) by fmviesa010-auth.fm.intel.com with\n\tESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2025 01:19:58 -0800" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=intel.com header.i=@intel.com\n\theader.b=\"lXkRPEqg\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n\td=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n\tt=1739870403; x=1771406403;\n\th=from:to:cc:subject:date:message-id:in-reply-to:\n\treferences:mime-version:content-transfer-encoding;\n\tbh=bV7K+VbTYE28kWMieTanx4R2k3gXPpTQR7bgvSzb37Q=;\n\tb=lXkRPEqgWOiQUOTarhsN+hezr80SlRb5whXOhyUMAUTW9w8DuVew1XKV\n\tfBH/hBfFLZxldHYj8HXDryAEONJqySxwhc9mGdREnZditwWFrjkaa3Wh8\n\tOhyDO3ouXJrET3nzppj+WLF6LuHq+IRqn/NDVf6CN2aiJtpLBi46OujFb\n\tGDXs9GuSPvZude5+iGMfwJ/6KsZAMqt3iXlR3YhFhty0fR6CVM8c4MD2Z\n\tzTn+McUHLjdWsbZd87GMczSNWoKQG58BjVkdCuNSPGXYZzXAF7Aa1aB90\n\t5Fi3cJv8qAZpDU6MZWSVjPrc4zwhQ/AmuRB/wsOTGK3bu2CYRni0gRhZJ A==;", "X-CSE-ConnectionGUID": [ "1sEAZVVmRti3OSwOp6gLNQ==", "S/abroGNRO+CVrY2xUqoOA==" ], "X-CSE-MsgGUID": [ "1VDMTcyCRIiACovkmbaMTA==", "WSumBM2JQf+P6M7Kis3cuA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6700,10204,11348\"; a=\"40692047\"", "E=Sophos;i=\"6.13,295,1732608000\"; d=\"scan'208\";a=\"40692047\"", "E=Sophos;i=\"6.13,295,1732608000\"; d=\"scan'208\";a=\"114855859\"" ], "X-ExtLoop1": "1", "From": "Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tNaushir Patuck <naush@raspberrypi.com>,\n\tSakari Ailus <sakari.ailus@linux.intel.com>,\n\tHans de Goede <hdegoede@redhat.com>", "Subject": "[PATCH v3 1/2] libcamera: v4l2_device: add frame start event helpers", "Date": "Tue, 18 Feb 2025 10:19:50 +0100", "Message-Id": "<20250218091951.13017-2-stanislaw.gruszka@linux.intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20250218091951.13017-1-stanislaw.gruszka@linux.intel.com>", "References": "<20250218091951.13017-1-stanislaw.gruszka@linux.intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add helper to check if frame start event are supported by subdevice.\nSince kernel does not have interface to query supported events\nuse subscribe interface.\n\nAdditionally add helper for checking if the event enabled.\nWill be needed later to proper code flow if enabling the event\nfail for some reason.\n\nSigned-off-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>\n---\n include/libcamera/internal/v4l2_device.h | 2 ++\n src/libcamera/v4l2_device.cpp | 24 ++++++++++++++++++++++++\n 2 files changed, 26 insertions(+)", "diff": "diff --git a/include/libcamera/internal/v4l2_device.h b/include/libcamera/internal/v4l2_device.h\nindex affe52c2..0d807209 100644\n--- a/include/libcamera/internal/v4l2_device.h\n+++ b/include/libcamera/internal/v4l2_device.h\n@@ -45,6 +45,8 @@ public:\n \tconst std::string &deviceNode() const { return deviceNode_; }\n \tstd::string devicePath() const;\n \n+\tbool supportsFrameStartEvent();\n+\tbool frameStartEnabled() { return frameStartEnabled_; }\n \tint setFrameStartEnabled(bool enable);\n \tSignal<uint32_t> frameStart;\n \ndiff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\nindex 2f65a43a..219c82f6 100644\n--- a/src/libcamera/v4l2_device.cpp\n+++ b/src/libcamera/v4l2_device.cpp\n@@ -449,6 +449,30 @@ std::string V4L2Device::devicePath() const\n \treturn path;\n }\n \n+/**\n+ * \\brief Check if frame start event is supported\n+ * \\return True if frame start event is supported, false otherwise\n+ */\n+\n+bool V4L2Device::supportsFrameStartEvent()\n+{\n+\tstruct v4l2_event_subscription event {\n+\t};\n+\tevent.type = V4L2_EVENT_FRAME_SYNC;\n+\n+\tint ret = ioctl(VIDIOC_SUBSCRIBE_EVENT, &event);\n+\tif (ret == 0)\n+\t\tioctl(VIDIOC_UNSUBSCRIBE_EVENT, &event);\n+\n+\treturn ret == 0;\n+}\n+\n+/**\n+ * \\fn V4L2Device::frameStartEnabled()\n+ * \\brief Check if frame start event is enabled\n+ * \\return True if frame start event is enabled, false otherwise\n+ */\n+\n /**\n * \\brief Enable or disable frame start event notification\n * \\param[in] enable True to enable frame start events, false to disable them\n", "prefixes": [ "v3", "1/2" ] }