Patch Detail
Show a patch.
GET /api/1.1/patches/22803/?format=api
{ "id": 22803, "url": "https://patchwork.libcamera.org/api/1.1/patches/22803/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22803/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250217185433.306833-4-pobrn@protonmail.com>", "date": "2025-02-17T18:54:49", "name": "[v3,3/8] libcamera: base: log: Remove `LogMessage::init()`", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "018a9c7ec8125b7d1172dd0f3a6183e354af46d7", "submitter": { "id": 133, "url": "https://patchwork.libcamera.org/api/1.1/people/133/?format=api", "name": "Pőcze Barnabás", "email": "pobrn@protonmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22803/mbox/", "series": [ { "id": 5007, "url": "https://patchwork.libcamera.org/api/1.1/series/5007/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5007", "date": "2025-02-17T18:54:35", "name": "libcamera: base: log: Misc. changes", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5007/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22803/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22803/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 07163C3200\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 17 Feb 2025 18:54:56 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 76B8F6868D;\n\tMon, 17 Feb 2025 19:54:55 +0100 (CET)", "from mail-4316.protonmail.ch (mail-4316.protonmail.ch\n\t[185.70.43.16])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 331BA68686\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 17 Feb 2025 19:54:54 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"VVT/WXpi\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1739818493; x=1740077693;\n\tbh=5vyz01HE8R9kF9A2i0e63Yfy0LD6JIXY9yK7jfVlbOM=;\n\th=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;\n\tb=VVT/WXpiO7lNSFbquA7Li0StFetS4YQAejJzsnOsVjz6CEIVMrm0w0NMRuq1m2RCQ\n\ttWsZVPLwic3L/Ye1QCJ0Z91x5h6DUH8gcqSo44DnlGeuufnSRW0huQZghTQGtQg0h2\n\tdE4A11XnzIEVPecvOjP/7abDvwQOMg1t8oHNbGmR6EsHxgFSIasAD7/2OdotyOC0fg\n\twiKenSu5WPUdEUDrtn9kO6q1jn6iGcSTB+YOgtMs5p38WR/YvmeLg0swVgD/RLDUCS\n\t/gdjOuIKY3ZgAY6o3OUyZKeIaosz9En8RfXzy36lI5F+l16khf0jyXdQ5ut+L32sKO\n\tTyxghHKfhCwJw==", "Date": "Mon, 17 Feb 2025 18:54:49 +0000", "To": "libcamera-devel@lists.libcamera.org", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>", "Cc": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[PATCH v3 3/8] libcamera: base: log: Remove `LogMessage::init()`", "Message-ID": "<20250217185433.306833-4-pobrn@protonmail.com>", "In-Reply-To": "<20250217185433.306833-1-pobrn@protonmail.com>", "References": "<20250217185433.306833-1-pobrn@protonmail.com>", "Feedback-ID": "20568564:user:proton", "X-Pm-Message-ID": "9e969836c638949c3fed503d512c1490d8dbfebd", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=utf-8", "Content-Transfer-Encoding": "quoted-printable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "It is a short function that can be merged into the constructor with\nessentially no change in observable behaviour, so do that.\n\nSigned-off-by: Barnabás Pőcze <pobrn@protonmail.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/base/log.h | 2 --\n src/libcamera/base/log.cpp | 16 ++++------------\n 2 files changed, 4 insertions(+), 14 deletions(-)", "diff": "diff --git a/include/libcamera/base/log.h b/include/libcamera/base/log.h\nindex 7a101d8ba..66f665905 100644\n--- a/include/libcamera/base/log.h\n+++ b/include/libcamera/base/log.h\n@@ -75,8 +75,6 @@ public:\n private:\n \tLIBCAMERA_DISABLE_COPY_AND_MOVE(LogMessage)\n \n-\tvoid init(const char *fileName, unsigned int line);\n-\n \tstd::ostringstream msgStream_;\n \tconst LogCategory &category_;\n \tLogSeverity severity_;\ndiff --git a/src/libcamera/base/log.cpp b/src/libcamera/base/log.cpp\nindex 3dea1e178..7043be711 100644\n--- a/src/libcamera/base/log.cpp\n+++ b/src/libcamera/base/log.cpp\n@@ -861,19 +861,11 @@ const LogCategory &LogCategory::defaultCategory()\n LogMessage::LogMessage(const char *fileName, unsigned int line,\n \t\t const LogCategory &category, LogSeverity severity,\n \t\t const std::string &prefix)\n-\t: category_(category), severity_(severity), prefix_(prefix)\n+\t: category_(category), severity_(severity),\n+\t timestamp_(utils::clock::now()),\n+\t fileInfo_((std::ostringstream() << utils::basename(fileName) << \":\" << line).str()),\n+\t prefix_(prefix)\n {\n-\tinit(fileName, line);\n-}\n-\n-void LogMessage::init(const char *fileName, unsigned int line)\n-{\n-\t/* Log the timestamp, severity and file information. */\n-\ttimestamp_ = utils::clock::now();\n-\n-\tstd::ostringstream ossFileInfo;\n-\tossFileInfo << utils::basename(fileName) << \":\" << line;\n-\tfileInfo_ = ossFileInfo.str();\n }\n \n LogMessage::~LogMessage()\n", "prefixes": [ "v3", "3/8" ] }