Patch Detail
Show a patch.
GET /api/1.1/patches/22794/?format=api
{ "id": 22794, "url": "https://patchwork.libcamera.org/api/1.1/patches/22794/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22794/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250217100203.297894-9-stefan.klug@ideasonboard.com>", "date": "2025-02-17T10:01:49", "name": "[08/10] ipa: rkisp: awb: Set rgb mean limits to 180", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "49ad638d2f50d4d15f9dba5830d3b9024d964aa3", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22794/mbox/", "series": [ { "id": 5005, "url": "https://patchwork.libcamera.org/api/1.1/series/5005/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5005", "date": "2025-02-17T10:01:41", "name": "Some rkisp1 awb improvements", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5005/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22794/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22794/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EF0C4C327D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 17 Feb 2025 10:02:34 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4336C6867F;\n\tMon, 17 Feb 2025 11:02:34 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 16A0B68676\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 17 Feb 2025 11:02:31 +0100 (CET)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:b47f:e20a:c4c7:ece1])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 68129122C;\n\tMon, 17 Feb 2025 11:01:09 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pJmE7BRe\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1739786469;\n\tbh=UyTYmg3epLgbAw/bGgeu9bXSA40/OfnEkbgBBHJWBP0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=pJmE7BReNn6dvYBt0UcMN0yuD4KzDGcXYtn4oGM23YU5E4dZGx8ruL48H7nDf9Z8/\n\twq/8TgzL+aj5B764aNyMX0D6I3CMjjLThy3vRWRnhTM97kS0BlOYnr5GFzeldYLHk+\n\tCkL70pMQJb5HfwdnSb5tfg0HL975Ru10xtkLkcy8=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH 08/10] ipa: rkisp: awb: Set rgb mean limits to 180", "Date": "Mon, 17 Feb 2025 11:01:49 +0100", "Message-ID": "<20250217100203.297894-9-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20250217100203.297894-1-stefan.klug@ideasonboard.com>", "References": "<20250217100203.297894-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Set the mean limits to 180 to get reasonably good results from the rgb\nestimations. This is only for internal development as there is no code\npath to enable rgb estimations at runtime.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n src/ipa/rkisp1/algorithms/awb.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\nindex 347d38d226b4..12934771c69c 100644\n--- a/src/ipa/rkisp1/algorithms/awb.cpp\n+++ b/src/ipa/rkisp1/algorithms/awb.cpp\n@@ -201,9 +201,9 @@ void Awb::prepare(IPAContext &context, const uint32_t frame,\n \t\t * awb_ref_cr, awb_min_y and awb_ref_cb respectively. The other\n \t\t * values are not used, set them to 0.\n \t\t */\n-\t\tawbConfig->awb_ref_cr = 250;\n-\t\tawbConfig->min_y = 250;\n-\t\tawbConfig->awb_ref_cb = 250;\n+\t\tawbConfig->awb_ref_cr = 180;\n+\t\tawbConfig->min_y = 180;\n+\t\tawbConfig->awb_ref_cb = 180;\n \n \t\tawbConfig->max_y = 0;\n \t\tawbConfig->min_c = 0;\n", "prefixes": [ "08/10" ] }