Patch Detail
Show a patch.
GET /api/1.1/patches/22793/?format=api
{ "id": 22793, "url": "https://patchwork.libcamera.org/api/1.1/patches/22793/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22793/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250217100203.297894-8-stefan.klug@ideasonboard.com>", "date": "2025-02-17T10:01:48", "name": "[07/10] ipa: rkisp1: Damp color temperature regulation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "252451af7e6c79d38626a7dc6e615d09f782a19a", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22793/mbox/", "series": [ { "id": 5005, "url": "https://patchwork.libcamera.org/api/1.1/series/5005/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5005", "date": "2025-02-17T10:01:41", "name": "Some rkisp1 awb improvements", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5005/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22793/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22793/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 47F32C327D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 17 Feb 2025 10:02:33 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0579568674;\n\tMon, 17 Feb 2025 11:02:33 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D165A6866C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 17 Feb 2025 11:02:27 +0100 (CET)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:b47f:e20a:c4c7:ece1])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 89F0A1047;\n\tMon, 17 Feb 2025 11:01:06 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"d4/hMwM7\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1739786466;\n\tbh=Ev7zgdYMk1QUM3ZHUsPzzLl+Q5H2fFyX75+sOBob7fU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=d4/hMwM7uUwJ8C2gdEmsVTNB5xUAP5bAAxp2VS42ORLutQNjzXwzUMW5YptYN/fY5\n\tgiB3y6HqrG8WIE/HjrqrYHBDeC5cSBuB02e9IKj+ARAp9mryS4cdQjF1s17cxO8hXR\n\tDgzT0rNnhuMh3N/iEOOPb09ie8jlfsO3Mc6G1lgM=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH 07/10] ipa: rkisp1: Damp color temperature regulation", "Date": "Mon, 17 Feb 2025 11:01:48 +0100", "Message-ID": "<20250217100203.297894-8-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20250217100203.297894-1-stefan.klug@ideasonboard.com>", "References": "<20250217100203.297894-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Damp the regulation of the color temperature with the same factor as the\ngains. Not damping the color temperature leads to visible flicker, as\nthe CCM changes too much.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n src/ipa/rkisp1/algorithms/awb.cpp | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\nindex 9244a1e64f41..347d38d226b4 100644\n--- a/src/ipa/rkisp1/algorithms/awb.cpp\n+++ b/src/ipa/rkisp1/algorithms/awb.cpp\n@@ -320,8 +320,6 @@ void Awb::process(IPAContext &context,\n \t rgbMeans.b() < kMeanMinThreshold)\n \t\treturn;\n \n-\tactiveState.awb.automatic.temperatureK = estimateCCT(rgbMeans);\n-\n \t/*\n \t * Estimate the red and blue gains to apply in a grey world. The green\n \t * gain is hardcoded to 1.0. Avoid divisions by zero by clamping the\n@@ -343,8 +341,11 @@ void Awb::process(IPAContext &context,\n \n \t/* Filter the values to avoid oscillations. */\n \tdouble speed = 0.2;\n+\tdouble ct = estimateCCT(rgbMeans);\n+\tct = ct * speed + activeState.awb.automatic.temperatureK * (1 - speed);\n \tgains = gains * speed + activeState.awb.automatic.gains * (1 - speed);\n \n+\tactiveState.awb.automatic.temperatureK = static_cast<unsigned int>(ct);\n \tactiveState.awb.automatic.gains = gains;\n \n \tLOG(RkISP1Awb, Debug)\n", "prefixes": [ "07/10" ] }