Patch Detail
Show a patch.
GET /api/1.1/patches/22792/?format=api
{ "id": 22792, "url": "https://patchwork.libcamera.org/api/1.1/patches/22792/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22792/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250217100203.297894-7-stefan.klug@ideasonboard.com>", "date": "2025-02-17T10:01:47", "name": "[06/10] ipa: rkisp1: awb: Use gains from color temperature curve", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "42ff820b8d289a0218f76fd7dff0afdf031335c6", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22792/mbox/", "series": [ { "id": 5005, "url": "https://patchwork.libcamera.org/api/1.1/series/5005/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5005", "date": "2025-02-17T10:01:41", "name": "Some rkisp1 awb improvements", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5005/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22792/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22792/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4B046C327D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 17 Feb 2025 10:02:29 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9393C68676;\n\tMon, 17 Feb 2025 11:02:28 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BFC7B68669\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 17 Feb 2025 11:02:24 +0100 (CET)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:b47f:e20a:c4c7:ece1])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7FC201047;\n\tMon, 17 Feb 2025 11:01:03 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RxL8wcNA\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1739786463;\n\tbh=jG0g7FmqHVXYAk5uPpol5L1i8FG8s83Bz552qvCsgrs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=RxL8wcNAZAfuSelds4WlSGNziGJDtMdgibDYYZLFTs4XIUVHYzW9Jt30M7TWdoOS1\n\t/Jnhdgyx2TwlwpgF1O7kfplCFs34K1TshOyvf8UKEs+S198EnO+8bPWWmwa5tp7JrL\n\tKo+LMNha8nbmSLZE0BqWNM61lVZBSWkQfmlS1KFo=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH 06/10] ipa: rkisp1: awb: Use gains from color temperature\n\tcurve", "Date": "Mon, 17 Feb 2025 11:01:47 +0100", "Message-ID": "<20250217100203.297894-7-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20250217100203.297894-1-stefan.klug@ideasonboard.com>", "References": "<20250217100203.297894-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Use the color gains for white balance if calibrated light sources are\ncontained in the tuning file. The results are generally better\nespecially when large uniformly colored objects are in the scene. Pure\ngrey world model is still available by removing the color gains from the\ntuning file.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n src/ipa/rkisp1/algorithms/awb.cpp | 9 +++++++++\n 1 file changed, 9 insertions(+)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\nindex 683a08c943fa..9244a1e64f41 100644\n--- a/src/ipa/rkisp1/algorithms/awb.cpp\n+++ b/src/ipa/rkisp1/algorithms/awb.cpp\n@@ -159,6 +159,15 @@ void Awb::prepare(IPAContext &context, const uint32_t frame,\n \t\tauto &awb = context.activeState.awb;\n \t\tframeContext.awb.gains = awb.automatic.gains;\n \t\tframeContext.awb.temperatureK = awb.automatic.temperatureK;\n+\t\tif (colourGainCurve_) {\n+\t\t\tconst auto &gains = colourGainCurve_->getInterpolated(\n+\t\t\t\tawb.automatic.temperatureK);\n+\t\t\tframeContext.awb.gains.r() = gains[0];\n+\t\t\tframeContext.awb.gains.g() = 1.0;\n+\t\t\tframeContext.awb.gains.b() = gains[1];\n+\t\t} else {\n+\t\t\tframeContext.awb.gains = awb.automatic.gains;\n+\t\t}\n \t}\n \n \tauto gainConfig = params->block<BlockType::AwbGain>();\n", "prefixes": [ "06/10" ] }