Patch Detail
Show a patch.
GET /api/1.1/patches/22780/?format=api
{ "id": 22780, "url": "https://patchwork.libcamera.org/api/1.1/patches/22780/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22780/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250213193635.114097-1-stefan.klug@ideasonboard.com>", "date": "2025-02-13T19:35:56", "name": "ipa: rkisp1: algorithms: awb: Fix AWB means vector order in RGB mode", "commit_ref": "d4545edb38e2e58d4231fe83f61d766ca2b730fc", "pull_url": null, "state": "accepted", "archived": false, "hash": "b19d82172391dfbf43a4e300d012185c3f70df94", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22780/mbox/", "series": [ { "id": 5002, "url": "https://patchwork.libcamera.org/api/1.1/series/5002/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5002", "date": "2025-02-13T19:35:56", "name": "ipa: rkisp1: algorithms: awb: Fix AWB means vector order in RGB mode", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5002/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22780/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22780/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 17775C3272\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 13 Feb 2025 19:36:44 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2B44468639;\n\tThu, 13 Feb 2025 20:36:43 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 17B936185F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 13 Feb 2025 20:36:41 +0100 (CET)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:cb40:22fb:439f:306b])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4C3ED6AF;\n\tThu, 13 Feb 2025 20:35:22 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DOm2Mftq\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1739475322;\n\tbh=w5vp/zv4lL8pW5FHqRLxef9biB6EV4W3RPB/Xwub3gs=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=DOm2Mftq3x8Y69IWvHoWk2az23QpcwZCGGtyF6pIwjIDwjL5cgF1KGhEFstA7rFif\n\tSSjkLBh9mnOrOvJS4mIqjnaKYCi/aaewriYV3jttGGkve6w+rtKbaPJ+/nR0JLN7Ng\n\tKoUJxhUdBDb6yynBpdbhARvS1RkjQgbejQsVJ9L0=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH] ipa: rkisp1: algorithms: awb: Fix AWB means vector order in\n\tRGB mode", "Date": "Thu, 13 Feb 2025 20:35:56 +0100", "Message-ID": "<20250213193635.114097-1-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Fix the order of the rgbMeans vector that got broken accidentally\nduring refactoring. As there is currently no way to enable rgb mode at\nruntime it went unnoticed.\n\nFixes: 29892f1c56c6 (\"ipa: libipa: colour: Use the RGB class to model RGB values\")\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n src/ipa/rkisp1/algorithms/awb.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\nindex cffaa06a22c1..16e829469313 100644\n--- a/src/ipa/rkisp1/algorithms/awb.cpp\n+++ b/src/ipa/rkisp1/algorithms/awb.cpp\n@@ -245,8 +245,8 @@ void Awb::process(IPAContext &context,\n \n \tif (rgbMode_) {\n \t\trgbMeans = {{\n-\t\t\tstatic_cast<double>(awb->awb_mean[0].mean_y_or_g),\n \t\t\tstatic_cast<double>(awb->awb_mean[0].mean_cr_or_r),\n+\t\t\tstatic_cast<double>(awb->awb_mean[0].mean_y_or_g),\n \t\t\tstatic_cast<double>(awb->awb_mean[0].mean_cb_or_b)\n \t\t}};\n \t} else {\n", "prefixes": [] }