Patch Detail
Show a patch.
GET /api/1.1/patches/2278/?format=api
{ "id": 2278, "url": "https://patchwork.libcamera.org/api/1.1/patches/2278/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2278/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20191028104913.14985-6-laurent.pinchart@ideasonboard.com>", "date": "2019-10-28T10:49:09", "name": "[libcamera-devel,v2,5/9] libcamera: signal: Specify connection type for signals", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "9db5350637e6c4d6984ffb86f804474a0da62230", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2278/mbox/", "series": [ { "id": 562, "url": "https://patchwork.libcamera.org/api/1.1/series/562/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=562", "date": "2019-10-28T10:49:04", "name": "Add support for blocking method invocation", "version": 2, "mbox": "https://patchwork.libcamera.org/series/562/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2278/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2278/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 96C3760C14\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 28 Oct 2019 11:49:26 +0100 (CET)", "from pendragon.ideasonboard.com (unknown [91.217.168.176])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4C01B9C2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 28 Oct 2019 11:49:26 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1572259766;\n\tbh=dhSMSoGff5nMEeAkkqC736uZ5lQgBGNG5b33Ev5fQC8=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=e6FNA0zTSfFL/mf8014iZNNAf99Do8QzQqK5b8mO3RN/juz1BzSEHN/I1EslA+FnO\n\tIPRoxeCYVNcZj2HOUV+HjPRtJGLigVsZlJBctEuF2ocxeU8lobeqjvllJpR69+DEP4\n\tHNlmmPMLQmHlP2/Uk5cxxIl17Z33W1YqWt+zZjOI=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 28 Oct 2019 12:49:09 +0200", "Message-Id": "<20191028104913.14985-6-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.23.0", "In-Reply-To": "<20191028104913.14985-1-laurent.pinchart@ideasonboard.com>", "References": "<20191028104913.14985-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 5/9] libcamera: signal: Specify\n\tconnection type for signals", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 28 Oct 2019 10:49:28 -0000" }, "content": "Add a connection type parameter to the Signal::connect() method to\ncontrol signal delivery.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/signal.h | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/include/libcamera/signal.h b/include/libcamera/signal.h\nindex b8a60281cceb..57598335932c 100644\n--- a/include/libcamera/signal.h\n+++ b/include/libcamera/signal.h\n@@ -55,11 +55,12 @@ public:\n \n #ifndef __DOXYGEN__\n \ttemplate<typename T, typename std::enable_if<std::is_base_of<Object, T>::value>::type * = nullptr>\n-\tvoid connect(T *obj, void (T::*func)(Args...))\n+\tvoid connect(T *obj, void (T::*func)(Args...),\n+\t\t ConnectionType type = ConnectionTypeAuto)\n \t{\n \t\tObject *object = static_cast<Object *>(obj);\n \t\tobject->connect(this);\n-\t\tslots_.push_back(new BoundMemberMethod<T, Args...>(obj, object, func));\n+\t\tslots_.push_back(new BoundMemberMethod<T, Args...>(obj, object, func, type));\n \t}\n \n \ttemplate<typename T, typename std::enable_if<!std::is_base_of<Object, T>::value>::type * = nullptr>\n", "prefixes": [ "libcamera-devel", "v2", "5/9" ] }