Patch Detail
Show a patch.
GET /api/1.1/patches/22700/?format=api
{ "id": 22700, "url": "https://patchwork.libcamera.org/api/1.1/patches/22700/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22700/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250130181449.130492-4-mzamazal@redhat.com>", "date": "2025-01-30T18:14:40", "name": "[v5,03/10] libcamera: software_isp: Store color temperature to metadata", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "70628c6a4b2ae2f09ff25a870e4c12c8aeb9ef4f", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/1.1/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22700/mbox/", "series": [ { "id": 4980, "url": "https://patchwork.libcamera.org/api/1.1/series/4980/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4980", "date": "2025-01-30T18:14:37", "name": "Software ISP support for CCM", "version": 5, "mbox": "https://patchwork.libcamera.org/series/4980/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22700/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22700/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4DECDBD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 30 Jan 2025 18:15:18 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E8D6D6856B;\n\tThu, 30 Jan 2025 19:15:17 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0F01968563\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Jan 2025 19:15:14 +0100 (CET)", "from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-385-L5WREN9zOouBWS11GXVwhQ-1;\n\tThu, 30 Jan 2025 13:15:13 -0500", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id F06551956080; Thu, 30 Jan 2025 18:15:11 +0000 (UTC)", "from mzamazal-thinkpadp1gen3.tpbc.com (unknown [10.45.224.122])\n\tby mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 8D83030001BE; Thu, 30 Jan 2025 18:15:08 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"BFzKRlYE\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1738260914;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=/QBcXAshcrvITUbPujFkDBbAYCS2Kj+xoozsRVmnOQo=;\n\tb=BFzKRlYEav5Fb8+fKsO/PSQFmD97byQRKCFRtRCtO/ZYYkkqmN8PjLZgLmGVVq64vWwzeq\n\tyXCMNVcQyR16CXDjHiVs9SPrdzVIpjzU3ZMsKnbGYwxISiOEwBZTMuMVkSkkLtm5PQoCVT\n\tX2i3pvtMTEqRn/kxiulnqNq+m8y/+0A=", "X-MC-Unique": "L5WREN9zOouBWS11GXVwhQ-1", "X-Mimecast-MFC-AGG-ID": "L5WREN9zOouBWS11GXVwhQ", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tRobert Mader <robert.mader@collabora.com>,\n\tHans de Goede <hdegoede@redhat.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v5 03/10] libcamera: software_isp: Store color temperature to\n\tmetadata", "Date": "Thu, 30 Jan 2025 19:14:40 +0100", "Message-ID": "<20250130181449.130492-4-mzamazal@redhat.com>", "In-Reply-To": "<20250130181449.130492-1-mzamazal@redhat.com>", "References": "<20250130181449.130492-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "gKNRZ9GajyXNNckcyw-lSjMYTIAVNqmf6tnQi4Q8buE_1738260912", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Image color temperature is a piece of information that should be\nreported in metadata, let's put it there.\n\nMetadata is currently not reported in simple pipeline but we should make\nat least newly added information ready to be reported.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/simple/algorithms/awb.cpp | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/simple/algorithms/awb.cpp b/src/ipa/simple/algorithms/awb.cpp\nindex 9c85b3f8..b4151670 100644\n--- a/src/ipa/simple/algorithms/awb.cpp\n+++ b/src/ipa/simple/algorithms/awb.cpp\n@@ -12,6 +12,8 @@\n \n #include <libcamera/base/log.h>\n \n+#include <libcamera/control_ids.h>\n+\n #include \"libipa/colours.h\"\n #include \"simple/ipa_context.h\"\n \n@@ -34,7 +36,7 @@ void Awb::process(IPAContext &context,\n \t\t [[maybe_unused]] const uint32_t frame,\n \t\t [[maybe_unused]] IPAFrameContext &frameContext,\n \t\t const SwIspStats *stats,\n-\t\t [[maybe_unused]] ControlList &metadata)\n+\t\t ControlList &metadata)\n {\n \tconst SwIspStats::Histogram &histogram = stats->yHistogram;\n \tconst uint8_t blackLevel = context.activeState.blc.level;\n@@ -64,6 +66,7 @@ void Awb::process(IPAContext &context,\n \n \tRGB<double> rgbGains{ { 1 / gains.r(), 1 / gains.g(), 1 / gains.b() } };\n \tcontext.activeState.awb.temperatureK = estimateCCT(rgbGains);\n+\tmetadata.set(controls::ColourTemperature, context.activeState.awb.temperatureK);\n \n \tLOG(IPASoftAwb, Debug)\n \t\t<< \"gain R/B: \" << gains.r() << \"/\" << gains.b()\n", "prefixes": [ "v5", "03/10" ] }