Patch Detail
Show a patch.
GET /api/1.1/patches/22693/?format=api
{ "id": 22693, "url": "https://patchwork.libcamera.org/api/1.1/patches/22693/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22693/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250130173254.112895-4-mzamazal@redhat.com>", "date": "2025-01-30T17:32:50", "name": "[v4,3/6] ipa: simple: Report the ColourGains in metadata", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "129e44cd3ce06d8d821174423f8661abf50412cc", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/1.1/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22693/mbox/", "series": [ { "id": 4979, "url": "https://patchwork.libcamera.org/api/1.1/series/4979/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4979", "date": "2025-01-30T17:32:47", "name": "ipa: simple: Introduce metadata reporting", "version": 4, "mbox": "https://patchwork.libcamera.org/series/4979/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22693/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22693/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B71EBC324C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 30 Jan 2025 17:33:16 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4A5B36856B;\n\tThu, 30 Jan 2025 18:33:16 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 96D5B6851B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Jan 2025 18:33:11 +0100 (CET)", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-158-CqTav2mpMn-_LpOa1djgDA-1;\n\tThu, 30 Jan 2025 12:33:09 -0500", "from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.15])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id E45AA1801F1F; Thu, 30 Jan 2025 17:33:07 +0000 (UTC)", "from mzamazal-thinkpadp1gen3.tpbc.com (unknown [10.45.224.122])\n\tby mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 192001956094; Thu, 30 Jan 2025 17:33:05 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"QhWoSaH7\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1738258390;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=H65FlS9UoNSiJcLrYf2GTy7oyK2WGvU+zKYtaQMlPgw=;\n\tb=QhWoSaH7enfzi00mrNs6PxnthTvEf+L4QTp8rm5j12CbYhNLD75/I26wJoTVOlHrZ5XvDa\n\tM1boiHKPTAeQSxyOsBq1P4gPw2Gt3/5tuXz+H4KUDKim6rRaFXNre+o/dR9Dqg1hmgVD2X\n\t55YVFR7esnVQk8VIIiTGlqbgwzpQ7JQ=", "X-MC-Unique": "CqTav2mpMn-_LpOa1djgDA-1", "X-Mimecast-MFC-AGG-ID": "CqTav2mpMn-_LpOa1djgDA", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Kieran Bingham <kieran.bingham@ideasonboard.com>, Laurent Pinchart\n\t<laurent.pinchart@ideasonboard.com>, =?utf-8?b?QmFybmFiw6FzIFDFkWN6?=\n\t=?utf-8?q?e?= <pobrn@protonmail.com>,\n\tMilan Zamazal <mzamazal@redhat.com>", "Subject": "[PATCH v4 3/6] ipa: simple: Report the ColourGains in metadata", "Date": "Thu, 30 Jan 2025 18:32:50 +0100", "Message-ID": "<20250130173254.112895-4-mzamazal@redhat.com>", "In-Reply-To": "<20250130173254.112895-1-mzamazal@redhat.com>", "References": "<20250130173254.112895-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.15", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "9te4f1KAtozlbw63YdLwWoHNDchdqMDRieYgf0LV2t4_1738258388", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nProvide the determined colour gains back into the metadata\nto add to completed requests.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/ipa/simple/algorithms/awb.cpp | 23 +++++++++++++++++++++--\n src/ipa/simple/algorithms/awb.h | 6 +++++-\n src/ipa/simple/ipa_context.h | 4 ++++\n 3 files changed, 30 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/ipa/simple/algorithms/awb.cpp b/src/ipa/simple/algorithms/awb.cpp\nindex 195de41d..3b4146f1 100644\n--- a/src/ipa/simple/algorithms/awb.cpp\n+++ b/src/ipa/simple/algorithms/awb.cpp\n@@ -14,6 +14,8 @@\n \n #include \"simple/ipa_context.h\"\n \n+#include \"control_ids.h\"\n+\n namespace libcamera {\n \n LOG_DEFINE_CATEGORY(IPASoftAwb)\n@@ -29,15 +31,32 @@ int Awb::configure(IPAContext &context,\n \treturn 0;\n }\n \n+void Awb::prepare(IPAContext &context,\n+\t\t [[maybe_unused]] const uint32_t frame,\n+\t\t IPAFrameContext &frameContext,\n+\t\t [[maybe_unused]] DebayerParams *params)\n+{\n+\tauto &gains = context.activeState.gains;\n+\tframeContext.gains.red = gains.red;\n+\tframeContext.gains.blue = gains.blue;\n+}\n+\n void Awb::process(IPAContext &context,\n \t\t [[maybe_unused]] const uint32_t frame,\n-\t\t [[maybe_unused]] IPAFrameContext &frameContext,\n+\t\t IPAFrameContext &frameContext,\n \t\t const SwIspStats *stats,\n-\t\t [[maybe_unused]] ControlList &metadata)\n+\t\t ControlList &metadata)\n {\n \tconst SwIspStats::Histogram &histogram = stats->yHistogram;\n \tconst uint8_t blackLevel = context.activeState.blc.level;\n \n+\tconst float maxGain = 1024.0;\n+\tconst float mdGains[] = {\n+\t\tstatic_cast<float>(frameContext.gains.red / maxGain),\n+\t\tstatic_cast<float>(frameContext.gains.blue / maxGain)\n+\t};\n+\tmetadata.set(controls::ColourGains, mdGains);\n+\n \t/*\n \t * Black level must be subtracted to get the correct AWB ratios, they\n \t * would be off if they were computed from the whole brightness range\ndiff --git a/src/ipa/simple/algorithms/awb.h b/src/ipa/simple/algorithms/awb.h\nindex db1496cd..ad993f39 100644\n--- a/src/ipa/simple/algorithms/awb.h\n+++ b/src/ipa/simple/algorithms/awb.h\n@@ -1,6 +1,6 @@\n /* SPDX-License-Identifier: LGPL-2.1-or-later */\n /*\n- * Copyright (C) 2024, Red Hat Inc.\n+ * Copyright (C) 2024-2025 Red Hat Inc.\n *\n * Auto white balance\n */\n@@ -20,6 +20,10 @@ public:\n \t~Awb() = default;\n \n \tint configure(IPAContext &context, const IPAConfigInfo &configInfo) override;\n+\tvoid prepare(IPAContext &context,\n+\t\t const uint32_t frame,\n+\t\t IPAFrameContext &frameContext,\n+\t\t DebayerParams *params) override;\n \tvoid process(IPAContext &context,\n \t\t const uint32_t frame,\n \t\t IPAFrameContext &frameContext,\ndiff --git a/src/ipa/simple/ipa_context.h b/src/ipa/simple/ipa_context.h\nindex 4af51306..99cb6284 100644\n--- a/src/ipa/simple/ipa_context.h\n+++ b/src/ipa/simple/ipa_context.h\n@@ -58,6 +58,10 @@ struct IPAFrameContext : public FrameContext {\n \t\tint32_t exposure;\n \t\tdouble gain;\n \t} sensor;\n+\tstruct {\n+\t\tdouble red;\n+\t\tdouble blue;\n+\t} gains;\n };\n \n struct IPAContext {\n", "prefixes": [ "v4", "3/6" ] }