Patch Detail
Show a patch.
GET /api/1.1/patches/22666/?format=api
{ "id": 22666, "url": "https://patchwork.libcamera.org/api/1.1/patches/22666/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22666/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250130115001.1129305-9-pobrn@protonmail.com>", "date": "2025-01-30T11:50:41", "name": "[RFC,v3,08/21] apps: lc-compliance: Initialize `CameraManager` pointer in `Environment`", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d249066b0c87b722871e3bcc3a3b0dcf89afc54b", "submitter": { "id": 133, "url": "https://patchwork.libcamera.org/api/1.1/people/133/?format=api", "name": "Pőcze Barnabás", "email": "pobrn@protonmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22666/mbox/", "series": [ { "id": 4978, "url": "https://patchwork.libcamera.org/api/1.1/series/4978/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4978", "date": "2025-01-30T11:50:08", "name": "apps: lc-compliance: Multi-stream tests", "version": 3, "mbox": "https://patchwork.libcamera.org/series/4978/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22666/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22666/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8A4DCBDB1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 30 Jan 2025 11:50:47 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4399468572;\n\tThu, 30 Jan 2025 12:50:47 +0100 (CET)", "from mail-4316.protonmail.ch (mail-4316.protonmail.ch\n\t[185.70.43.16])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 949E668567\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Jan 2025 12:50:45 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"dYOzcUev\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1738237845; x=1738497045;\n\tbh=R7Tvb3Pgt2ZSiGu7mNV++YGEpaunk8MMtii+BXPKm94=;\n\th=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;\n\tb=dYOzcUevClddQj49UxePzDCAjdkeyGR6CVBN64NBt2TcMvOJsxt6e7NO21fTvNf3f\n\tAGfM3AYyW2pmRhKhcvTmwhJ5mTLUDxpsNWszWoZmrxGKRLOkCjWtWC96uSXxpdrTky\n\tMLC+tmVUA6UuShldZxJJL9tb5xbtElqSuLsRgAzJoipN992l2IPQcq2qKr0msC5zOl\n\trUvUP4x1225hmQ/yvvk5rfhqJ2blVxoktd8sGXU7MB87bAPMcOK+oSy99CwUJhfOSk\n\tIFU56z2fyWUsp20HrnLyKA6wEabqtjSxxsmzMtGW70CutGur2Ww1fSVz4dzaVdgs0m\n\tmfIiJ2zORszeg==", "Date": "Thu, 30 Jan 2025 11:50:41 +0000", "To": "libcamera-devel@lists.libcamera.org", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tPaul Elder <paul.elder@ideasonboard.com>", "Subject": "[RFC PATCH v3 08/21] apps: lc-compliance: Initialize `CameraManager`\n\tpointer in `Environment`", "Message-ID": "<20250130115001.1129305-9-pobrn@protonmail.com>", "In-Reply-To": "<20250130115001.1129305-1-pobrn@protonmail.com>", "References": "<20250130115001.1129305-1-pobrn@protonmail.com>", "Feedback-ID": "20568564:user:proton", "X-Pm-Message-ID": "b2cc7084a97c5f4ce227fb0d930023f468afcd33", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=utf-8", "Content-Transfer-Encoding": "quoted-printable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Do not leave it unitialized.\n\nSigned-off-by: Barnabás Pőcze <pobrn@protonmail.com>\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n src/apps/lc-compliance/environment.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/apps/lc-compliance/environment.h b/src/apps/lc-compliance/environment.h\nindex 543e5372f..834c722ef 100644\n--- a/src/apps/lc-compliance/environment.h\n+++ b/src/apps/lc-compliance/environment.h\n@@ -23,5 +23,5 @@ private:\n \tEnvironment() = default;\n \n \tstd::string cameraId_;\n-\tlibcamera::CameraManager *cm_;\n+\tlibcamera::CameraManager *cm_ = nullptr;\n };\n", "prefixes": [ "RFC", "v3", "08/21" ] }