Patch Detail
Show a patch.
GET /api/1.1/patches/22651/?format=api
{ "id": 22651, "url": "https://patchwork.libcamera.org/api/1.1/patches/22651/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22651/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250124215806.158024-13-mzamazal@redhat.com>", "date": "2025-01-24T21:58:03", "name": "[RFC,v2,12/13] apps: ppm_writer: Return EIO on I/O errors", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "118392d95283c3dc2fa463f0a00da56aecce3d7d", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/1.1/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22651/mbox/", "series": [ { "id": 4970, "url": "https://patchwork.libcamera.org/api/1.1/series/4970/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4970", "date": "2025-01-24T21:57:51", "name": "Enable raw streams with software ISP", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4970/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22651/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22651/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D8474BD78E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 24 Jan 2025 21:59:00 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 672356857B;\n\tFri, 24 Jan 2025 22:59:00 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1DF6C68573\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Jan 2025 22:58:51 +0100 (CET)", "from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-472-bGPOFFHZMAWCd3c98dZ3Jg-1;\n\tFri, 24 Jan 2025 16:58:48 -0500", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.111])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS\n\tid ACC67180034D for <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Jan 2025 21:58:47 +0000 (UTC)", "from mzamazal-thinkpadp1gen3.tpbc.com (unknown [10.39.192.49])\n\tby mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 9A5071800344; Fri, 24 Jan 2025 21:58:46 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"WP1GZGJ2\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1737755930;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=Oup9EkCW8txjzvZhDFrT3P7CbR8CfzPHfc31GtirLO8=;\n\tb=WP1GZGJ2jdaKQxBKIC4Vp4oBOAXCTLXy4WU/CJBSqCbKd93kLJ63zVbt4NwlvPj4xX9E1y\n\tnmpgtc5IhbE7Qux86e822njTl2dZFoOc06Ic6DSbhdG2kQHxpPO3IPsUgsqv/YNzP65Lj+\n\ts7rH8XjJw4JDjnZtdj5+2fx1+ihWPcI=", "X-MC-Unique": "bGPOFFHZMAWCd3c98dZ3Jg-1", "X-Mimecast-MFC-AGG-ID": "bGPOFFHZMAWCd3c98dZ3Jg", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>", "Subject": "[RFC PATCH v2 12/13] apps: ppm_writer: Return EIO on I/O errors", "Date": "Fri, 24 Jan 2025 22:58:03 +0100", "Message-ID": "<20250124215806.158024-13-mzamazal@redhat.com>", "In-Reply-To": "<20250124215806.158024-1-mzamazal@redhat.com>", "References": "<20250124215806.158024-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "kFnXOlazXIKGSyPENYrHwd5bKY1YwQgEVWo_Xt-JKqg_1737755927", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "EINVAL should be returned only when the requested format is unsupported.\nOn errors when writing the data, let's return EIO, which is the closest\ndescription of the situation when we don't inspect it more.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/apps/common/ppm_writer.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/apps/common/ppm_writer.cpp b/src/apps/common/ppm_writer.cpp\nindex 2e9378aa..368de8bf 100644\n--- a/src/apps/common/ppm_writer.cpp\n+++ b/src/apps/common/ppm_writer.cpp\n@@ -29,7 +29,7 @@ int PPMWriter::write(const char *filename,\n \tstd::ofstream output(filename, std::ios::binary);\n \tif (!output) {\n \t\tstd::cerr << \"Failed to open ppm file: \" << filename << std::endl;\n-\t\treturn -EINVAL;\n+\t\treturn -EIO;\n \t}\n \n \toutput << \"P6\" << std::endl\n@@ -37,7 +37,7 @@ int PPMWriter::write(const char *filename,\n \t << \"255\" << std::endl;\n \tif (!output) {\n \t\tstd::cerr << \"Failed to write the file header\" << std::endl;\n-\t\treturn -EINVAL;\n+\t\treturn -EIO;\n \t}\n \n \tconst unsigned int rowLength = config.size.width * 3;\n@@ -46,7 +46,7 @@ int PPMWriter::write(const char *filename,\n \t\toutput.write(row, rowLength);\n \t\tif (!output) {\n \t\t\tstd::cerr << \"Failed to write image data at row \" << y << std::endl;\n-\t\t\treturn -EINVAL;\n+\t\t\treturn -EIO;\n \t\t}\n \t}\n \n", "prefixes": [ "RFC", "v2", "12/13" ] }