Patch Detail
Show a patch.
GET /api/1.1/patches/22648/?format=api
{ "id": 22648, "url": "https://patchwork.libcamera.org/api/1.1/patches/22648/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22648/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250124215806.158024-10-mzamazal@redhat.com>", "date": "2025-01-24T21:58:00", "name": "[RFC,v2,09/13] libcamera: simple: Don't use conversion with an added raw stream", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "82524b17f01f93c475910b3cf719fbaad6218d7c", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/1.1/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22648/mbox/", "series": [ { "id": 4970, "url": "https://patchwork.libcamera.org/api/1.1/series/4970/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4970", "date": "2025-01-24T21:57:51", "name": "Enable raw streams with software ISP", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4970/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22648/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22648/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 19BEFC3317\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 24 Jan 2025 21:58:54 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 82FCE6856F;\n\tFri, 24 Jan 2025 22:58:53 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8B26968560\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Jan 2025 22:58:45 +0100 (CET)", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-307-qVfvcLaVOLyb-yZ6VZMEmA-1;\n\tFri, 24 Jan 2025 16:58:43 -0500", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.111])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS\n\tid 6E0971801F14 for <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Jan 2025 21:58:42 +0000 (UTC)", "from mzamazal-thinkpadp1gen3.tpbc.com (unknown [10.39.192.49])\n\tby mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 317DA1800344; Fri, 24 Jan 2025 21:58:40 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"eC1lZ65V\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1737755924;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=zuI3BxRYUL0cX+3pihOg5wk5W8vNyJc2b3IfyyVC/vY=;\n\tb=eC1lZ65V8Y5ZfRZVxgdO7raUQc9CL7jXgVw0Fzt772wMBxZNcFBhqNA2HINWarMX6PINE1\n\taDBq2L24OAORY/6sg9dIYRhMJj5Bpsa3m8Yn++lJ/FDPDblZJWla575lOtb6jnqG+2XYG7\n\tngyAMQ8VDnpogFiFCOXS7YKeaGb9Ce0=", "X-MC-Unique": "qVfvcLaVOLyb-yZ6VZMEmA-1", "X-Mimecast-MFC-AGG-ID": "qVfvcLaVOLyb-yZ6VZMEmA", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>", "Subject": "[RFC PATCH v2 09/13] libcamera: simple: Don't use conversion with an\n\tadded raw stream", "Date": "Fri, 24 Jan 2025 22:58:00 +0100", "Message-ID": "<20250124215806.158024-10-mzamazal@redhat.com>", "In-Reply-To": "<20250124215806.158024-1-mzamazal@redhat.com>", "References": "<20250124215806.158024-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "7U2dKJt7N08gZ6GPJ2DuRE3wVYK_3MqZ053Cwd7uBeo_1737755922", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When a raw stream is requested, either alone or together with a\nprocessed stream, it can be produced without conversion. Let's amend\nthe corresponding check on the number of configurations accordingly.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/libcamera/pipeline/simple/simple.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex beb11069..edf08666 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -1135,7 +1135,7 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate()\n \t * require any conversion, similar to raw capture use cases). This is\n \t * left as a future improvement.\n \t */\n-\tneedConversion_ = config_.size() > 1;\n+\tneedConversion_ = config_.size() > 1 + (data_->rawRequested_ ? 1 : 0);\n \n \tfor (unsigned int i = 0; i < config_.size(); ++i) {\n \t\tStreamConfiguration &cfg = config_[i];\n", "prefixes": [ "RFC", "v2", "09/13" ] }