Patch Detail
Show a patch.
GET /api/1.1/patches/22641/?format=api
{ "id": 22641, "url": "https://patchwork.libcamera.org/api/1.1/patches/22641/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22641/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250124215806.158024-3-mzamazal@redhat.com>", "date": "2025-01-24T21:57:53", "name": "[RFC,v2,02/13] libcamera: simple: Increase the default number of streams to 2", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "82e76dd8f5340b09eda1677cbf3cfb22cce3ed5a", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/1.1/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22641/mbox/", "series": [ { "id": 4970, "url": "https://patchwork.libcamera.org/api/1.1/series/4970/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4970", "date": "2025-01-24T21:57:51", "name": "Enable raw streams with software ISP", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4970/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22641/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22641/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C4FCCBD78E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 24 Jan 2025 21:58:37 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 44A8368564;\n\tFri, 24 Jan 2025 22:58:37 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6306068559\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Jan 2025 22:58:33 +0100 (CET)", "from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-379-aKVJsm59M_ii3TYh1DTD2A-1;\n\tFri, 24 Jan 2025 16:58:30 -0500", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.111])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS\n\tid D94DF180034F for <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Jan 2025 21:58:29 +0000 (UTC)", "from mzamazal-thinkpadp1gen3.tpbc.com (unknown [10.39.192.49])\n\tby mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id BF5E21800348; Fri, 24 Jan 2025 21:58:28 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"AdqlTcgz\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1737755912;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=WGX6GD2cAr9nlaG+lwkbVwl+BBa/f+38muiF3/p/ftI=;\n\tb=AdqlTcgzmxM+2WADrUxZMbNg5JjXGiUGTJ8HH+FWqLKirvOJGjhiU/kEIRPHyh3gvg5EmO\n\tx/BaStVX04KXuOirfwzi23w7SLNGwcITBQXchQqk5qaawIJ6HTqXGNdDkJu9Tg/RZRRx2N\n\toTHr075/qgu9yaLBbayn4nNT53rFAVU=", "X-MC-Unique": "aKVJsm59M_ii3TYh1DTD2A-1", "X-Mimecast-MFC-AGG-ID": "aKVJsm59M_ii3TYh1DTD2A", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>", "Subject": "[RFC PATCH v2 02/13] libcamera: simple: Increase the default number\n\tof streams to 2", "Date": "Fri, 24 Jan 2025 22:57:53 +0100", "Message-ID": "<20250124215806.158024-3-mzamazal@redhat.com>", "In-Reply-To": "<20250124215806.158024-1-mzamazal@redhat.com>", "References": "<20250124215806.158024-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "NOBTBfJCurXe-oLoRA4vMteTAxMS5DfLw5gu42RR5_E_1737755910", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In order to allow providing a raw stream together with a processed\nstream, we need two streams. If only one stream is eventually\nrequested, it doesn't harm to allocate two.\n\nThis is a hack for the lack of a better easy option. The number of\nstreams is determined as a camera property in the pipeline matching.\nThe actual number of streams needed (one or two) is determined only when\nexamining roles in SimplePipelineHandler::generateConfiguration.\n\nIt's not obvious what to do better about the number of the streams. It\nseems that hardware pipelines utilize separate hardware streams while\nwith software ISP we have only a single input for multiple outputs. A\nfixed number of streams also doesn't scale but is good enough for our\ncurrent use case, which is supporting a single processed + a single raw\nstream, not more.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/libcamera/pipeline/simple/simple.cpp | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 8ac24e6e..6e9bc630 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -1549,7 +1549,12 @@ int SimplePipelineHandler::resetRoutingTable(V4L2Subdevice *subdev)\n bool SimplePipelineHandler::match(DeviceEnumerator *enumerator)\n {\n \tconst SimplePipelineInfo *info = nullptr;\n-\tunsigned int numStreams = 1;\n+\t/*\n+\t * Let's allocate two streams, for processed + raw streams.\n+\t * It's OK if there is only a single stream.\n+\t * TODO: This should be more flexible.\n+\t */\n+\tunsigned int numStreams = 2;\n \tMediaDevice *media;\n \n \tfor (const SimplePipelineInfo &inf : supportedDevices) {\n", "prefixes": [ "RFC", "v2", "02/13" ] }