Patch Detail
Show a patch.
GET /api/1.1/patches/22598/?format=api
{ "id": 22598, "url": "https://patchwork.libcamera.org/api/1.1/patches/22598/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22598/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250120204515.24096-12-laurent.pinchart@ideasonboard.com>", "date": "2025-01-20T20:45:02", "name": "[v9,11/12] ipa: rkisp1: agc: Report new AeEnable control as available", "commit_ref": "338ba00e7abfe8edfa169b6cb528c147185fac37", "pull_url": null, "state": "accepted", "archived": false, "hash": "3902be26538181d6d3363c9afe0938212b85fbc1", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22598/mbox/", "series": [ { "id": 4958, "url": "https://patchwork.libcamera.org/api/1.1/series/4958/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4958", "date": "2025-01-20T20:44:51", "name": "AEGC controls", "version": 9, "mbox": "https://patchwork.libcamera.org/series/4958/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22598/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22598/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 01CABC3315\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 20 Jan 2025 20:45:49 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 622CB68564;\n\tMon, 20 Jan 2025 21:45:49 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B2221684E7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 20 Jan 2025 21:45:37 +0100 (CET)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 08D8F22A;\n\tMon, 20 Jan 2025 21:44:35 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ag8YCE/l\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1737405876;\n\tbh=sYhT81i81W1qTVAQTvCU5bVXYNAIta96R39H/NyVcK0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ag8YCE/laa73dis7P3l2V1e/22ZUxuutaZ5LNxR6IpCa9WO+Jcy01yhYtDUn0lEHJ\n\tZ/B6KttykjUPDivXNbqC6FJsQtcW7MEyIK4S1U6fD2qD/jHCv9HK/fgYzM/bXFobVZ\n\tHkq5nSsQ4Mm1z8MGMQx+M/NVKIbuIDKSMjXwWSXg=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Naushir Patuck <naush@raspberrypi.com>,\n\tDavid Plowman <david.plowman@raspberrypi.com>,\n\tPaul Elder <paul.elder@ideasonboard.com>", "Subject": "[PATCH v9 11/12] ipa: rkisp1: agc: Report new AeEnable control as\n\tavailable", "Date": "Mon, 20 Jan 2025 22:45:02 +0200", "Message-ID": "<20250120204515.24096-12-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.45.2", "In-Reply-To": "<20250120204515.24096-1-laurent.pinchart@ideasonboard.com>", "References": "<20250120204515.24096-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Paul Elder <paul.elder@ideasonboard.com>\n\nEven though the new AeEnable control internally switches on and off the\nsub-controls (ExposureTimeMode and AnalogueGainMode), it still needs to\nbe declared as available. Report this control as available in the\nrkisp1 IPA.\n\nSupport for the control does not need to be added as it is handled by\nthe Camera class. It does not need to be handled in metadata either as\nthe new version of AeEnable is not returned in metadata.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Stefan Klug <stefan.klug@ideasonboard.com>\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/rkisp1/algorithms/agc.cpp | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\nindex 78122a1f05f8..1680669c6875 100644\n--- a/src/ipa/rkisp1/algorithms/agc.cpp\n+++ b/src/ipa/rkisp1/algorithms/agc.cpp\n@@ -156,6 +156,8 @@ int Agc::init(IPAContext &context, const YamlObject &tuningData)\n \t\tControlInfo(static_cast<int32_t>(controls::AnalogueGainModeAuto),\n \t\t\t static_cast<int32_t>(controls::AnalogueGainModeManual),\n \t\t\t static_cast<int32_t>(controls::AnalogueGainModeAuto));\n+\t/* \\todo Move this to the Camera class */\n+\tcontext.ctrlMap[&controls::AeEnable] = ControlInfo(false, true, true);\n \tcontext.ctrlMap.merge(controls());\n \n \treturn 0;\n", "prefixes": [ "v9", "11/12" ] }