Patch Detail
Show a patch.
GET /api/1.1/patches/22568/?format=api
{ "id": 22568, "url": "https://patchwork.libcamera.org/api/1.1/patches/22568/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22568/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250114182143.1773762-8-pobrn@protonmail.com>", "date": "2025-01-14T18:22:22", "name": "[RFC,v2,07/16] apps: lc-compliance: Optimize `std::shared_ptr` usage", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "0c4929949797691510310e2c118dc54175493afb", "submitter": { "id": 133, "url": "https://patchwork.libcamera.org/api/1.1/people/133/?format=api", "name": "Pőcze Barnabás", "email": "pobrn@protonmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22568/mbox/", "series": [ { "id": 4951, "url": "https://patchwork.libcamera.org/api/1.1/series/4951/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4951", "date": "2025-01-14T18:21:46", "name": "apps: lc-compliance: Multi-stream tests", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4951/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22568/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22568/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 42440C3301\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 14 Jan 2025 18:22:28 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 09AFB6854E;\n\tTue, 14 Jan 2025 19:22:28 +0100 (CET)", "from mail-10629.protonmail.ch (mail-10629.protonmail.ch\n\t[79.135.106.29])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F1D166854C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 14 Jan 2025 19:22:26 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"gXLkZyTr\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1736878946; x=1737138146;\n\tbh=MNLSu6mkLawqXE/2yDtVn/bcBeJOWkgvPwdl+gHqEfg=;\n\th=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;\n\tb=gXLkZyTrXPi9XEVzL7IKybHegq1RN1oqe6JPtGBdGidkl/V23KEcqncflgpKQocdj\n\tAmtD8UOOZZL7YTGh1gYZBnhua2zU5k1Rz9/tQb7/bGlXqExBxYaJSLseHo0MqVdvia\n\tiVIQNeRAe2MWsxkHqIy3DVfNDJ4TFEiVN/Z4XTTR2r1liL6tpvnXvgf871an5gMlle\n\t/DmvdUF+zVAxTtdD+U/6+dxhohAD12gDsXc5xTyjchYbXd3gs2a45+Z0baqxzXFDkW\n\tESKr/bPBv/eC6TYqfbMNhrmG6LfbOq3R56a4b8FVN6GGXO/qh7pnmYRClln0aLDEm3\n\tgntonyXNhYNGw==", "Date": "Tue, 14 Jan 2025 18:22:22 +0000", "To": "libcamera-devel@lists.libcamera.org", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>", "Cc": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[RFC PATCH v2 07/16] apps: lc-compliance: Optimize `std::shared_ptr`\n\tusage", "Message-ID": "<20250114182143.1773762-8-pobrn@protonmail.com>", "In-Reply-To": "<20250114182143.1773762-1-pobrn@protonmail.com>", "References": "<20250114182143.1773762-1-pobrn@protonmail.com>", "Feedback-ID": "20568564:user:proton", "X-Pm-Message-ID": "2f282c01c417d9e32df0d5981dc2dd730a2b16ab", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=utf-8", "Content-Transfer-Encoding": "quoted-printable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Avoid unnecessary copies and try to move construct `std::shared_ptr`\nwhenever possible.\n\nSigned-off-by: Barnabás Pőcze <pobrn@protonmail.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/apps/lc-compliance/helpers/capture.cpp | 8 ++++----\n src/apps/lc-compliance/main.cpp | 4 +---\n 2 files changed, 5 insertions(+), 7 deletions(-)", "diff": "diff --git a/src/apps/lc-compliance/helpers/capture.cpp b/src/apps/lc-compliance/helpers/capture.cpp\nindex 90c1530ba..d1dafb6cf 100644\n--- a/src/apps/lc-compliance/helpers/capture.cpp\n+++ b/src/apps/lc-compliance/helpers/capture.cpp\n@@ -12,8 +12,8 @@\n using namespace libcamera;\n \n Capture::Capture(std::shared_ptr<Camera> camera)\n-\t: loop_(nullptr), camera_(camera),\n-\t allocator_(std::make_unique<FrameBufferAllocator>(camera))\n+\t: loop_(nullptr), camera_(std::move(camera)),\n+\t allocator_(std::make_unique<FrameBufferAllocator>(camera_))\n {\n }\n \n@@ -72,7 +72,7 @@ void Capture::stop()\n /* CaptureBalanced */\n \n CaptureBalanced::CaptureBalanced(std::shared_ptr<Camera> camera)\n-\t: Capture(camera)\n+\t: Capture(std::move(camera))\n {\n }\n \n@@ -144,7 +144,7 @@ void CaptureBalanced::requestComplete(Request *request)\n /* CaptureUnbalanced */\n \n CaptureUnbalanced::CaptureUnbalanced(std::shared_ptr<Camera> camera)\n-\t: Capture(camera)\n+\t: Capture(std::move(camera))\n {\n }\n \ndiff --git a/src/apps/lc-compliance/main.cpp b/src/apps/lc-compliance/main.cpp\nindex 3f1d2a61b..98f2573d0 100644\n--- a/src/apps/lc-compliance/main.cpp\n+++ b/src/apps/lc-compliance/main.cpp\n@@ -50,8 +50,6 @@ static void listCameras(CameraManager *cm)\n \n static int initCamera(CameraManager *cm, OptionsParser::Options options)\n {\n-\tstd::shared_ptr<Camera> camera;\n-\n \tint ret = cm->start();\n \tif (ret) {\n \t\tstd::cout << \"Failed to start camera manager: \"\n@@ -66,7 +64,7 @@ static int initCamera(CameraManager *cm, OptionsParser::Options options)\n \t}\n \n \tconst std::string &cameraId = options[OptCamera];\n-\tcamera = cm->get(cameraId);\n+\tstd::shared_ptr<Camera> camera = cm->get(cameraId);\n \tif (!camera) {\n \t\tstd::cout << \"Camera \" << cameraId << \" not found, available cameras:\" << std::endl;\n \t\tlistCameras(cm);\n", "prefixes": [ "RFC", "v2", "07/16" ] }