Patch Detail
Show a patch.
GET /api/1.1/patches/22563/?format=api
{ "id": 22563, "url": "https://patchwork.libcamera.org/api/1.1/patches/22563/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22563/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250114182143.1773762-3-pobrn@protonmail.com>", "date": "2025-01-14T18:21:56", "name": "[RFC,v2,02/16] apps: common: event_loop: Disable copy/move", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "7ef779e21068dbb982d3a4ff118838a8eb82e94b", "submitter": { "id": 133, "url": "https://patchwork.libcamera.org/api/1.1/people/133/?format=api", "name": "Pőcze Barnabás", "email": "pobrn@protonmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22563/mbox/", "series": [ { "id": 4951, "url": "https://patchwork.libcamera.org/api/1.1/series/4951/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4951", "date": "2025-01-14T18:21:46", "name": "apps: lc-compliance: Multi-stream tests", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4951/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22563/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22563/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 317EDC3301\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 14 Jan 2025 18:22:02 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DF992607D6;\n\tTue, 14 Jan 2025 19:22:01 +0100 (CET)", "from mail-4322.protonmail.ch (mail-4322.protonmail.ch\n\t[185.70.43.22])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 727C2607D6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 14 Jan 2025 19:22:00 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"wcvcfo2e\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1736878920; x=1737138120;\n\tbh=Wp0RmpD70etEE/ATtJn2G0hd/QRpYx4CwO+U0XCuJ6k=;\n\th=Date:To:From:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post;\n\tb=wcvcfo2eu8JSAuxCoZkalj+Gkk538dRzk5XvYjaDSzT9LiU9wonw4OAvplp7d+Wm4\n\tdDd+DGgS/60o5fTMNa0Z4gx1f5GlWCHC93rzVWCIxxOFasBxi72gNUK9PTqhMIggbl\n\tQW9iHzzRU5tDTneqsh4zzdekNwITuxenK+ksXLwhEA3hD0feJg1ksppynxqzujZzSz\n\tTJexHeg41IYfiYjpIgG7CWBPylOvWWqT4l32F9KoUwgHdcKpXMqXzYOFdg0DqaCMcJ\n\toSUMyLNTuRYOJUzMKsQ6MP3gAZ/sMoFg79LEbnADypDbSwVuc4VE7SL5zJ5ImvrXN0\n\txoG7Imo1FXzjQ==", "Date": "Tue, 14 Jan 2025 18:21:56 +0000", "To": "libcamera-devel@lists.libcamera.org", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>", "Subject": "[RFC PATCH v2 02/16] apps: common: event_loop: Disable copy/move", "Message-ID": "<20250114182143.1773762-3-pobrn@protonmail.com>", "In-Reply-To": "<20250114182143.1773762-1-pobrn@protonmail.com>", "References": "<20250114182143.1773762-1-pobrn@protonmail.com>", "Feedback-ID": "20568564:user:proton", "X-Pm-Message-ID": "3cfc531000f31e2f60431b00f7d9423fd4939cad", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=utf-8", "Content-Transfer-Encoding": "quoted-printable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The compiler generated functions are not appropriate, so\ndelete the copy/move constructor/assignment to avoid\npotential issues.\n\nSigned-off-by: Barnabás Pőcze <pobrn@protonmail.com>\n---\n src/apps/common/event_loop.h | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/src/apps/common/event_loop.h b/src/apps/common/event_loop.h\nindex d7d012c76..4e8dd0a46 100644\n--- a/src/apps/common/event_loop.h\n+++ b/src/apps/common/event_loop.h\n@@ -13,6 +13,8 @@\n #include <memory>\n #include <mutex>\n \n+#include <libcamera/base/class.h>\n+\n #include <event2/util.h>\n \n struct event_base;\n@@ -43,8 +45,11 @@ public:\n \t\t\t std::function<void()> &&handler);\n \n private:\n+\tLIBCAMERA_DISABLE_COPY_AND_MOVE(EventLoop)\n+\n \tstruct Event {\n \t\tEvent(std::function<void()> &&callback);\n+\t\tLIBCAMERA_DISABLE_COPY_AND_MOVE(Event)\n \t\t~Event();\n \n \t\tstatic void dispatch(int fd, short events, void *arg);\n", "prefixes": [ "RFC", "v2", "02/16" ] }