Patch Detail
Show a patch.
GET /api/1.1/patches/22558/?format=api
{ "id": 22558, "url": "https://patchwork.libcamera.org/api/1.1/patches/22558/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22558/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250113215946.1033762-12-paul.elder@ideasonboard.com>", "date": "2025-01-13T21:59:45", "name": "[v8,11/12] ipa: rkisp1: agc: Report new AeEnable control as available", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "3902be26538181d6d3363c9afe0938212b85fbc1", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22558/mbox/", "series": [ { "id": 4949, "url": "https://patchwork.libcamera.org/api/1.1/series/4949/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4949", "date": "2025-01-13T21:59:34", "name": "AEGC controls", "version": 8, "mbox": "https://patchwork.libcamera.org/series/4949/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22558/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22558/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A60E1C3311\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 13 Jan 2025 22:02:26 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 533C468536;\n\tMon, 13 Jan 2025 23:02:26 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C16AF68553\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 13 Jan 2025 23:02:23 +0100 (CET)", "from pyrite.hamster-moth.ts.net (unknown [173.16.167.215])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 64C5C4387;\n\tMon, 13 Jan 2025 23:01:26 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZOE3N5tV\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1736805687;\n\tbh=lq5kGCuheQrIqlLwkxwlJEe8cWaKetEBCAtalPkG5GQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ZOE3N5tVKpQO5uXRJF5LG6crxr+xWQ0L6Q/c/rWChqxqerJfWerXnLiWr/cpwOd5n\n\txk9FPR+4lYSpg41pNMDbvWzIStcNI+gtYVWfiw05c2UnlQjXirPDL2G1NLN5dW7l4y\n\tHo+G5cojutrmoqWl+VpaTh9YWLv304eX4L0DI/eE=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Paul Elder <paul.elder@ideasonboard.com>,\n\tlaurent.pinchart@ideasonboard.com, stefan.klug@ideasonboard.com", "Subject": "[PATCH v8 11/12] ipa: rkisp1: agc: Report new AeEnable control as\n\tavailable", "Date": "Mon, 13 Jan 2025 15:59:45 -0600", "Message-Id": "<20250113215946.1033762-12-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20250113215946.1033762-1-paul.elder@ideasonboard.com>", "References": "<20250113215946.1033762-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Even though the new AeEnable control internally switches on and off the\nsub-controls (ExposureTimeMode and AnalogueGainMode), it still needs to\nbe declared as available. Report this control as available in the\nrkisp1 IPA.\n\nSupport for the control does not need to be added as it is handled by\nthe Camera class. It does not need to be handled in metadata either as\nthe new version of AeEnable is not returned in metadata.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Stefan Klug <stefan.klug@ideasonboard.com>\n\n---\nChanges in v8:\n- add \"true\" as default value\n\nNo change in v7\n\nNew in v6\n---\n src/ipa/rkisp1/algorithms/agc.cpp | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\nindex 78122a1f0..1680669c6 100644\n--- a/src/ipa/rkisp1/algorithms/agc.cpp\n+++ b/src/ipa/rkisp1/algorithms/agc.cpp\n@@ -156,6 +156,8 @@ int Agc::init(IPAContext &context, const YamlObject &tuningData)\n \t\tControlInfo(static_cast<int32_t>(controls::AnalogueGainModeAuto),\n \t\t\t static_cast<int32_t>(controls::AnalogueGainModeManual),\n \t\t\t static_cast<int32_t>(controls::AnalogueGainModeAuto));\n+\t/* \\todo Move this to the Camera class */\n+\tcontext.ctrlMap[&controls::AeEnable] = ControlInfo(false, true, true);\n \tcontext.ctrlMap.merge(controls());\n \n \treturn 0;\n", "prefixes": [ "v8", "11/12" ] }