Patch Detail
Show a patch.
GET /api/1.1/patches/2255/?format=api
{ "id": 2255, "url": "https://patchwork.libcamera.org/api/1.1/patches/2255/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2255/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20191028022224.795355-8-niklas.soderlund@ragnatech.se>", "date": "2019-10-28T02:22:21", "name": "[libcamera-devel,07/10] libcamera: pipeline_handler: Do not use argument as local variable", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d38962e4e0fdce05fcd3ae295ccdf6051dd082e9", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2255/mbox/", "series": [ { "id": 560, "url": "https://patchwork.libcamera.org/api/1.1/series/560/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=560", "date": "2019-10-28T02:22:14", "name": "libcamera: Fixes found while working on new buffer API", "version": 1, "mbox": "https://patchwork.libcamera.org/series/560/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2255/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2255/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A18BC6017D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 28 Oct 2019 03:22:48 +0100 (CET)", "from localhost.localdomain (unknown [93.2.121.143])\n\tby bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid d3e66e4d-f929-11e9-903a-005056917f90;\n\tMon, 28 Oct 2019 03:22:45 +0100 (CET)" ], "X-Halon-ID": "d3e66e4d-f929-11e9-903a-005056917f90", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 28 Oct 2019 03:22:21 +0100", "Message-Id": "<20191028022224.795355-8-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.23.0", "In-Reply-To": "<20191028022224.795355-1-niklas.soderlund@ragnatech.se>", "References": "<20191028022224.795355-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 07/10] libcamera: pipeline_handler: Do not\n\tuse argument as local variable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 28 Oct 2019 02:22:49 -0000" }, "content": "In completeRequest() the request argument is used as a local variable,\nthis is confusing. Add a separate local variable instead of reusing the\nargument.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/libcamera/pipeline_handler.cpp | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex bf8c86d35c4fb6f4..f9ae767d529d44d9 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -409,13 +409,13 @@ void PipelineHandler::completeRequest(Camera *camera, Request *request)\n \tCameraData *data = cameraData(camera);\n \n \twhile (!data->queuedRequests_.empty()) {\n-\t\trequest = data->queuedRequests_.front();\n-\t\tif (request->status() == Request::RequestPending)\n+\t\tRequest *req = data->queuedRequests_.front();\n+\t\tif (req->status() == Request::RequestPending)\n \t\t\tbreak;\n \n-\t\tASSERT(!request->hasPendingBuffers());\n+\t\tASSERT(!req->hasPendingBuffers());\n \t\tdata->queuedRequests_.pop_front();\n-\t\tcamera->requestComplete(request);\n+\t\tcamera->requestComplete(req);\n \t}\n }\n \n", "prefixes": [ "libcamera-devel", "07/10" ] }