Patch Detail
Show a patch.
GET /api/1.1/patches/22539/?format=api
{ "id": 22539, "url": "https://patchwork.libcamera.org/api/1.1/patches/22539/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22539/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250113135108.13924-5-mzamazal@redhat.com>", "date": "2025-01-13T13:51:01", "name": "[v4,4/9] libcamera: software_isp: Use common code to store debayered pixels", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "1ed6d75c15a4692fc5964ea153bc62d262b5bda5", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/1.1/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22539/mbox/", "series": [ { "id": 4946, "url": "https://patchwork.libcamera.org/api/1.1/series/4946/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4946", "date": "2025-01-13T13:50:57", "name": "Software ISP support for CCM", "version": 4, "mbox": "https://patchwork.libcamera.org/series/4946/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22539/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22539/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E46A9C32F6\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 13 Jan 2025 13:51:37 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 99E4E6854B;\n\tMon, 13 Jan 2025 14:51:37 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 15B6668541\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 13 Jan 2025 14:51:35 +0100 (CET)", "from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-84-Jy_JgPvfPfWklz30NyUzNQ-1;\n\tMon, 13 Jan 2025 08:51:31 -0500", "from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.17])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id EF9B71956075; Mon, 13 Jan 2025 13:51:29 +0000 (UTC)", "from mzamazal-thinkpadp1gen3.tpbc.com (unknown [10.45.224.6])\n\tby mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id A445B1955BE3; Mon, 13 Jan 2025 13:51:27 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"Y0Qju6/1\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1736776294;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=JRPXyvmu52/wDdirpWjkxW4wp9Well/O1B2jolE1zHA=;\n\tb=Y0Qju6/167NgTS69W8YAgPLucuGPVVTiJPfExh0Za0JCIZ3uJoWH6U3k5eWlmtgsMK4/Af\n\tZTpxsjqs/cTEbv7y0jHgJP70DUtFpQvP2tE/11NbnacOHZZ4tP3WiU9ONHNFgDcBS7a8PM\n\t7jXb/V07YBLsBxUjK8ye+2Vtw8Yg1rM=", "X-MC-Unique": "Jy_JgPvfPfWklz30NyUzNQ-1", "X-Mimecast-MFC-AGG-ID": "Jy_JgPvfPfWklz30NyUzNQ", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tRobert Mader <robert.mader@collabora.com>,\n\tHans de Goede <hdegoede@redhat.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v4 4/9] libcamera: software_isp: Use common code to store\n\tdebayered pixels", "Date": "Mon, 13 Jan 2025 14:51:01 +0100", "Message-ID": "<20250113135108.13924-5-mzamazal@redhat.com>", "In-Reply-To": "<20250113135108.13924-1-mzamazal@redhat.com>", "References": "<20250113135108.13924-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.17", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "sZOdgUsYMNzClETSn6WbkEckqJe6hmxNkIsLOaV_K-U_1736776290", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The debayering macros use the same pattern, let's extract it to a common\nmacro. This reduces code duplication a bit now and it'll make changes\nof debayering easier when color correction matrix is introduced.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/software_isp/debayer_cpu.cpp | 56 +++++++++++-----------\n 1 file changed, 28 insertions(+), 28 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/debayer_cpu.cpp b/src/libcamera/software_isp/debayer_cpu.cpp\nindex 31ab96ab..0eabced2 100644\n--- a/src/libcamera/software_isp/debayer_cpu.cpp\n+++ b/src/libcamera/software_isp/debayer_cpu.cpp\n@@ -62,57 +62,57 @@ DebayerCpu::~DebayerCpu() = default;\n \tconst pixel_t *curr = (const pixel_t *)src[1] + xShift_; \\\n \tconst pixel_t *next = (const pixel_t *)src[2] + xShift_;\n \n+#define STORE_PIXEL(b, g, r) \\\n+\t*dst++ = blue_[b]; \\\n+\t*dst++ = green_[g]; \\\n+\t*dst++ = red_[r]; \\\n+\tif constexpr (addAlphaByte) \\\n+\t\t*dst++ = 255; \\\n+\tx++;\n+\n /*\n * RGR\n * GBG\n * RGR\n */\n-#define BGGR_BGR888(p, n, div) \\\n-\t*dst++ = blue_[curr[x] / (div)]; \\\n-\t*dst++ = green_[(prev[x] + curr[x - p] + curr[x + n] + next[x]) / (4 * (div))]; \\\n-\t*dst++ = red_[(prev[x - p] + prev[x + n] + next[x - p] + next[x + n]) / (4 * (div))]; \\\n-\tif constexpr (addAlphaByte) \\\n-\t\t*dst++ = 255; \\\n-\tx++;\n+#define BGGR_BGR888(p, n, div) \\\n+\tSTORE_PIXEL( \\\n+\t\tcurr[x] / (div), \\\n+\t\t(prev[x] + curr[x - p] + curr[x + n] + next[x]) / (4 * (div)), \\\n+\t\t(prev[x - p] + prev[x + n] + next[x - p] + next[x + n]) / (4 * (div)))\n \n /*\n * GBG\n * RGR\n * GBG\n */\n-#define GRBG_BGR888(p, n, div) \\\n-\t*dst++ = blue_[(prev[x] + next[x]) / (2 * (div))]; \\\n-\t*dst++ = green_[curr[x] / (div)]; \\\n-\t*dst++ = red_[(curr[x - p] + curr[x + n]) / (2 * (div))]; \\\n-\tif constexpr (addAlphaByte) \\\n-\t\t*dst++ = 255; \\\n-\tx++;\n+#define GRBG_BGR888(p, n, div) \\\n+\tSTORE_PIXEL( \\\n+\t\t(prev[x] + next[x]) / (2 * (div)), \\\n+\t\tcurr[x] / (div), \\\n+\t\t(curr[x - p] + curr[x + n]) / (2 * (div)))\n \n /*\n * GRG\n * BGB\n * GRG\n */\n-#define GBRG_BGR888(p, n, div) \\\n-\t*dst++ = blue_[(curr[x - p] + curr[x + n]) / (2 * (div))]; \\\n-\t*dst++ = green_[curr[x] / (div)]; \\\n-\t*dst++ = red_[(prev[x] + next[x]) / (2 * (div))]; \\\n-\tif constexpr (addAlphaByte) \\\n-\t\t*dst++ = 255; \\\n-\tx++;\n+#define GBRG_BGR888(p, n, div) \\\n+\tSTORE_PIXEL( \\\n+\t\t(curr[x - p] + curr[x + n]) / (2 * (div)), \\\n+\t\tcurr[x] / (div), \\\n+\t\t(prev[x] + next[x]) / (2 * (div)))\n \n /*\n * BGB\n * GRG\n * BGB\n */\n-#define RGGB_BGR888(p, n, div) \\\n-\t*dst++ = blue_[(prev[x - p] + prev[x + n] + next[x - p] + next[x + n]) / (4 * (div))]; \\\n-\t*dst++ = green_[(prev[x] + curr[x - p] + curr[x + n] + next[x]) / (4 * (div))]; \\\n-\t*dst++ = red_[curr[x] / (div)]; \\\n-\tif constexpr (addAlphaByte) \\\n-\t\t*dst++ = 255; \\\n-\tx++;\n+#define RGGB_BGR888(p, n, div) \\\n+\tSTORE_PIXEL( \\\n+\t\t(prev[x - p] + prev[x + n] + next[x - p] + next[x + n]) / (4 * (div)), \\\n+\t\t(prev[x] + curr[x - p] + curr[x + n] + next[x]) / (4 * (div)), \\\n+\t\tcurr[x] / (div))\n \n template<bool addAlphaByte>\n void DebayerCpu::debayer8_BGBG_BGR888(uint8_t *dst, const uint8_t *src[])\n", "prefixes": [ "v4", "4/9" ] }