Patch Detail
Show a patch.
GET /api/1.1/patches/225/?format=api
{ "id": 225, "url": "https://patchwork.libcamera.org/api/1.1/patches/225/?format=api", "web_url": "https://patchwork.libcamera.org/patch/225/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190114100346.17925-1-kieran.bingham@ideasonboard.com>", "date": "2019-01-14T10:03:46", "name": "[libcamera-devel] meson: Utilise default compiler options", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "67afd1eec68e68e6109dd9861862baf581e96e92", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/225/mbox/", "series": [ { "id": 78, "url": "https://patchwork.libcamera.org/api/1.1/series/78/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=78", "date": "2019-01-14T10:03:46", "name": "[libcamera-devel] meson: Utilise default compiler options", "version": 1, "mbox": "https://patchwork.libcamera.org/series/78/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/225/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/225/checks/", "tags": {}, "headers": { "Return-Path": "<kieran.bingham@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 54AD360B31\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 14 Jan 2019 11:03:50 +0100 (CET)", "from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EB7E5505;\n\tMon, 14 Jan 2019 11:03:49 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1547460230;\n\tbh=ne4NRxeRrpnRUAIQrr6UP9hKY9khhrh2LxwIhVsZymM=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=s2azKaI22jtr636a3JoyUBhTJivEVYW31XbYkGDpNqbkNnasNCOvj+m94N5rFIBdQ\n\t+JLDvZzDmLs+5ciJKCkcUk1Lxcyzt4+lI0FmOWuBNW/aJVgZLvoCXUL2XuF5tl3LMJ\n\tuMljeMMygSpGsM5xQzpj1M0x1wrYohpXlCX8QYIc=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "LibCamera Devel <libcamera-devel@lists.libcamera.org>", "Date": "Mon, 14 Jan 2019 10:03:46 +0000", "Message-Id": "<20190114100346.17925-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[libcamera-devel] [PATCH] meson: Utilise default compiler options", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 14 Jan 2019 10:03:50 -0000" }, "content": "Remove our custom declarations for cpp_std=c++11 and -Werror, instead\nprefering to use the built-in default_option parameters from meson.\n\nOur custom compiler flags (such as -Wno-unused-parameter) are\nmaintained.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n meson.build | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/meson.build b/meson.build\nindex 0ab0da981083..37640c39f5b8 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -1,6 +1,11 @@\n project('libcamera', 'c', 'cpp',\n meson_version: '>= 0.40',\n version : '0.1',\n+ default_options: [\n+ 'werror=true',\n+ 'warning_level=2',\n+ 'cpp_std=c++11',\n+ ],\n license : 'LGPL 2.1+')\n \n # TODO: Extract this from project.version.\n@@ -11,13 +16,11 @@ api_version = '0.1'\n common_arguments = [\n '-Wall',\n '-Wextra',\n- '-Werror',\n '-Wno-unused-parameter',\n ]\n \n c_arguments = common_arguments\n cpp_arguments = common_arguments\n-cpp_arguments += '-std=c++11'\n \n add_project_arguments(c_arguments, language: 'c')\n add_project_arguments(cpp_arguments, language: 'cpp')\n", "prefixes": [ "libcamera-devel" ] }