Patch Detail
Show a patch.
GET /api/1.1/patches/22409/?format=api
{ "id": 22409, "url": "https://patchwork.libcamera.org/api/1.1/patches/22409/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22409/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241219175729.293782-2-stefan.klug@ideasonboard.com>", "date": "2024-12-19T17:57:18", "name": "[v6,1/9] libcamera: controls: Update the ColourTemperature control to be writable", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "61fe7fce1fd5f6c3f0fb0ebc487485bdcdf7c09a", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22409/mbox/", "series": [ { "id": 4919, "url": "https://patchwork.libcamera.org/api/1.1/series/4919/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4919", "date": "2024-12-19T17:57:17", "name": "rkisp1: Add manual colour temperature control", "version": 6, "mbox": "https://patchwork.libcamera.org/series/4919/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22409/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22409/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0671BC3272\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 19 Dec 2024 17:57:41 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AA1AD6847A;\n\tThu, 19 Dec 2024 18:57:40 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D587D68474\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 19 Dec 2024 18:57:36 +0100 (CET)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:783:85f9:c998:cb11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 02F20163;\n\tThu, 19 Dec 2024 18:56:57 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Tfr8+kVi\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1734631018;\n\tbh=gBKkFpfgJw6XNxBewuXZNebSbn7yqoT5Z9X/wlPa62k=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Tfr8+kVi6eWXyZT5yf61dmTOl/A+tH13qmmfWyAUDrKSEwSZ8KGqnxeM36/J6SWlV\n\tET1ELxYynTFOfXBbcQCv1elL3uG8uSaEjFirLhOkqs5IdR7hCS0zFNRQ5GuLsClkFs\n\tckTp1N+0P0XiQ5bMRSZ8I1tQeNS9KQmLql4wk0l0=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>,\n\tPaul Elder <paul.elder@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v6 1/9] libcamera: controls: Update the ColourTemperature\n\tcontrol to be writable", "Date": "Thu, 19 Dec 2024 18:57:18 +0100", "Message-ID": "<20241219175729.293782-2-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20241219175729.293782-1-stefan.klug@ideasonboard.com>", "References": "<20241219175729.293782-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "For manual control it is helpful to be able to specify a fixed colour\ntemperature. It also provides an easy way to apply the temperature\nspecific CCMs and colour gains that are contained in the tuning files.\n\nDocument this and update the control dependencies.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n---\nChanges in v6:\n- Clarify interdependencies between ColourTemperature, ColourGains and\n ColourCorrectionMatrix\n\nChanges in v5:\n- Improve documentation\n---\n src/libcamera/control_ids_core.yaml | 38 +++++++++++++++++++++++++++--\n 1 file changed, 36 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\nindex 073e0611d47c..1dfaee0c6327 100644\n--- a/src/libcamera/control_ids_core.yaml\n+++ b/src/libcamera/control_ids_core.yaml\n@@ -298,7 +298,19 @@ controls:\n description: |\n Enable or disable the AWB.\n \n+ When AWB is enabled, the algorithm estimates the colour temperature of\n+ the scene and computes colour gains and the colour correction matrix\n+ automatically. The computed colour temperature, gains and correction\n+ matrix are reported in metadata. The corresponding controls are ignored\n+ if set in a request.\n+\n+ When AWB is disabled, the colour temperature, gains and correction\n+ matrix are not updated automatically and can be set manually in\n+ requests.\n+\n+ \\sa ColourCorrectionMatrix\n \\sa ColourGains\n+ \\sa ColourTemperature\n \n # AwbMode needs further attention:\n # - Auto-generate max enum value.\n@@ -357,17 +369,34 @@ controls:\n order.\n \n ColourGains can only be applied in a Request when the AWB is disabled.\n+ If ColourGains is set in a request but ColourTemperature is not, the\n+ implementation shall calculate and set the ColourTemperature based on\n+ the ColourGains.\n \n \\sa AwbEnable\n+ \\sa ColourTemperature\n size: [2]\n \n - ColourTemperature:\n type: int32_t\n direction: out\n description: |\n- Report the estimate of the colour temperature for the frame, in kelvin.\n+ ColourTemperature of the frame, in kelvin.\n+\n+ ColourTemperature can only be applied in a Request when the AWB is\n+ disabled.\n \n- The ColourTemperature control can only be returned in metadata.\n+ If ColourTemperature is set in a request but ColourGains is not, the\n+ implementation shall calculate and set the ColourGains based on the\n+ given ColourTemperature. If ColourTemperature is set (either directly,\n+ or indirectly by setting ColourGains) but ColourCorrectionMatrix is not,\n+ the ColourCorrectionMatrix is updated based on the ColourTemperature.\n+\n+ The ColourTemperature used to process the frame is reported in metadata.\n+\n+ \\sa AwbEnable\n+ \\sa ColourCorrectionMatrix\n+ \\sa ColourGains\n \n - Saturation:\n type: float\n@@ -429,6 +458,11 @@ controls:\n stored in conventional reading order in an array of 9 floating point\n values.\n \n+ ColourCorrectionMatrix can only be applied in a Request when the AWB is \n+ disabled.\n+\n+ \\sa AwbEnable\n+ \\sa ColourTemperature\n size: [3,3]\n \n - ScalerCrop:\n", "prefixes": [ "v6", "1/9" ] }