Patch Detail
Show a patch.
GET /api/1.1/patches/22387/?format=api
{ "id": 22387, "url": "https://patchwork.libcamera.org/api/1.1/patches/22387/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22387/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241218072025.2932205-1-qi.hou@nxp.com>", "date": "2024-12-18T07:20:25", "name": "[v4] gstreamer: Fixate colorimetry field during caps negotiation", "commit_ref": "3569fed7afc16fe31dfbccbfbaeb72a741bc8973", "pull_url": null, "state": "accepted", "archived": false, "hash": "c1d954a37cee8c1db53f95a3b11eaed108a8e633", "submitter": { "id": 195, "url": "https://patchwork.libcamera.org/api/1.1/people/195/?format=api", "name": "Qi Hou", "email": "qi.hou@nxp.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22387/mbox/", "series": [ { "id": 4908, "url": "https://patchwork.libcamera.org/api/1.1/series/4908/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4908", "date": "2024-12-18T07:20:25", "name": "[v4] gstreamer: Fixate colorimetry field during caps negotiation", "version": 4, "mbox": "https://patchwork.libcamera.org/series/4908/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22387/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22387/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9A71EC3304\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 18 Dec 2024 07:21:12 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7C4856807F;\n\tWed, 18 Dec 2024 08:21:11 +0100 (CET)", "from EUR05-DB8-obe.outbound.protection.outlook.com\n\t(mail-db8eur05on20615.outbound.protection.outlook.com\n\t[IPv6:2a01:111:f403:2614::615])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 87C5761898\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 18 Dec 2024 08:21:09 +0100 (CET)", "from PAXPR04MB8285.eurprd04.prod.outlook.com\n\t(2603:10a6:102:1ca::15)\n\tby PAXPR04MB8845.eurprd04.prod.outlook.com (2603:10a6:102:20c::14)\n\twith Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8272.13;\n\tWed, 18 Dec 2024 07:21:07 +0000", "from PAXPR04MB8285.eurprd04.prod.outlook.com\n\t([fe80::e003:8fb:64ea:acfd]) by\n\tPAXPR04MB8285.eurprd04.prod.outlook.com\n\t([fe80::e003:8fb:64ea:acfd%6]) with mapi id 15.20.8251.015;\n\tWed, 18 Dec 2024 07:21:07 +0000" ], "Authentication-Results": [ "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"lI2/ao0s\";\n\tdkim-atps=neutral", "dkim=none (message not signed)\n\theader.d=none;dmarc=none action=none header.from=nxp.com;" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n\tb=LXoZ5bMonabY0xAe6Swn+uiv2JGueqCBM+qSRwW0ItmbXN2pmMZVCVefxqAi1PklVhLhL6KEjSyi0qJNz7eG6+xcM4sRIK/fu28lo77l4cDTO/knLOUht2t9kvRsxcQgENa6hDn0jUr9oFFela0kFex5vjwZBXSIJn/6fJZH9tBwDz8JoakVR9iqgyt61gtASi+S8cwwQ854VWJPqu30vEYcEjxmVdCxCGOOZcrLifr2xc4Z5EsEbn1wXGhzqmKzQqj+/ktEMwMiryEuSBPwG1gZGGF97wQDpmSTztG5XafgRrZVPhMXM9e3Db+H0APIzglopGGBNj5z/SSwsk+8qA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector10001;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n\tbh=RRGXOhgffpYX+spCJQhe1Smv74p6QDDz8/4cGqE3iSY=;\n\tb=TUPPtCngBZ6DW+urXr8M9x7tHaOKNGRV9oWT1judkOTCnYU2zvHfaxkORpezbZpt+jhy8O6ftT+nRLsGE8jQovO69WdEzps1zO1Kl/VDNdotHNt6YLHmhFzHt01LPXpT+8rY8Zxf50/XPjrXaPf7M14FouI1gmdXurM2lzlUploXeTssduycN+nzhHCdlt10a8Dh0Z5RNTfGqKdadhJg5IJQHKQ/zwC2+3X7qtPbJigwm6JELRJ+IHjU5lD6wNMBacgTOwkKNDXLGZFTeOwo6nk9OeSu8D8+h7W152yc65rm38ZyRojsNn+YpAwEKfbowHXveD8e2STX14RIi6PGhg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n\tsmtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com;\n\tdkim=pass header.d=nxp.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=RRGXOhgffpYX+spCJQhe1Smv74p6QDDz8/4cGqE3iSY=;\n\tb=lI2/ao0sbM85O/M2e6UavizfIfxDuW02wO5uK9QrCXPNViJKU3BWBDMgQlXCmaPjODouV2CtRm5F20KYG8S58iUHQgusXLT8r1KzzB94f2MEYBEoZqL4LkT7CTEuhWGsSDha+wjI75VrYbCkx31iWNpajYU6IOynZbMLultlKgT+GqrMZF35EU1fVXbAud2gddS09UJfHMu+BXC12RgW1waUYtKpeq1keDTn4qSEy2FqJQNWbOXkz8uojhDOh/Qz1oUibP6IGiDNhts7TIRZDLBpgGRKKvYay+I8smFIEU71kqdssmsC8dmPXpHWpfczS5ZOqd/UlxcBLNDQrSEsSw==", "From": "Hou Qi <qi.hou@nxp.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "jared.hu@nxp.com,\n\tqi.hou@nxp.com,\n\tjulien.vuillaumier@nxp.com", "Subject": "[PATCH v4] gstreamer: Fixate colorimetry field during caps\n\tnegotiation", "Date": "Wed, 18 Dec 2024 16:20:25 +0900", "Message-Id": "<20241218072025.2932205-1-qi.hou@nxp.com>", "X-Mailer": "git-send-email 2.34.1", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "SGBP274CA0022.SGPP274.PROD.OUTLOOK.COM\n\t(2603:1096:4:b0::34)\n\tTo PAXPR04MB8285.eurprd04.prod.outlook.com\n\t(2603:10a6:102:1ca::15)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "PAXPR04MB8285:EE_|PAXPR04MB8845:EE_", "X-MS-Office365-Filtering-Correlation-Id": "1a8c586c-ec40-493d-c20a-08dd1f348a31", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;\n\tARA:13230040|52116014|376014|1800799024|366016|38350700014; ", "X-Microsoft-Antispam-Message-Info": "ZVO9fkGZbv7JQ1p43XeazZ1JKI/ccZZFc1ZwIWTKQ8SlyKRbJDY+UytBmuZ+OE57Udu7G83EFkGEpkUxvgspenw4d2zmcidW8KDSDcUf+mpVMc1XLIPn3/LP7uBDAupr6pNswCU5zZqMXNgtNQor2eIJUzf4EC5694KknoOZVP6CRoGI4qEq1VKjTiZfpS5H0FSN4sc5r7wOOZE0rMLS97qa13xIUkS59mV+SvCee8GpUyijZ8duw1d6mGCvZRx7ScXyToHEh7fM9x0Um/TVfFNFl1OVbZpUnTqDGOxOU4h6wFcq7LkQHXqPUjWiSH9ZfrqjvGw/FUVozvX7X2EqpwghFw2j9RNMjWXr5Qw5ecuEQRE0klh1ynkNn8pTIM+DbzFLm2sQnQIjZH90eD5siYyImiYG/iEFDGTEnJB68GYXAvOT6Bo4ZwYdkFT5Z4AHbw4ONQFjO1BfXr9mHdmzL0l5aOfjkUujxBzQXdEbSv4OjgbgMP1TQGaipslcXSojVdnX9Anw5AlT0Y1u9WMJ5qZhAqz9A+O1O2L7wOvBYt97nzTaW/qEuKKJ1URTWUNGHAa9ht2JBj0dnAomW6fh82j2NaIlqx7Efa3Ra6zJ3LkVoCIu8KRjNdZ9das+Xvm/PKdQ9vh3a6dMbQckGgyV0tN92xUe8dFofrZCUF/RfkkW2wIuuDkPHlBED8Z/BxwrJkuH8wOlu8i59P20UJVUOghsRjSsa6GPPYbaEsXVlQv7r30+gP2rSmgpUVoPxeU5He5FhvP+v1hnZpCbH2wtXqcBpvPOcgF6pXseFS3NFeNmADOj0Sh/JnSS4D1CJ3+EmYanmWElcFxhUVdUALKCydOrg6T4gBROQirozhyxf0gBowPqmPqIt9xAOFkX2GxrliMc6IKVtHZ39WLG3DJ0DbkwPiR8CA48pi3GS7Ytx7DK6UX4cg9tnbPdJ5Q/wTmOfEcQbSZ4BF9TsSJaZ9Go5YjLeB1DZumvlosNHGozKO8UMfWO0HlFCSrH+dlRkpQWbj6O65oWzHnzvZ+PU4BAhXEjX0HZtbMkuQ93DsvfU5+RzFjMq/ezMe6yLw0fUUW78tdCZQNj4gzvSO8e5qlQQjs3gF4FrEb9hCnIsa37BG4nd+aNYbnpTSqByZ4Kke2x+B85wo7hIZUWk3/ch3P8AZu+NHSwRIzsanvIBtOdpHzVwzUUHM+VAl8L1anBjbEHt5qE6Ml9phWOmFsBrR7412/uyj0zw2YchMLspbmC4auHosgbSy3VOCKQL8Rg88y7NggbRSavxaNw02Amt4EF5Oi2r+hVZUNpLWMY4rJ6ZOSyt/bgv9J/tk/5YouPmO75iktUVZsuslEhWTZD7HM4wYNk5Rdfc2M9JSyqbK63MpmvwDzCUYvKHp7sKQPx9y/ODW/pLEzk5aaEB09vuOn3HiqYO1SCp/htMGuNA2DQdThvtaWoXPaJHN1UB9Dg0lIN", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n\tIPV:NLI; SFV:NSPM; H:PAXPR04MB8285.eurprd04.prod.outlook.com; PTR:;\n\tCAT:NONE; \n\tSFS:(13230040)(52116014)(376014)(1800799024)(366016)(38350700014);\n\tDIR:OUT; SFP:1101; ", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "BNmxL0vD1ztY8hOXD1fNG0D1wntBQfW9akjKGwcG1GeA0UHwR2xVPNtbf6KsGjiXNIhfTBjmqxlQWIdzKL8BZpiUlj5uPwUhOdSgAKvCC/kM1TgXwwJSWeyxY+TIWmRJDFbVHh7JYodLnW5wBxbDrCg4WEVzVncp+RCFjeZfShFnLO8DESYy2vpXeezc6agBb5Q+QOM4O4bcgizus9LocH/ko29sh6pdX/NbVogQbi1AidnVQA5JGglM3M8+/zYkv8N8h7aE84sED5exdKkkg1eDMPx2DnoMJ8SioTfn/ArmO4uUoi5apexLWXxs6e/o+DGSCbXUa96dIohStWxmHxizVpaF2GuJnEzKvoONzv/cyWS30TrZMt0eBPnPXN/WnoOqc6AOnla8CSZ+3mY51mv/R15e1I2XLCDozhV8i7DTWkIs6M09VrL8ELUgR95Ml0Pywiz4HJafpDdnnI1ZnQt+Ua/ZDQoqAzJe1fd33Fqi2H22YwblyzCR5MzS7VGtAN/IjpUBwNf9j1QD9tBhliNS6K4exCWxvWJ00+r2XvXwkvttIDW71AyD+EAAjRKev3OzQIhfk+vZV+fuqGBJk3lg7J/SI38xEauuB0IZrYFqqnWVuiLaFQ7W7XvcNMnHO0+I4YyY98QcJYAs2RNlSTsbe4Se9mZ+t6aVAujkHFWoMCABda2FMKrgo758QC8sByFz+nJVed5BWnujotY0Jr3PPB/qMy82/bcEoSPdllu6T9axuFbx29IWsueqaD5jJ5iJk0Wb1eCvwcAiMoGSdzDz2obuj/tfyP3QlWsp6zm4WM2xTU6iUO6BXzVomgdEKs3HqB9XhhpGnP+82hwSZ0yG82rky5r2wvrCqnR2aE+oKpNlmMId7iT15/p4rrLUxasaQvkQGl/dKsLrrZYFMOrA7/oOGiyL4uYQ+RPeogz1VxW+3rkffIfMzbXK1jrCCOuqSG+nVY9tF2i33bKQprioz/MsBD5MRKgI1kMZbfnWIebEuenqywkJJ4PuftDHnxjgwT8uxrXmgqHc5UeJvFFpVOjDV4OM6ovvvZ59nHgz/COHG2juxu6rkAjJRMh9Oq8/QGqt1C8wZYpLxpvCwT4ja2d4005t9BmQK5hW+LO54NwM46enUWEP6SNxPytDL1eNEI5qsfVAmRyfPw74jgcY5tMQlveX+vpJfK0VkZ1WYvF9uTM7d6sIkHdnx5yqU8hDBu4mco6bAItLR/g/G+d6hmmthvnBJV7D/uSPCJ9Juj3EQ50klONdkprpufD7C/Q6xe6lSuSSvIVxXCOt1hNCElPyTj4y0ECn6bPHN483HvpB283M85/lOMfVvKtjTwtorJOMGXtoZPlqrph+uh6YXm/cZy5VD2GW66lPU557vGvb9sQxjjYLlJLELYxnKILoLiNMluiTLg9ksToE6lSraNBMC4G4SVBeFNoHs4GhqQyHRSnGOJL28UoH4N5l9GwEqZ4jsjrSqt/Hf1WxVlgkJ1byHY49CiJVMqALjxG1ZBQlrpLx9E8UXkkC/Q614N2ck4tD3JND/Hon7/RAcZwPZjCcdGUvJcf068P03AY=", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "1a8c586c-ec40-493d-c20a-08dd1f348a31", "X-MS-Exchange-CrossTenant-AuthSource": "PAXPR04MB8285.eurprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "18 Dec 2024 07:21:07.7076\n\t(UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "/BL5v+Poc7bT2UmH1vF7kCEFDyP0xsY2amOvQ6lqDODuYeFw2MGav1RqYQ0sCmBv", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "PAXPR04MB8845", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When libcamerasrc is negotiating with downstream element, it first\nextracts colorimetry field from downstream supported caps, then set\nthis colorimetry to its stream configuration and propagates the\ncolorimetry downstream.\n\nCurrently libamerasrc only considers the case there is one colorimetry\nin colorimetry field of downstream caps. But the issue is that\ndownstream caps may report a list of supported colorimetry, which\ncauses libcamerasrc to set unknown colorimetry to stream configuration\nand negotiate fail with downstream element.\n\nIn order to fix the issue, need to fixate colorimetry field before\ngetting colorimetry string.\n\nSigned-off-by: Hou Qi <qi.hou@nxp.com>\n---\n src/gstreamer/gstlibcamera-utils.cpp | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\nindex a466b305..7b34c759 100644\n--- a/src/gstreamer/gstlibcamera-utils.cpp\n+++ b/src/gstreamer/gstlibcamera-utils.cpp\n@@ -493,9 +493,12 @@ void gst_libcamera_configure_stream_from_caps(StreamConfiguration &stream_cfg,\n \n \t/* Configure colorimetry */\n \tif (gst_structure_has_field(s, \"colorimetry\")) {\n-\t\tconst gchar *colorimetry_str = gst_structure_get_string(s, \"colorimetry\");\n+\t\tconst gchar *colorimetry_str;\n \t\tGstVideoColorimetry colorimetry;\n \n+\t\tgst_structure_fixate_field(s, \"colorimetry\");\n+\t\tcolorimetry_str = gst_structure_get_string(s, \"colorimetry\");\n+\n \t\tif (!gst_video_colorimetry_from_string(&colorimetry, colorimetry_str))\n \t\t\tg_critical(\"Invalid colorimetry %s\", colorimetry_str);\n \n", "prefixes": [ "v4" ] }