Patch Detail
Show a patch.
GET /api/1.1/patches/22379/?format=api
{ "id": 22379, "url": "https://patchwork.libcamera.org/api/1.1/patches/22379/?format=api", "web_url": "https://patchwork.libcamera.org/patch/22379/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241217151513.133599-1-pobrn@protonmail.com>", "date": "2024-12-17T15:15:16", "name": "[v1] meson: Don't override pipeline list when `auto` is selected", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "3c67c7b4800008a6f4233260db2a3e4d476df28a", "submitter": { "id": 133, "url": "https://patchwork.libcamera.org/api/1.1/people/133/?format=api", "name": "Pőcze Barnabás", "email": "pobrn@protonmail.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/22379/mbox/", "series": [ { "id": 4905, "url": "https://patchwork.libcamera.org/api/1.1/series/4905/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4905", "date": "2024-12-17T15:15:16", "name": "[v1] meson: Don't override pipeline list when `auto` is selected", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4905/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/22379/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/22379/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 64A36C32F6\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 17 Dec 2024 15:15:25 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9EC6D67FD6;\n\tTue, 17 Dec 2024 16:15:24 +0100 (CET)", "from mail-40133.protonmail.ch (mail-40133.protonmail.ch\n\t[185.70.40.133])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1BF2467F0D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 17 Dec 2024 16:15:23 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"nLMjSXvk\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1734448522; x=1734707722;\n\tbh=I2pH3oiSCkESrFWIUpjaLHI6FoXi6cM70EYGqmicIfI=;\n\th=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date:\n\tSubject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector:\n\tList-Unsubscribe:List-Unsubscribe-Post;\n\tb=nLMjSXvkyVTbH31IKHDT1GUpfO/f24KbUMgF7JumU3A9d8CO53KT/BH1qYeyA4GbN\n\toTJCwf/+uTCDuRhcg+HXX/IbwaT+EEbpvhfRVHA/KW3SzZv64u6rBlVExWiBVM3FGN\n\t8xRdFTR8eFY2jzfnDUKpCR3OBPWJ7Sto/DeFDOZFzYjg7hEJe8PYsbmH9xNvu+VtR/\n\t3Rg5jHsZqFg+ia77SjeUqv5J1Q18NIzTJPpmB2Kq2kVIBtcVPmAqB009ZHZppC6uYk\n\tqovHRA2QyhjL8NdHstXDQd7w6RVSQEhJSCYnn/Jz2vwKun0xRbparGUuseLMNkalGZ\n\tSUUXHuW2F+16w==", "Date": "Tue, 17 Dec 2024 15:15:16 +0000", "To": "libcamera-devel@lists.libcamera.org", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>", "Subject": "[PATCH v1] meson: Don't override pipeline list when `auto` is\n\tselected", "Message-ID": "<20241217151513.133599-1-pobrn@protonmail.com>", "Feedback-ID": "20568564:user:proton", "X-Pm-Message-ID": "11a699e9e213a302c3922fef3c65c81dbc29d894", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=utf-8", "Content-Transfer-Encoding": "quoted-printable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Consider `pipelines=auto,virtual`. Previously that would select\neverything that `auto` would, but not actually enable the `virtual`\npipeline handler because the `pipelines` list was reset.\n\nBug: https://bugs.libcamera.org/show_bug.cgi?id=247\nSigned-off-by: Barnabás Pőcze <pobrn@protonmail.com>\n---\n meson.build | 10 ++++++----\n 1 file changed, 6 insertions(+), 4 deletions(-)", "diff": "diff --git a/meson.build b/meson.build\nindex 33afbb741..5e5e4756d 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -204,7 +204,7 @@ liblttng = dependency('lttng-ust', required : get_option('tracing'))\n \n # Pipeline handlers\n #\n-pipelines = get_option('pipelines')\n+wanted_pipelines = get_option('pipelines')\n \n arch_arm = ['arm', 'aarch64']\n arch_x86 = ['x86', 'x86_64']\n@@ -220,16 +220,18 @@ pipelines_support = {\n 'virtual': ['test'],\n }\n \n-if pipelines.contains('all')\n+if wanted_pipelines.contains('all')\n pipelines = pipelines_support.keys()\n-elif pipelines.contains('auto')\n+elif wanted_pipelines.contains('auto')\n host_cpu = host_machine.cpu_family()\n pipelines = []\n foreach pipeline, archs : pipelines_support\n- if host_cpu in archs or 'any' in archs\n+ if pipeline in wanted_pipelines or host_cpu in archs or 'any' in archs\n pipelines += pipeline\n endif\n endforeach\n+else\n+ pipelines = wanted_pipelines\n endif\n \n # Tests require the vimc pipeline handler, include it automatically when tests\n", "prefixes": [ "v1" ] }